[Kazafka]

Hello,

I've been trying to make a simple script to change player's name when they join. The problem is, that I recently get this error: error 008: must be a constant expression; assumed zero (line 22nd).

#include <sourcemod>
#include <sdktools_functions>

// Info na temat plugina - Plugin info
public Plugin:myinfo = {
	name = "CSMaxShot Core",
	author = "Kazafka",
	description = "Dobry plugin, polecam!",
	version = "0.0.3"
}

// Zmiana pseudonimu gracza - Player's alias changing
public OnClientPutInServer(client) {
	char name[MAX_NAME_LENGTH], group[MAX_NAME_LENGTH]
	new target = FindTarget(client, "")
	
	GetClientName(client, name, sizeof(name))
	AdminId aid = GetUserAdmin(target)
	GroupId gid = GetAdminGroup(aid, 0, group, sizeof(group))
	
	if(gid) {
		char group2[MAX_NAME_LENGTH] = StrCat(group, sizeof(group), name) // Here's the error
		SetClientName(client, group2)
	}
}

[GsiX]

StrCat() return int, you probably don't need the array char group2[]. Just use the group array to set the player name. Depending on what you try to achieve.
Assuming 22nd is the error coz i m on mobile phone.

https://sourcemod.dev/#/string/function.StrCat

[Kazafka]

Umm, actually I'm going to test this out:

#include <sourcemod>
#include <sdktools_functions>

// Info na temat plugina - Plugin info
public Plugin:myinfo = {
	name = "CSMaxShot Core",
	author = "Kazafka",
	description = "Dobry plugin, polecam!",
	version = "0.0.3"
}

// Zmiana pseudonimu gracza - Player's alias changing
public OnClientPutInServer(client) {
	char name[MAX_NAME_LENGTH], group[MAX_NAME_LENGTH]
	new target = FindTarget(client, "")
	
	GetClientName(client, name, sizeof(name))
	AdminId aid = GetUserAdmin(target)
	GroupId gid = GetAdminGroup(aid, 0, group, sizeof(group))
	
	StrCat(group, sizeof(group), name)
	
	if(gid) {
		SetClientName(client, group)
	}
}

And yeah, the compiler didn't throw any error but now let's test if it does work in the game lol.

[Kazafka]

Originally Posted by GsiX StrCat() return int, you probably don't need the array char group2[]. Just use the group array to set the player name. Depending on what you try to achieve. Assuming 22nd is the error coz i m on mobile phone. https://sourcemod.dev/#/string/function.StrCat

Nope, it doesn't change my nickname...

[GsiX]

i have no clue what i am doing so please do not quote me on this. i am just showing example.

edit: and... polishing and grinding my Polis if you don't mind me.

PHP Code:

#include <sourcemod>
#include <sdktools_functions>

// Info na temat plugina - Plugin info
public Plugin:myinfo = {
    name = "CSMaxShot Core",
    author = "Kazafka",
    description = "Dobry plugin, polecam!",
    version = "0.0.3"
}

// Zmiana pseudonimu gracza - Player's alias changing
public OnClientPostAdminCheck( client ) {
    if( client > 0 && CheckCommandAccess( client, "generic_admin", ADMFLAG_GENERIC, false )) { // to jest filtr

        char name[MAX_NAME_LENGTH], buffer[MAX_NAME_LENGTH]
        GetClientName( client, name, sizeof( name ))
        Format( buffer, sizeof( buffer ), "GODADMIN-%s", name ) // Nie wiem, co próbujesz zrobić
        SetClientName( client, buffer )
    }
} 


[Ilusion9]

What is wrong with your code:

PHP Code:

public OnClientPutInServer(client) {
    
    char name[MAX_NAME_LENGTH], group[MAX_NAME_LENGTH];
    // FindTarget is used in commands (example: sm_ban) to find a target from a a given string.
    // this is useless
    new target = FindTarget(client, "") // remove this
    
    GetClientName(client, name, sizeof(name)) // this get the clients name, nothing wrong
    AdminId aid = GetUserAdmin(target) // AdminId from target, this is useless, because we don't have a target
    GroupId gid = GetAdminGroup(aid, 0, group, sizeof(group)) // group id from target, this is useless, because we don't have a target
    
    StrCat(group, sizeof(group), name) // this should be included in a "if" statatement.
    
    if(gid) {
        SetClientName(client, group)
    }
} 


Try this:

PHP Code:


public OnClientPutInServer(client) {
    
    // get client name
    char name[MAX_NAME_LENGTH];
    GetClientName(client, name, sizeof(name));

    // get admin id
    AdminId adminId = GetUserAdmin(client);
    if (adminId == INVALID_ADMIN_ID)
    {
        // this client is not admin
        return;
    }

    // get group id
    if (GetAdminGroup(adminId, 0, group, sizeof(group) == INVALID_GROUP_ID)
    {
        // this client doesnt have a group
        return;
    }
    
    if (!StrEqual(name, group, true))
    {
        // client name is different than his group
        SetClientName(client, group);
    }
} 


[Kazafka]

Originally Posted by Ilusion9 What is wrong with your code: PHP Code: public OnClientPutInServer(client) {          char name[MAX_NAME_LENGTH], group[MAX_NAME_LENGTH];     // FindTarget is used in commands (example: sm_ban) to find a target from a a given string.     // this is useless     new target = FindTarget(client, "") // remove this          GetClientName(client, name, sizeof(name)) // this get the clients name, nothing wrong     AdminId aid = GetUserAdmin(target) // AdminId from target, this is useless, because we don't have a target     GroupId gid = GetAdminGroup(aid, 0, group, sizeof(group)) // group id from target, this is useless, because we don't have a target          StrCat(group, sizeof(group), name) // this should be included in a "if" statatement.          if(gid) {         SetClientName(client, group)     } }  Try this: PHP Code: public OnClientPutInServer(client) {          // get client name     char name[MAX_NAME_LENGTH];     GetClientName(client, name, sizeof(name));     // get admin id     AdminId adminId = GetUserAdmin(client);     if (adminId == INVALID_ADMIN_ID)     {         // this client is not admin         return;     }     // get group id     if (GetAdminGroup(adminId, 0, group, sizeof(group) == INVALID_GROUP_ID)     {         // this client doesnt have a group         return;     }          if (!StrEqual(name, group, true))     {         // client name is different than his group         SetClientName(client, group);     } }

Sorry for giving resposne after 2h, but unfortunetely, it doesn't work

[Ilusion9]

Because you have to edit my code, you have set a name if client is not admin and if client has no groups. The code works only if client has a group and his name is different than his group. Also, you didn't specified what do you want to do exactly, you just gave us a piece of code.