[asherkin]

Originally Posted by DaftMink Installed the extension, inc and test plugin but sm_setgamedescription only prints back the usage.

I made a typo in the plugin, either redownload and recompile the sp, or just add another argument after the description (it can be anything).

Originally Posted by DaftMink Edit: also using the "map mapname" command crashed the server.

I'll look into it.

Originally Posted by Sillium Linux dmp attached.

Thanks!

EDIT: Ok, I fixed it, it'll be in the next update.

[GoD-Tony]

Thanks for the reply.

Originally Posted by asherkin I'm afraid ISteamHTTP only gives me a uint64 to do this with, and I'm already using all 64-bits to store required information in (the plugin and callback function). The "handle" is provided by the ISteamHTTP API, it's not a SourceMod handle.

If I understand correctly, using SM's IHandleSys could solve both of these problems. You would have to wrap ISteamHTTP features into SM handles.

As an example, the cURL extension does this:

PHP Code:

native Handle:curl_easy_init(); 


static cell_t sm_curl_easy_init(IPluginContext *pContext, const cell_t *params)
{
	CURL *curl = curl_easy_init();
	if(curl == NULL)
	{
		return BAD_HANDLE;
	}

	cURLHandle *handle = new cURLHandle();
	memset(handle->errorBuffer,0,sizeof(handle->errorBuffer));
	memset(handle->callback_Function, 0, sizeof(handle->callback_Function));
	memset(handle->UserData,0,sizeof(handle->UserData));
	handle->curl = curl;

	Handle_t hndl = handlesys->CreateHandle(g_cURLHandle, handle, pContext->GetIdentity(), myself_Identity, NULL);
	if(!hndl)
	{
		curl_easy_cleanup(handle->curl);
		delete handle;
		return BAD_HANDLE;
	}

	handle->hndl = hndl;
	return hndl;
}

PHP Code:

native curl_easy_perform_thread(Handle:hndl, CURL_OnComplete:perform_callback, any:value=0); 


static cell_t sm_curl_easy_perform_thread(IPluginContext *pContext, const cell_t *params)
{
	SETUP_CURL_HANDLE();

	IPluginFunction *pFunction = pContext->GetFunctionById(params[2]);
	if(!pFunction)
	{
		return pContext->ThrowNativeError("Invalid function %x", params[2]);
	}

	handle->UserData[UserData_Type_Complete] = params[3];	
	handle->callback_Function[cURL_CallBack_COMPLETE] = pFunction;
	cURLThread *thread = new cURLThread(handle, cURLThread_Type_PERFORM);
	g_cURLManager.CreatecURLThread(thread);

	return 1;
}

[DaftMink]

Just want to say thanks.

Also here's the error message I get when I use the "map mapname" command to change maps.

http://i335.photobucket.com/albums/m...k/Untitled.png

[GoD-Tony]

After some further testing, I noticed that the HTTPRequestComplete callback isn't always sent. I can't pinpoint the problem as it seems to fail randomly. Sometimes it will download 5 files, then on the 6th the callback won't fire at all. Same results on Windows and Linux.

Here is the test case I used to reproduce it. While this looks like an infinite loop, it randomly stops by itself... sometimes.

PHP Code:

#pragma semicolon 1
#include <sourcemod>
#include <steamtools>

new attempts = 0;

public Steam_FullyLoaded()
{
    StartDownload();
}

StartDownload()
{
    if (attempts++ >= 1000)
    {
        PrintToServer("Stopping after 1000 downloads.");
        return;
    }
    
    PrintToServer("Download attempt %i...", attempts);
    
    new HTTPRequestHandle:hRequest = Steam_CreateHTTPRequest(HTTPMethod_GET, "http://godtony.mooo.com/updater/updater.txt");
    Steam_SendHTTPRequest(hRequest, OnSteamHTTPComplete);
}

public OnSteamHTTPComplete(HTTPRequestHandle:HTTPRequest, bool:requestSuccessful, HTTPStatusCode:statusCode)
{
    PrintToServer("Request successful: %s", requestSuccessful ? "Yes" : "No");
    
    if (requestSuccessful && statusCode == HTTPStatusCode_OK)
    {
        Steam_WriteHTTPResponseBody(HTTPRequest, "steamtools_test.txt");
    }

    Steam_ReleaseHTTPRequest(HTTPRequest);
    
    StartDownload();
} 


Download attempt 710...
Request successful: Yes
Download attempt 711...
Request successful: Yes
Download attempt 712...

- Stopped here so I reloaded it - 

sm plugins reload steamtools_test
[SM] Plugin steamtools_test.smx reloaded successfully.

Download attempt 1...
Request successful: Yes
Download attempt 2...
Request successful: Yes
Download attempt 3...
Request successful: Yes
Download attempt 4...
Request successful: Yes
Download attempt 5...
Request successful: Yes
Download attempt 6...
Request successful: Yes
Download attempt 7...

- Stopped again -

[asherkin]

0.8.1 released.

Changes:

• Fixed crash on server reinitialisation (i.e. the "map" command).
• Fixed missing SteamAPICall callbacks (e.g. HTTP download complete).
• Added passable data param to HTTP methods.

[Sillium]

Thank You!

[GoD-Tony]

Originally Posted by asherkin 0.8.1 released.

Tested the new fixes/features and it's working great.

[jungjunghoo]

Originally Posted by asherkin 0.8.1 released. Changes: Fixed crash on server reinitialisation (i.e. the "map" command). Fixed missing SteamAPICall callbacks (e.g. HTTP download complete). Added passable data param to HTTP methods.

0.8.1 stable work in linux?

[sinblaster]

Please excuse my lack of knowladge. I compiled the test plugin in the first post (and the inc) I copied the test plugin code, called it steamtools.sp and compiled it. I am using the plug for game desc

I my logs I am getting errors spammed as below. Is there something I have done wrong?

L 10/24/2011 - 216:10: Info (map "gg_chaos_arena_v1") (file "errors_20111024.log") L 10/24/2011 - 216:10: [SM] Plugin encountered error 15: Array index is out of bounds L 10/24/2011 - 216:10: [SM] Displaying call stack trace for plugin "steamtools.smx": L 10/24/2011 - 216:10: [SM] [0] Line 74, steamtools.sp::Steam_StatsUnloaded() L 10/24/2011 - 217:28: [SM] Plugin encountered error 15: Array index is out of bounds L 10/24/2011 - 217:28: [SM] Displaying call stack trace for plugin "steamtools.smx": L 10/24/2011 - 217:28: [SM] [0] Line 74, steamtools.sp::Steam_StatsUnloaded()

[m4ster]

My server console is being spammed with this on every httprequest: