Raised This Month: $226 Target: $400
 56% 

[ANY] Smart Link Remover


Post New Thread Reply   
 
Thread Tools Display Modes
Agent Wesker
Senior Member
Join Date: Apr 2012
Old 04-04-2017 , 16:29   Re: [ANY] Smart Link Remover
Reply With Quote #11

Quote:
Originally Posted by Totenfluch View Post
I have recoreded 73.000 player names and none of them had http in their name. So you can scrap that~
the MAX_NAME_LENGTH makes it literally impossible to have two links in a name that's why I didn't implement it
Other than that your regex looks extremly solid with 0 false positives and all matches in my ~350 name test - Well done!
If you send me a pull requests I'll merge it


we're having a discussion here:

https://github.com/Totenfluch/SmartLinkRemover/pull/1

if you want to join
I made a separate pull request because of the additional changes.

Also I have not yet tested on a live server so don't know if its working.
Agent Wesker is offline
altair540
Member
Join Date: Dec 2012
Old 04-04-2017 , 22:31   Re: [ANY] Smart Link Remover
Reply With Quote #12

Quote:
[SM] Exception reported: Invalid regex handle 8130317 (error 1)
Blaming: SmartLinkRemover.smx
Call stack trace:
[0] MatchRegex
[1] Line 47, E:\Users\19046000002\Downloads\scripting\Smar tLinkRemover.sp::checkNameURL
[2] Line 41, E:\Users\19046000002\Downloads\scripting\Smar tLinkRemover.sp::OnClientPostAdminCheck

Last edited by altair540; 04-04-2017 at 22:31.
altair540 is offline
Agent Wesker
Senior Member
Join Date: Apr 2012
Old 04-05-2017 , 08:28   Re: [ANY] Smart Link Remover
Reply With Quote #13

I tested this last night and it was working...

  • Did this error message come up right away or after a map change?
  • Did you download the latest version?
The attachment in OP was not updated, use the repo

OP has been updated with latest version.

Last edited by Agent Wesker; 04-06-2017 at 09:03.
Agent Wesker is offline
altair540
Member
Join Date: Dec 2012
Old 04-05-2017 , 11:32   Re: [ANY] Smart Link Remover
Reply With Quote #14

Put version 1.5, no error.
Nice plugin, Thanks!

Last edited by altair540; 04-05-2017 at 11:37.
altair540 is offline
Totenfluch
AlliedModders Donor
Join Date: Jan 2012
Location: Germany
Old 04-05-2017 , 12:40   Re: [ANY] Smart Link Remover
Reply With Quote #15

updated to 1.5
__________________
Notable Projects:
Event Item Spawner | Scissors, Rock, Paper for ZephStore
tVip | Smart Link Remover
PLG & GGC - CS:GO Roleplay

and countless more...

I can make a helicopter shoot missles if you want me to...
Totenfluch is offline
Totenfluch
AlliedModders Donor
Join Date: Jan 2012
Location: Germany
Old 04-06-2017 , 06:39   Re: [ANY] Smart Link Remover
Reply With Quote #16

Updated to 1.5.2 - updating is worth it!

Thanks again to @AgentWesker for the commits
__________________
Notable Projects:
Event Item Spawner | Scissors, Rock, Paper for ZephStore
tVip | Smart Link Remover
PLG & GGC - CS:GO Roleplay

and countless more...

I can make a helicopter shoot missles if you want me to...
Totenfluch is offline
BloodJkeee
Member
Join Date: Aug 2015
Old 04-06-2017 , 12:08   Re: [ANY] Smart Link Remover
Reply With Quote #17

my gotv named by the link, which is located in spectors on the server, can you introduce the immunity for the links separated by a comma in the code?
BloodJkeee is offline
Mitchell
~lick~
Join Date: Mar 2010
Old 04-06-2017 , 12:33   Re: [ANY] Smart Link Remover
Reply With Quote #18

Quote:
Originally Posted by BloodJkeee View Post
my gotv named by the link, which is located in spectors on the server, can you introduce the immunity for the links separated by a comma in the code?
So two different things here, I've opened a pullrequest and was merged to solve your issue with GOTV and bots being renamed, also added an immunity flag in.
I will look into adding some kind of URL whitelist also, could be useful if your community has a clan tag that could be considered a URL.
Mitchell is offline
Mitchell
~lick~
Join Date: Mar 2010
Old 04-06-2017 , 22:22   Re: [ANY] Smart Link Remover
Reply With Quote #19

Quote:
Originally Posted by Totenfluch View Post
I planned a mysql database to blacklist certain other phrases directly and a (mysql)whitelist for pages like youtube, twitch (Menu/Command based Ingame)

For Phrases that the regex doesn't catch there will be another database where the admin can target the client and specify the part of the name that is not allowed so the plugin gets it right on the next time.
Although I don't want to completely shutdown this idea, i think a file-based 'simple' config would be a decent addition while others might wait on the sql version.
Mitchell is offline
altair540
Member
Join Date: Dec 2012
Old 04-07-2017 , 01:43   Re: [ANY] Smart Link Remover
Reply With Quote #20

Plugin version 1.5.3
Error log
Quote:
[SM] Exception reported: Cannot replace searches of empty strings
[SM] Blaming: SmartLinkRemover.smx
[SM] Call stack trace:
[SM] [0] ReplaceString
[SM] [1] Line 60, SmartLinkRemover.sp::checkNameURL
[SM] [2] Line 46, SmartLinkRemover.sp::OnClientPostAdminCheck
[SM] Exception reported: Client 11 is not connected
[SM] Blaming: SmartLinkRemover.smx
[SM] Call stack trace:
[SM] [0] SetClientName
[SM] [1] Line 88, SmartLinkRemover.sp::delayedNameChange

Last edited by altair540; 04-07-2017 at 12:13.
altair540 is offline
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 05:20.


Powered by vBulletin®
Copyright ©2000 - 2021, vBulletin Solutions, Inc.
Theme made by Freecode