[Powerlord]

Originally Posted by WildCard65 Actually fiagram, from what I see in sourcemod's PluginSys.cpp, it loads any plugin it can open no matter the extension: CPlugin *CPlugin::CreatePlugin(const char *file, char *error, size_t maxlength) { char fullpath[PLATFORM_MAX_PATH]; g_SourceMod.BuildPath(Path_SM, fullpath, sizeof(fullpath), "plugins/%s", file); FILE *fp = fopen(fullpath, "rb"); CPlugin *pPlugin = new CPlugin(file); if (!fp) { if (error) { UTIL_Format(error, maxlength, "Unable to open file"); } pPlugin->m_status = Plugin_BadLoad; return pPlugin; } fclose(fp); return pPlugin; }

...that's not the autoload code. If it was, you wouldn't have a const char *file argument.

It's called internally by _LoadPlugin, which is itself called internally by LoadPlugin. LoadPlugin is part of SourceMod IPluginManager interface, located in IPluginSys.h. It's one of the interfaces that Extensions can use. Granted, it's also called when a plugin is autoloaded (because _LoadPlugin is)

If you're looking for the autoload code, you should be looking at SourceModBase::DoGlobalPluginLoads() and the functions it calls for auto-loading plugins (CPluginManager::LoadAll_FirstPass, which calls CPluginManager::LoadPluginsFromDir, which has a

        } else if (dir->IsEntryFile()) {
            const char *name = dir->GetEntryName();
            size_t len = strlen(name);
            if (len >= 4
                && strcmp(&name[len-4], ".smx") == 0)

in it)

Incidentally, I found out just a few minutes ago that the optional/ directory under plugins isn't autoloaded, just like disabled/ isn't.

[WildCard65]

Originally Posted by Powerlord ...that's not the autoload code. If it was, you wouldn't have a const char *file argument. It's called internally by _LoadPlugin, which is itself called internally by LoadPlugin. LoadPlugin is part of SourceMod IPluginManager interface, located in IPluginSys.h. It's one of the interfaces that Extensions can use. Granted, it's also called when a plugin is autoloaded (because _LoadPlugin is) If you're looking for the autoload code, you should be looking at SourceModBase:oGlobalPluginLoads() and the functions it calls for auto-loading plugins (CPluginManager::LoadAll_FirstPass, which calls CPluginManager::LoadPluginsFromDir, which has a } else if (dir->IsEntryFile()) { const char *name = dir->GetEntryName(); size_t len = strlen(name); if (len >= 4 && strcmp(&name[len-4], ".smx") == 0) in it) Incidentally, I found out just a few minutes ago that the optional/ directory under plugins isn't autoloaded, just like disabled/ isn't.

The code I posted is just to show fiagram that sourcemod will still "compile" the plugin no matter if it has .smx or not.

[ddhoward]

He never claimed that Sourcemod cannot open "smx" files with a changed extension. He correctly claimed that Sourcemod will not auto-load these plugins, and that you can manually load them later.

[WildCard65]

@ddhoward, I tried your suggestion of using forwards and it was a total failure D: replacement Edit: Got to work but it won't be useful if sm plugins unload is called on the sub plugins.

[Cookies.net]

Just wondering, why do you need such control of plugins? Is it really too expensive to have them running in the background? Not sure what the impact of many plugins will be as long as they're written in a sensible manner, but I doubt it'd be much.

[WildCard65]

Originally Posted by Cookies.net Just wondering, why do you need such control of plugins? Is it really too expensive to have them running in the background? Not sure what the impact of many plugins will be as long as they're written in a sensible manner, but I doubt it'd be much.

You have no idea how FF2 works with it's subplugins:

PHP Code:

EnableSubPlugins(bool:force=false)
{
    if(areSubPluginsEnabled && !force)
    {
        return;
    }

    areSubPluginsEnabled=true;
    decl String:path[PLATFORM_MAX_PATH], String:filename[PLATFORM_MAX_PATH], String:filename_old[PLATFORM_MAX_PATH];
    BuildPath(Path_SM, path, PLATFORM_MAX_PATH, "plugins/freaks");
    decl FileType:filetype;
    new Handle:directory=OpenDirectory(path);
    while(ReadDirEntry(directory, filename, PLATFORM_MAX_PATH, filetype))
    {
        if(filetype==FileType_File && StrContains(filename, ".smx", false)!=-1)
        {
            Format(filename_old, PLATFORM_MAX_PATH, "%s/%s", path, filename);
            ReplaceString(filename, PLATFORM_MAX_PATH, ".smx", ".ff2", false);
            Format(filename, PLATFORM_MAX_PATH, "%s/%s", path, filename);
            DeleteFile(filename);
            RenameFile(filename, filename_old);
        }
    }

    directory=OpenDirectory(path);
    while(ReadDirEntry(directory, filename, PLATFORM_MAX_PATH, filetype))
    {
        if(filetype==FileType_File && StrContains(filename, ".ff2", false)!=-1)
        {
            ServerCommand("sm plugins load freaks/%s", filename);
        }
    }
}

DisableSubPlugins(bool:force=false)
{
    if(!areSubPluginsEnabled && !force)
    {
        return;
    }

    decl String:path[PLATFORM_MAX_PATH], String:filename[PLATFORM_MAX_PATH];
    BuildPath(Path_SM, path, PLATFORM_MAX_PATH, "plugins/freaks");
    decl FileType:filetype;
    new Handle:directory=OpenDirectory(path);
    while(ReadDirEntry(directory, filename, PLATFORM_MAX_PATH, filetype))
    {
        if(filetype==FileType_File && StrContains(filename, ".ff2", false)!=-1)
        {
            InsertServerCommand("sm plugins unload freaks/%s", filename);
        }
    }
    ServerExecute();
    areSubPluginsEnabled=false;
} 


[Cookies.net]

Originally Posted by WildCard65 You have no idea how FF2 works with it's subplugins:

Weren't you going to rewrite the FF2 base anyway? Why can't you just change how it works, instead of trying to create an exact clone, that might be cleaner in the code (who knows), instead of trying to find a better approach? I'm personally working on an alternative for VSH/FF2 myself which will use a completely different approach, by using the game mode manager I wrote (Gamma, it can be found in the Snippets and Tutorials section as I thought it wouldn't be usable for some time, but it got to a pretty usable state much faster than anticipated).

[WildCard65]

Originally Posted by Cookies.net Weren't you going to rewrite the FF2 base anyway? Why can't you just change how it works, instead of trying to create an exact clone, that might be cleaner in the code, who knows, instead of trying to find a better approach? I'm personally working on an alternative for VSH/FF2 myself which will use a completely different approach, by using the game mode manager I wrote (Gamma, it can be found in the Snippets and Tutorials section as I thought it wouldn't be usable for some time, but it got to a pretty usable state much faster than anticipated).

code I posted is not from the rewrite start me doing.

[Cookies.net]

Originally Posted by WildCard65 code I posted is not from the rewrite start me doing.

Wasn't this extension request for the rewrite? Or was it just in general? No matter what, searching for a more proper solution would be better, instead of relying on loading and unloading plugins.

[WildCard65]

Originally Posted by Cookies.net Wasn't this extension request for the rewrite? Or was it just in general? No matter what, searching for a more proper solution would be better, instead of relying on loading and unloading plugins.

for the rewrite because I want to be able to not have to keep using the commands "sm plugins load" and "sm plugins unload"