[Root_]

tl;dr. according to my stats plugin safest ways would be OnClientPostAdminCheck, because its fired when client is fully authorized with its access. OnClientDisconnect is fired for every client when map changes, however player_disconnect event is fired when player really leaves from server. Tested for long time and it worked fine for me.

[friagram]

Originally Posted by Root_ tl;dr. according to my stats plugin safest ways would be OnClientPostAdminCheck, because its fired when client is fully authorized with its access. OnClientDisconnect is fired for every client when map changes, however player_disconnect event is fired when player really leaves from server. Tested for long time and it worked fine for me.

You should avoid postadmincheck, because by design it will be delayed (often for a long time by other sql plugins) to authh admins with signal admin check. Authorized is all you need for identifying a player, and it usually fires really early. If you are worried about race conditions, like the player disconnecting before authorized fires, the best way is to just set a boolean once the authed query completes. Alternatively, you can store the client's auth string globally and terminate it they disconnect or au fails by setting it to '/0' this way you know your clients/queries will always succeed.

[aexi0n]

So far I think the change to Auth instead of PostAdmin has prevented the bug I was experiencing previously. Here is my SetLevelTag code, the only thing I can see happening when it's not under PostAdmin is that it's requiring to know if I'm an Admin or not for the Generic_Admin tag.

public SetLevelTag(client)
{
	decl String:name[MAX_NAME_LENGTH];
	decl String:tag[15];
	
	CS_GetClientClanTag(client, name, sizeof(name));
	
	if(CheckCommandAccess(client, "sm_flag", ADMFLAG_GENERIC, true))
	{
		Format(tag, sizeof(tag), "[Admin | Lv.%d]", Level[client]);
	}
	else if(CheckCommandAccess(client, "sm_flag", ADMFLAG_CUSTOM2, true))
	{
		Format(tag, sizeof(tag), "★ [Lv.%d]", Level[client]);
	}
	else
	{
		Format(tag, sizeof(tag), "[Lv.%d]", Level[client]);
	}
	
	if (StrContains(name, tag) == -1)
	{
		CS_SetClientClanTag(client, tag);
	}
}

[friagram]

SO call your tag thingy twice, since it requires query + admin. Make a function check that both have completed:
Usually I just bit shift in something like so:
#defing FLAG_QUERY_COMPLETE (1<<0)
#define FLAG_ADMIN_COMPLETE (1<<1)

then do
if(flags & FLAG_QUERY_COMPLETE && flags & FLAG_ADMIN_COMPLETE)
{

}

This way you can safely avoid race conditions without further delaying your queries.
This whole problem can be avoided by simply not using plugins that mess with the admin check. Unfortunately the sourcebans team refuses to do proper flatfile caching, and sql_admins also adds delays...