[Aderic]

I'm trying to get this plugin to send a message to the player after he says the chat trigger. Now the command seems to be firing just fine, but the issue is this... It's firing before the client's chat message is broadcasted to all players. It looks kind of clunky this way.

I'm sure I'm going about this all the wrong way, but what would be the most efficient method of printing text to a client after they say a message?

This is the code I've got:

PHP Code:

#include <sourcemod>

public Plugin:myinfo = 
{
    name = "Chat Test",
    author = "Nobody",
    version = "1.0",
}

public OnPluginStart()
{
    AddCommandListener(Command_Say,    "say");
    AddCommandListener(Command_Say,    "say2");
    AddCommandListener(Command_Say, "say_team");
}

public Action:Command_Say(client, const String:command[], argc){
    new String:text[16];
    new String:cmd[16];
    
    GetCmdArg(0, cmd, sizeof(cmd));
    
    if (GetCmdArg(1, text, sizeof(text)) < 1)
        return Plugin_Continue;
    
    StripQuotes(text);
    
    new bool:suppressMsg;
    
    if (text[0] == '!')
        suppressMsg = false;
    else if (text[0] == '/')
        suppressMsg = true;
    else
        return Plugin_Continue;
        // This is firing before the client's message is sent!
    if (StrEqual(text[1], "ping", false))
    {
        PrintToChat(client, "pong");
    }
    
    if (suppressMsg == true)
        return Plugin_Handled;
    else
        return Plugin_Continue;
} 


Thanks,

Mark.

[Powerlord]

OK, two things going on here:

1. If you're looking for / and ! command, use RegConsoleCmd as it will automatically create those for you with the proper handling.
2. If you want to delay something happening, you'll need timers.

So, I'm thinking something like:

PHP Code:

#include <sourcemod> 

public Plugin:myinfo =  
{ 
    name = "Chat Test", 
    author = "Nobody", 
    version = "1.0", 
} 

public OnPluginStart() 
{
    RegConsoleCmd("ping", Command_Ping);
} 

public Action:Command_Ping(client, args){ 
{
    CreateTimer(0.1, Pong, GetClientUserId(client));
    return Plugin_Handled;
}

public Action:Pong(Handle:timer, any:userid)
{
    new client = GetClientOfUserId(userid);
    if (client > 0)
    {
        PrintToChat(client, "pong");
    }
} 


The reason for the GetClientUserId and GetClientOfUserId is to prevent errors when a client disconnects before the timer fires.

For other kinds of chat commands, SourceMod 1.5 introduced OnClientSayCommand, but I'm not really sure how it works.

[Aderic]

Originally Posted by Powerlord OK, two things going on here: 1. If you're looking for / and ! command, use RegConsoleCmd as it will automatically create those for you with the proper handling. 2. If you want to delay something happening, you'll need timers. So, I'm thinking something like: PHP Code: #include <sourcemod>  public Plugin:myinfo =   {      name = "Chat Test",      author = "Nobody",      version = "1.0",  }  public OnPluginStart()  {     RegConsoleCmd("ping", Command_Ping); }  public Action:Command_Ping(client, args){  {     CreateTimer(0.1, Pong, GetClientUserId(client));     return Plugin_Handled; } public Action:Pong(Handle:timer, any:userid) {     new client = GetClientOfUserId(userid);     if (client > 0)     {         PrintToChat(client, "pong");     } }  The reason for the GetClientUserId and GetClientOfUserId is to prevent errors when a client disconnects before the timer fires. For other kinds of chat commands, SourceMod 1.5 introduced OnClientSayCommand, but I'm not really sure how it works.

Hmm yeah, I thought about timers but figured there'd be a different method. We can hook events Pre/Post. I'm surprised we can't do something like that for listener callbacks. Just tried OnClientSayCommand, it seems to be handled the same as manually adding the listeners. Anything in the listener gets fired before the message is broadcasted. Thanks

Edit: Hmm. I see a OnClientSayCommand_Post in the sourcemod api docs. Gonna look at that

Edit 2: This seems to be doing exactly what I need! I'm so glad you mentioned OnClientSayCommand! If I could give you rep I would!


Edit #9259:

I think there's a bug in the way Sourcemod handles OnClientSayCommand with OnClientSayCommand_Post.

If you return Plugin_Handled on OnClientSayCommand then OnClientSayCommand_Post will receive the full sArgs string.
If you return Plugin_Continue on OnClientSayCommand then OnClientSayCommand_Post will receive the sArgs string minus the end quote.

PHP Code:

public Action:OnClientSayCommand(client, const String:command[], const String:sArgs[]) {
    PrintToServer(String:sArgs);
    return Plugin_Continue;
}

public OnClientSayCommand_Post(client, const String:command[], const String:sArgs[]) {
    PrintToServer(sArgs);
} 


I made a workaround for it.

PHP Code:

public Action:OnClientSayCommand(client, const String:command[], const String:sArgs[]) {
    return Plugin_Continue;
}

public OnClientSayCommand_Post(client, const String:command[], const String:sArgs[]) {
    decl String:msg[16];
    new sArgsSize = strlen(sArgs) - 1;
    
    if (sArgsSize == 0)
        return;
    
    if (sArgs[0] == '"') {
        if (sArgs[sArgsSize] == '"') {
            strcopy(msg, sizeof(msg), sArgs);    // Copy the whole thing.
            StripQuotes(msg);                     // Strip the quotes.
        }
        else {                                     // Copy the portion after the quote.
            strcopy(msg, sizeof(msg), sArgs[1]); // This is unquoted.
        }
    }
    
    PrintToServer(msg);
} 


[xf117]

You can assign \0 to the position where ending quote is. Using strcopy for this kinda redundant.

[Aderic]

Originally Posted by xf117 You can assign \0 to the position where ending quote is. Using strcopy for this kinda redundant.

What will \0 do to it? I still have to strcopy anyways.

[Powerlord]

Originally Posted by Aderic What will \0 do to it? I still have to strcopy anyways.

\0 is the byte that signals the end of a string.

[Aderic]

Originally Posted by Powerlord \0 is the byte that signals the end of a string.

Hmm. That's what I thought it did.

Originally Posted by xf117 You can assign \0 to the position where ending quote is. Using strcopy for this kinda redundant.

The issue is not that the string is missing a null line terminator, it was about either grabbing the string from the position after the opening quote (if the end quote is missing) to get the full unquoted string..

or grabbing the string with both quotes and stripping them.

[xf117]

You don't need strcopy

PHP Code:

new pos = 0; // or any starting position you want
if (str[strlen(str)-1] == '"') {
  str[strlen(str)-1] = '\0';
  pos++;
}

PrintToServer(str[pos]);