[Nextra]

As I said, this is your right as the author and I absolutely won't be mad at you.

It is just a suggestion for improvement and as I'm capable of implementing these things by myself it is perfectly fine with me if you don't add them.

[ConnorMcLeod]

PHP Code:

public hook_say_cmd( id )
{
    if ( get_pcvar_num ( gPluginOn )  == 0 )
    {
        client_print( id, print_chat, "%L", id, "MESSAGE_DISABLED" );
        return PLUGIN_HANDLED;
    } 


This is a major error, it will completly block the chat when cvar is 0, you should either return PLUGIN_CONTINUE, either perform this check after the prefix check.

Also, you should declare :
new name [ 32 ];
new said[ 256 ];
after the prefix check, so those vars won't be created each time a player use chat.

if( !is_user_alive( id ) || get_user_team( id ) == 3 )
-> i think you don't need to check the team here, as a spectator can't be alive ;)

Also, when you send a message to every players, you don't need to loop through them, just use message_begin(MSG_BROADCAST, gMessageSayText), and all connected players will see the msg
As other members have suggested, would be an half plugin to not implement dead/alive/team messages, and IMO an antiflood is a must (and easy to do), but that's up to you to make it or not.
If you implement that, then you will have to loop trhough all players and filter them.

[tuty]

i will edit the plugin.. tanks for sugestions


EDIT:

     PHP Code:
     
                       public hook_say_cmd( id )
{
    if ( get_pcvar_num ( gPluginOn )  == 0 )
    {
        client_print( id, print_chat, "%L", id, "MESSAGE_DISABLED" );
        return PLUGIN_HANDLED;
    }  
                
 
This is a major error, it will completly block the chat when cvar is 0, you should either return PLUGIN_CONTINUE, either perform this check after the prefix check.

Also, you should declare :
    new name [ 32 ];
    new said[ 256 ];
after the prefix check, so those vars won't be created each time a player use chat.

if( !is_user_alive( id ) || get_user_team( id ) == 3 )
-> i think you don't need to check the team here, as a spectator can't be alive ;)

Also, when you send a message to every players, you don't need to loop through them, just use message_begin(MSG_BROADCAST, gMessageSayText), and all connected players will see the msg
As other members have suggested, would be an half plugin to not implement dead/alive/team messages, and IMO an antiflood is a must (and easy to do), but that's up to you to make it or not.
If you implement that, then you will have to loop trhough all players and filter them.

1. with MSG_BROADCAST it show double message....
2. This is a major error, it will completly block the chat when cvar is 0, you should either return PLUGIN_CONTINUE : wrong, it only block that message with /POST prefix.... the simple message without post prefix is not blocked!
3. if( !is_user_alive( id ) || get_user_team( id ) == 3 ) : yeah but if is spec it show the money message on spec
4. Also, you should declare new name [ 32 ], new said[ 256 ]; after the prefix check, so those vars won't be created each time a player use chat. (done)

Note:
I want to show messages, but if plugin is disabled or money is not enough, i want to block that message with /POST prefix..

EX: If is plugin disabled or i dont have enough money, i want to show to player that message and block the message with /POST prefix
I dont want to show If is plugin disabled or i dont have enough money something like that
:

You dont have .. sorry...
<name>:/POST ddd

just only

You dont have .. sorry...
(and block that message)

[anakin_cstrike]

You're flooding with those '^^'

[tuty]

Originally Posted by anakin_cstrike You're flooding with those '^^'

grrr........

[ConnorMcLeod]

Originally Posted by tuty 1. with MSG_BROADCAST it show double message....

Bacause you loop trhough all players, just send the message once, see example :

PHP Code:

       else
     {
     /*        for(new i = 1; i <= gMaxPlayers; i++)
              {

                 if(!is_user_connected(i))
                        continue;*/
                
                 message_begin(MSG_BROADCAST, gMessageSayText);
                 write_byte(id);
                 write_string(Buffer);
                 message_end();
         //    }
        } 


Originally Posted by tuty 2. This is a major error, it will completly block the chat when cvar is 0, you should either return PLUGIN_CONTINUE, either perform this check after the prefix check. : wrong, it only block that message with /POST prefix.... the simple message without post prefix is not blocked!

Because now you perform the prefix check in first, it wasn't the case previously, that's why i suggested you to perform it first ^^

Originally Posted by tuty 3. if( !is_user_alive( id ) || get_user_team( id ) == 3 ) : yeah but if is spec it show the money message on spec

Just perfom the "alive check" before the "money check" ^^

[tuty]

got it ... now updating.. thx

[tuty]

UPDATED a bit... used cstrike module ^^

[anakin_cstrike]

PHP Code:

new money = cs_get_user_money(id);
    if(money < get_pcvar_num(gMessageCost))
    {
        client_print(id, print_chat, "%L", id, "DONT_HAVE_MONEY");
        return PLUGIN_HANDLED;
    }
    color_print(0, "^x01[%s]^x04 [ %s ]: [ %s ]", (get_user_team(id) == 1) ? "T" : "CT" , name, said);
    cs_set_user_money(id, money - get_pcvar_num(gMessageCost)); 


You can optimizate this creating a variable instead of geting cvar value twice.
Something lke this

PHP Code:

new cost = get_pcvar_num(gMessageCost);
if(money < cost )
// ...
cs_set_user_money(id, money - cost); 


EDIT:

if(!equal(check_prefix, "/POST", 5)) return PLUGIN_CONTINUE;

Change to 'equali' so people can write with tiny letters.

if(get_pcvar_num(gPluginOn) == 0)

Can be

PHP Code:

if( !get_pcvar_num(gPluginOn)) 


I haven't used 'replace' function very often, but i think this should be:

PHP Code:

replace(said, 255, "/POST ", "");
// ->
replace(said, 255, check_prefix, ""); 


because you checked if 'check_prefiix' is equal to "/POST".

It will be better if you don't put this part:

if(!is_user_alive(id)) { client_print(id, print_chat, "%L", id, "NOT_ALIVE"); return PLUGIN_HANDLED; }

PS: look what connor said

[tuty]

Originally Posted by anakin_cstrike PHP Code: new money = cs_get_user_money(id);     if(money < get_pcvar_num(gMessageCost))     {         client_print(id, print_chat, "%L", id, "DONT_HAVE_MONEY");         return PLUGIN_HANDLED;     }     color_print(0, "^x01[%s]^x04 [ %s ]: [ %s ]", (get_user_team(id) == 1) ? "T" : "CT" , name, said);     cs_set_user_money(id, money - get_pcvar_num(gMessageCost));  You can optimizate this creating a variable instead of geting cvar value twice. Something lke this PHP Code: new cost = get_pcvar_num(gMessageCost); if(money < cost ) // ... cs_set_user_money(id, money - cost);  EDIT: Change to 'equali' so people can write with tiny letters. Can be PHP Code: if( !get_pcvar_num(gPluginOn))  I haven't used 'replace' function very often, but i think this should be: PHP Code: replace(said, 255, "/POST ", ""); // -> replace(said, 255, check_prefix, "");  because you checked if 'check_prefiix' is equal to "/POST". It will be better if you don't put this part: PS: look what connor said

Thanks for suggestions but i dont want to write a post message death players ^^.
And i dont want to use equali.. just equal ;) i want to write with big letters..