[StormishJustice]

Since this is possible, the weapons are now visible in TF2Items so that can be something interesting!

For some reason i dunno how it will work with custom weapons i mean weapons with custom models.

i dunno but i think this fixes the most of the plugins.
do you guys think this is a good idea to grab customized weapons from gamemodes like mann vs tank and other gamemodes that support TF2Items?

[Oshizu]

From what i can tell ya weapons given from TF2Items natives are not visible even after update.

Also let's not forget about golden rule to not discuss visible items

[Potato Uno]

Someone said it is visible. You give the invisible weapon to the player, player dies, another player picks it up, what was invisible weapon is now visible.

That being said, I think Valve will likely nerf this feature in the next update; it's most likely something overlooked (like all the broken mvm bugs).

[Powerlord]

Originally Posted by Oshizu From what i can tell ya weapons given from TF2Items natives are not visible even after update. Also let's not forget about golden rule to not discuss visible items

Lets be honest, this restriction was always about hats and not weapons.

Besides which, if Valve themselves had made them visible, that makes it fair game.

Right now, part of the reason that they're invisible is because we don't have the item ID fields filled in in the CEconItemView object... and have no way of seeing into players inventories to see which items they actually have.

So, even if a player HAS an item, we can't force them to equip theirs, which would make it visible.

One could argue that TF2Items should have the ability to set Item IDs in the case that a plugin has a way of looking them up (via the Steam API if their backpack is public). Which would make said item visible if the item ID is valid.

Edit: On a side note, we could also ask Asherkin to add a thing for CTFDroppedWeapon::Create, which takes a CTFPlayer*, Vector, QAngle, char*, and CEconItemView* and generates a weapon from it. The char* is presumably the weapon class and the Vector the player's position in the world when they died.

Or even CTFDroppedWeapon::SetItem(CEconItemView const*) which presumably creates a CTFDroppedWeapon directly, although it'd still need to be spawned.

[asherkin]

Originally Posted by Powerlord One could argue that TF2Items should have the ability to set Item IDs in the case that a plugin has a way of looking them up (via the Steam API if their backpack is public). Which would make said item visible if the item ID is valid.

As I must've said 50 times by now (probably a few of them to you), only equipped items are networked to clients, which gimps this considerably - even if you could look up a valid itemid from another source, the clients wouldn't have it so it wouldn't be made visible.

However, it does sound like we could now fake all items as being dropped ones bypassing those checks completely if that is currently working with manually-created weapons (why it doesn't check the item is valid in the original owner's inventory I do not know, and that sounds like a trivially easy fix for Valve to make). Who knows if that is actually a good idea however.

[Potato Uno]

Valve will likely fix it. Just wait for someone to make a plugin that gives everyone golden frying pans and it will be nerfed.

Like asherkin said, it sounds pretty trivially easy for valve to fix. They just need to network the account ID with the weapon and make the clients ask the item server if the account owns said weapon, given the definition index and the quality. (But if they did do that, then Powerlord's suggestion of redirecting account ID should also work with manually given weapons.)

Maybe I should email Valve about this bug then. I would be pretty happy if this is exactly what they did, because then weapons we give to clients that they own legitimately in their backpack would also be rendered visible, which sounds fair game to me. (Not fair that my force a nature is invisible even though I own one.)

[pheadxdll]

Originally Posted by Powerlord The char* is presumably the weapon class and the Vector the player's position in the world when they died.

It's actually the model path of the dropped weapon.

Valve seems to have made it trivially easy to do with this update. I'm not sure if we should discuss it here as the same method can be done on wearables like hats as well.

Lets be honest, this restriction was always about hats and not weapons.

They also made stock weapons invisible with gun mettle. With the introduction of skins and unusual effects, I don't think we can assume that anymore.

[Powerlord]

Originally Posted by pheadxdll It's actually the model path of the dropped weapon. Valve seems to have made it trivially easy to do with this update. I'm not sure if we should discuss it here as the same method can be done on wearables like hats as well.

Yeah, I derped. The weapon classname is part of the CEconItemView.

Originally Posted by pheadxdll They also made stock weapons invisible with gun mettle. With the introduction of skins and unusual effects, I don't think we can assume that anymore.

Really? That's kind of... dumb actually.

[asherkin]

Originally Posted by Powerlord The weapon classname is part of the CEconItemView.

It is not.

[StormishJustice]

Originally Posted by pheadxdll They also made stock weapons invisible with gun mettle. With the introduction of skins and unusual effects, I don't think we can assume that anymore.

Wait, did they actually made stock weapons invisible? i tried giving myself a weapon before the update comes and the stock weapon is visible, need to know why they did so?