[Sarabveer]

I need help putting Updater into my plugin. I have followed the directions correctly, but when I compile, I get this error.

donormenu.sp
donormenu.sp(76) : error 017: undefined symbol "updater"
donormenu.sp(78) : error 035: argument type mismatch (argument 1)

2 Errors.

Compilation Time: 0.27 sec
 ----------------------------------------

This is the code for my plugin: http://pastebin.com/77MrcxLj

Updater.txt

"Updater"
{
	"Information"
	{
		"Version"
		{
			"Latest"	"1.2"
		}
		
		"Notes"	"More info @ www.github.com Changes in 1.1:"
		"Notes"	"Added Updater Support"
	}
	
	"Files"
	{
		"Plugin"	"https://raw.githubusercontent.com/Sarabveer/SM-DonorMenu/master/addons/sourcemod/plugins/donormenu.smx"
		"Plugin"	"https://raw.githubusercontent.com/Sarabveer/SM-DonorMenu/master/addons/sourcemod/translations/donormenu.phrases.txt"

		"Source"	"https://raw.githubusercontent.com/Sarabveer/SM-DonorMenu/master/addons/sourcemod/scripting/donormenu.sp"
	}
}

[GoD-Tony]

Originally Posted by Sarabveer I need help putting Updater into my plugin. I have followed the directions correctly, but when I compile, I get this error. donormenu.sp donormenu.sp(76) : error 017: undefined symbol "updater" donormenu.sp(78) : error 035: argument type mismatch (argument 1) 2 Errors. Compilation Time: 0.27 sec ---------------------------------------- This is the code for my plugin: http://pastebin.com/77MrcxLj

You have to change the name of your DonorMenu.name variable. It's conflicting with the OnLibraryAdded forward.

[Sarabveer]

Originally Posted by GoD-Tony You have to change the name of your DonorMenu.name variable. It's conflicting with the OnLibraryAdded forward.

So I would replace "DonorMenu" with something else, like "dmenu"

[GoD-Tony]

Originally Posted by Sarabveer So I would replace "DonorMenu" with something else, like "dmenu"

Only the "String:name[32]" part needs a new name.

[Sarabveer]

Originally Posted by GoD-Tony Only the "String:name[32]" part needs a new name.

Sorry, I'm a n00b at this, but cant change that, I think.

[TnTSCS]

PHP Code:

enum DonorMenu {
        String:name[32],// <-- change this to dname[32] or something
        String:title[128],
        DonorMenuType:type,
        Handle:items,
        itemct
} 


Also, I think, could be wrong, you need to change hmenu[name] to hmenu[dname], lines 127 and 192 of the pastebin you linked

[asherkin]

Having unprefixed enums is just asking for a world of hurt.

[Sarabveer]

Originally Posted by TnTSCS PHP Code: enum DonorMenu {         String:name[32],// <-- change this to dname[32] or something         String:title[128],         DonorMenuType:type,         Handle:items,         itemct }  Also, I think, could be wrong, you need to change hmenu[name] to hmenu[dname], lines 127 and 192 of the pastebin you linked

Thanks, it Compiled.

https://github.com/Sarabveer/SM-Dono...9cd12291a62ead

https://travis-ci.org/Sarabveer/SM-D...uilds/38741332

[ddhoward]

Are there any plans or tentative thoughts on allowing what plugins are allowed to be Updated to be configured from a cfg file?

I was thinking something like this:

PHP Code:

"Updater"
{
    "someplugin.smx"
    {
        "plugin" "allow" //download the stuff marked "Plugin" in the updater txt file
        "source" "deny"  //but don't download the "source" files
    }
    "someOtherplugin.smx"
    {
        "plugin" "deny" //don't ever download updates for someOtherplugin.smx, but put a notification in the log file
    }
    "randomAssThirdPlugin.smx"
    {
        "url" "http://example.com/sourcemod/randomAssThirdPlugin.txt"
        //perhaps we could even allow updating of plugins that don't have updater.inc in them at all
    }
    "babysFirstPlugin.smx"
    {
        "check" "deny" //don't even check for updates for this plugin
    }
} 


Just throwing around ideas.

[yusufali]

actually, being able to update plugins without updater will be more or less useful

I dont know how feasible that task is, but yea it would be very usefull. How i wish more people used updater in their plugins