[ConnorMcLeod]

Originally Posted by xPaw You dont need to use globals for g_msg*, only for scoreinfo MSG_ALL -> MSG_BROADCAST ?

You just don't need to send any message, just alter params of the resend-by-amxx-due-to-register_message one.

[xPaw]

Originally Posted by ConnorMcLeod You just don't need to send any message, just alter params of the resend-by-amxx-due-to-register_message one.

Well HP can change, but if you will only change it in message ScoreInfo by setting args, it wont be so correct.

[ConnorMcLeod]

Ah exact, but there is no need to hook Health message pre, register_event should be enough, same for armorvalue.

[xPaw]

Maybe laik that ?

PHP Code:

#include <amxmodx>

new bool:g_bConnected[ 33 ];
new g_iMsgScoreInfo, g_iMaxPlayers;

public plugin_init( ) {
    register_plugin( "HP AP @ SB", "1.0", "Alucard" );
    
    // Battery will work better instead of ArmorType ?
    
    register_event( "Health", "EventChange", "be" );
    register_event( "Battery", "EventChange", "be" );
    
    register_message( ( g_iMsgScoreInfo = get_user_msgid( "ScoreInfo" ) ), "MessageScoreInfo" );
    
    g_iMaxPlayers = get_maxplayers( );
}

public client_putinserver( id )
    g_bConnected[ id ] = true;

public client_disconnect( id )
    g_bConnected[ id ] = false;

public MessageScoreInfo( const MsgId, const MsgType, const MsgDest ) {
    new id = get_msg_arg_int( 1 );
    new bool:bAlive = bool:( is_user_alive( id ) );
    
    set_msg_arg_int( 2, ARG_SHORT, bAlive ? get_user_health( id ) : 0 );
    set_msg_arg_int( 3, ARG_SHORT, bAlive ? get_user_armor( id ) : 0 );
}

public EventChange( ) {
    static id, bool:bAlive = false;
    
    for( id = 1; id <= g_iMaxPlayers; id++ ) {
        if( !g_bConnected[ id ] )
            continue;
        
        bAlive = bool:( is_user_alive( id ) );
        
        message_begin( MSG_BROADCAST, g_iMsgScoreInfo );
        write_byte ( id );
        write_short( bAlive ? get_user_health( id ) : 0 );
        write_short( bAlive ? get_user_armor( id ) : 0 );
        write_short( 0 );
        write_short( get_user_team( id ) );
        message_end( );
    }
} 


[ConnorMcLeod]

xPaw why do you send MSG_BROADCAST in the loop ? Once is enough.

PHP Code:

////////////////////////////////////////
//                                    //
//    Credits:              //
//  tostly, joropito, L//, Starsailor //
//                                    //
////////////////////////////////////////

#include <amxmodx>

#define PLUGIN    "New Plugin"
#define AUTHOR    "Alucard"
#define VERSION    "1.2"

enum _:ScoreInfo_Args {
    PlayerID = 1,
    Frags,
    Deaths,
    ClassID,
    TeamID
}

new g_msgScoreInfo
new g_MaxPlayers
new p_MsgOn, p_MsgDelay

public plugin_init()
{
    register_plugin(PLUGIN, VERSION, AUTHOR)
    register_cvar("health_armor_scoreboard", VERSION,FCVAR_SERVER|FCVAR_SPONLY)
    
    p_MsgOn = register_cvar("has_msg_on", "1")
    p_MsgDelay = register_cvar("has_msg_delay", "180.0")

    g_msgScoreInfo = get_user_msgid("ScoreInfo")
    register_message(g_msgScoreInfo, "Message_ScoreInfo")

    register_event("Battery", "Event_Battery", "b")
    register_event("Health", "Event_Health", "b")
    
    g_MaxPlayers = get_maxplayers()
    
    set_task(get_pcvar_float(p_MsgDelay), "MsgToPlayers", .flags="b")
}

/*Name:      ScoreInfo
Structure:     
byte     PlayerID
short     Frags
short     Deaths
short     ClassID?
short     TeamID */
public Message_ScoreInfo(iMsgId, iMsgType, iMsgEnt)
{
    new id = get_msg_arg_int(PlayerID)

    set_msg_arg_int(Frags, ARG_SHORT, get_user_health(id))
    set_msg_arg_int(Deaths, ARG_SHORT, get_user_armor(id))
}

Send_ScoreInfo(id, iFrags, iDeaths, iTeamID)
{
    message_begin(MSG_BROADCAST, g_msgScoreInfo)
    write_byte(id)  
    write_short(iFrags) 
    write_short(iDeaths) 
    write_short(0) 
    write_short(iTeamID) 
    message_end()
}

/*Name:      Battery
Structure:     
short     Armor */
public Event_Battery( id )
{
    Send_ScoreInfo(id, get_user_health(id), read_data(1), get_user_team(id))
}

/*Name:      Health
Structure:     
byte     Health*/
public Event_Health( id )
{
    Send_ScoreInfo(id, read_data(1), get_user_armor(id), get_user_team(id))
}

public MsgToPlayers()
{
    if(get_pcvar_num(p_MsgOn) )
    {
        client_print(0, print_chat, "[H & A] In this server Frags & Deaths are replaced with Health & Armor in the Scoreboard.")
    }
} 


[xPaw]

I was lazy to think and blabla

[Alucard^]

Version 1.2 In v1.1 sometimes the update of the hp & ap doesn't work correctyle, now work perfect (thx connor) Code optimization (thx connor) Added support when player die, 0 hp & 0 ap. Added colors to the boring adv message. Ofcourse added Connor in the credits.

Thx.

[xPaw]

PHP Code:

get_user_msgid("SayText") 


Store in global variable.

[Hawk552]

You should change this:

PHP Code:

get_players(players, count, "ch") 


get_players() doesn't work well with flags. Also, the included is_user_connected() check is unnecessary.

Also make the changes suggested by previous posters.

There are a few mistakes and optimizations that can be made, however it is acceptable.

If you would like any information regarding possible adjustments you could make or things you could do to make this better, please feel free to post here or PM me.

Approved.

[Alucard^]

Thx Hawk, updated:

Version 1.3 get_user_msgid("SayText")stored in a global variable. deleted "connected" check in chat_color stock.

I didn't change nothing about get_players.... cuz i have some doubts... i know that get_players have some problems with flags but as far as i know.. the problem is with the "e" flag...

http://forums.alliedmods.net/showpos...72&postcount=7