[SnoW]

Originally Posted by ConnorMcLeod You should float read_data value

I don't see a reason for that. Maybe it would bring a bit of readability but it's just a style issue.

[Rul4]

Originally Posted by ConnorMcLeod g_flashed_until[id] = read_data(2)/4096.0 + get_gametime(); You should float read_data value Also i think you could use instead : g_flashed_until[id] = get_pdata_float(id, 514, 5) Just make some comparison of bith values Those following offsets were founded by VEN, and arkshine recently confirm, after having decompiled the .dll that it seems to be right. 514 - fGametime flashed until ? 515 - fGametime flashed at ? 516 - fHoldTimeInSeconds of ScreenFade 517 - fDurationInSeconds of ScreenFade 518 - iAlpha of ScreenFade

That could be another way of doing it. But I can think of 2 reasons not to:
a) It already works, why changing it?
b) Other plugins send the ScreenFade msg. I am not sure how they will interact with those offsets. I am sure hooking the ScreenFade msg will keep working.

Originally Posted by ConnorMcLeod Last, you should cache maximum of things that are checked in addtofulpack such as bot, alive, plugin on/off so you can save some native calls.

I agree. That could add the potential problem of caching something that changes (e.g.: I am not sure if ent IDs are kept when the map changes) but it is worth a try.

[ConnorMcLeod]

1. Use the offset when the ScreenFade event is triggered.

2. Cache if an id is a bot at players connection for exemple.
Check first if player == 1 will prevent to check the cvar and such many times,
etc..., just need to think a bit.

[ditmesteam]

Some peope play in my server often say " why does not he get blinded when I throw flashed bang, he may use cheat"
Now this plugin can prevent no flash cheat
Can you make one option cvar: do not flash team mate if friendly mode is off

[Rul4]

Originally Posted by ConnorMcLeod 1. Use the offset when the ScreenFade event is triggered.

Again: why? What is the advantage of using this over getting the HoldTime?

[Rul4]

I just posted a new version caching the values Connor suggested.

About the no-flash var for teammates: there are other plugins already doing that. The purpose of this one is just anti-cheating.

[ConnorMcLeod]

You get it faster.

[Seta00]

Tested with ECC 5.2 and it works. Nice job.
The blind time could be bigger, though, cause the player goes visible as soon as the flash starts to fade out, and normal players can't see in this moment.

[lazarev]

PHP Code:

if (!get_pcvar_num(pcv_on))
    return FMRES_IGNORED;

if (!g_isAlive[host])
    return FMRES_IGNORED;

if (g_isBot[host])
    return FMRES_IGNORED;

if (!player)
    return FMRES_IGNORED; 


PHP Code:

if( !get_pcvar_num(pcv_on) || !g_isAlive[host] || g_isBot[host] || !player )
    return FMRES_IGNORED; 


[Nextra]

Good idea and a nice plugin, well done!

For the caching stuff, here are some things you could improve even further:

- Checking the cvar in every AddToFullPack will add up to thousands of calls every second. I'd suggest to unregister the forward completely if the plugin is disabled and do the required cvar check at the beginning of a round. To overcome the minor inconvenience of not being able to change the plugin state mid-round (which should not be any hassle, who would want to disable a anti-cheat plugin anyway) you could introduce an admin command that hooks the forward again.
- Check the player var before the other two. It should be better to access the non-array stuff first.
- ent != host and g_isAlive[ent] could be placed, like the other 3 checks, before get_gametime. ent != host should go in front of the array stuff aswell.