[LordDeath]

Well, I have an entity index which I remove with remove_entity native. everything goes fine till I try to remove it the next round using checks (which shouldn't crash the server), but the if condition path somehow and then the server crashes.
Ex:

public basic_entity(id)
{
new Entity = create_entity("info_target");
Entity settings code (Model, Owner, Origin,etc...)
myEnt[id] = Entity
}

now, let's say I kill the entity and it goes fine

if(myEnt[id] && is_valid_ent(myEnt[id]))
remove_entity(myEnt[id])

it gets removed normally and it goes fine, then I kill it again while it's not there using the same code

if(myEnt[id] && is_valid_ent(myEnt[id]))
remove_entity(myEnt[id])

The server crashes, as if the entity is in the world (if condintion passes while it shouldn't).
even keeping the native alone, the server still crashes and the code gets excuted regardless of the check

if(is_valid_ent(myEnt[id]))
remove_entity(myEnt[id])

the IF condiontions shouldn't pass since the entity isn't there, but still, it passes and the code native gets executed and crashes the server. any solution?

[simanovich]

Because is_vaild_ent returns true if the entity index is valid (aka 0<entindex<maxEntities), and doesn't check if the entity does actually exists in the game.


Use pev_vaild.

[Natsheh]

Originally Posted by simanovich Because is_vaild_ent returns true if the entity index is valid (aka 0<entindex<maxEntities), and doesn't check if the entity does actually exists in the game. Use pev_vaild.

That's kind correct.

Make sure to reset the variable to 0 once you remove it.

Give the entity the flag FL_KILLME ( set_pev(ent, pev_flags, FL_KILLME) ) TO Safely remove it.

Also it really depends a lot when and how are you removing it but I suggest to give it the flag killme for safety remove.

[LordDeath]

Thank you guys,
Solved

[meTaLiCroSS]

Originally Posted by simanovich Because is_vaild_ent returns true if the entity index is valid (aka 0<entindex<maxEntities), and doesn't check if the entity does actually exists in the game. Use pev_vaild.

Take a look next time

PHP Code:

int is_ent_valid(int iEnt)
{
    if (iEnt < 1 || iEnt > gpGlobals->maxEntities) 
        return 0;

    if (iEnt <= gpGlobals->maxClients)
    {
        if (!MF_IsPlayerIngame(iEnt))
        {
            return 0;
        }
    } else {
        if (FNullEnt(TypeConversion.id_to_edict(iEnt)))
        {
            return 0;
        }
    }

    return 1;
} 


PHP Code:

        edict_t* id_to_edict(int index)
        {
            if (index < 0 || index >= gpGlobals->maxEntities)
            {
                return nullptr;
            }

            if (!index)
            {
                return m_FirstEdict;
            }

            auto pEdict = static_cast<edict_t*>(m_FirstEdict + index);

            if (pEdict && (pEdict->free || (index > gpGlobals->maxClients && !pEdict->pvPrivateData)))
            {
                return nullptr;
            }

            return pEdict;
        } 


It's more than a dumb check. It is correctly asking if is not freed, also validating its private data pointer. remove_entity calls ED_Free, which immediately frees the memory and sets the corresponding flags.

At this point, the statement (is_valid_ent(entityindex)) == (pev_valid(entityindex) == 2) is always true when entityindex is not a player.