[6Yukimuro9]

Hello, I'm creating VIP plugin from scratch and its like 90% done by now so I' m doing optimisation...

I'm wondering what is better way of doing this:

public print_online_vips(id)
{
	new vips[100], vips2[100], iPlayers[32], iPlayersNum, i;
	
	get_players(iPlayers, iPlayersNum, "c");
	for(i = 0; i < iPlayersNum; ++i)
	{
		if(get_user_flags(iPlayers[i]) & VIP_LEVEL)
		{
			new name[MAX_NAME_LENGTH];
			get_user_name(iPlayers[i], name, sizeof(name));
			
			
			if(strlen(vips) < 100)
				format(vips, sizeof(vips), "%s%s%s", vips, name, !vips[0] ? "" : ", ");
			else
				format(vips2, sizeof(vips2), "%s, %s", vips2, name);
		}
	}
	
	if(!vips[0])
		client_print_color(id, id, "^4[VIP]^1 %L", id, "NO_VIP_ONLINE");
		
	else
		client_print_color(id, id, "^4VIP Online:^3 %s^4%s", vips, vips2[0] ? "," : ".");
		
	if(vips2[0])
		client_print_color(id, id, "^3 %s^4.", vips2);
		
	return PLUGIN_HANDLED;
}

[SHIELD755]

Use cromchat

[redivcram]

Originally Posted by SHIELD755 Use cromchat

Beat me to it...

[6Yukimuro9]

Originally Posted by SHIELD755 Use cromchat

Why would I do that?

This doesn't have any bugs and its better & faster

[OciXCrom]

Your code is limited to only 2 arrays of vips. With 32 VIPs online, it won't print all of them.

PHP Code:

public print_online_vips(id)
{
    static const iMax = 4
    new szVips[160], iPlayers[MAX_PLAYERS], iPnum, iCountAll
    get_players(iPlayers, iPnum, "ch")

    szVips = "^4VIPs Online: ^3"

    for(new i, iCount, iPlayer; i < iPnum; i++)
    {
        iPlayer = iPlayers[i]

        if(get_user_flags(iPlayer) & VIP_LEVEL)
        {
            iCountAll++

            if(iCount++ < iMax)
            {
                add(szVips, charsmax(szVips), fmt("%n", iPlayer))

                if(i < iPnum - 1)
                {
                    add(szVips, charsmax(szVips), "^4, ^3")
                }
            }
            else
            {
                iCount = 0
                client_print_color(id, id, szVips)
                szVips[0] = EOS
            }
        }
    }

    if(iCountAll)
    {
        client_print_color(id, id, szVips)
    }
    else
    {
        client_print_color(id, id, "^4%l", "NO_VIP_ONLINE")
    }

    return PLUGIN_HANDLED
} 


iMax is the maximum number of players that will get printed on each line.

[HamletEagle]

Originally Posted by OciXCrom Your code is limited to only 2 arrays of vips. With 32 VIPs online, it won't print all of them. PHP Code: public print_online_vips(id) {     static const iMax = 4     new szVips[160], iPlayers[MAX_PLAYERS], iPnum, iCount, iCountAll, i     get_players(iPlayers, iPnum, "ch")     @new_string:     szVips = "^4VIPs Online: ^3"     for(new iPlayer; i < iPnum; i++)     {         iPlayer = iPlayers[i]         if(get_user_flags(iPlayer) & VIP_LEVEL)         {             iCountAll++             if(iCount++ < iMax)             {                 add(szVips, charsmax(szVips), fmt("%n", iPlayer))                 if(i < iPnum - 1)                 {                     add(szVips, charsmax(szVips), "^4, ^3")                 }             }             else             {                 iCount = 0                 client_print_color(id, id, szVips)                 goto @new_string             }         }     }     if(iCountAll)     {         client_print_color(id, id, szVips)     }     else     {         client_print_color(id, id, "^4%l", "NO_VIP_ONLINE")     }     return PLUGIN_HANDLED }  iMax is the maximum number of players that will get printed on each line.

goto and jumping backwards

[OciXCrom]

I guess we can skip that part. I edited the code.