[szogun]

PHP Code:

#include <sourcemod>
#include <cstrike>
#include <sdktools>
 
new Handle: Team
 
public OnPluginStart( ) {
    Team = CreateConVar( "sm_join_team", "1", "Do not edit this" )
    AddCommandListener(CmdListener_Changeteam, "jointeam");
    AddCommandListener(CmdListener_Changeteam, "changeteam");
    HookEvent( "player_connect_full", Event_OnFullConnect, EventHookMode_Post )
}
 
public Event_OnFullConnect( Handle:event, const String:name[ ], bool:dontBroadcast ) {
    new client = GetClientOfUserId( GetEventInt( event, "userid" ) )
   
    if( client != 0 && IsClientInGame( client ) && !IsFakeClient( client ) && !bIsAdminRoot(client)) {
        CreateTimer( 0.5, AssignTeam, client )
    }
}
 
public Action: AssignTeam( Handle: timer, any: client ) {
    if( IsClientInGame( client ) ) {
        int iCvar = GetConVarInt( Team )
       
        switch( iCvar ) {
            case 0 : {
                return Plugin_Handled
            }
            case 1 : {
                new iRed, iBlue;
                for(new i = 1; i <= MaxClients; i++)
                {
                    if(!IsClientInGame(i))
                        continue;
 
                    new iTeam = GetClientTeam(i);
                    if(iTeam == CS_TEAM_T)
                        iRed++;
                    else if(iTeam == CS_TEAM_CT)
                        iBlue++;
                }
                if( iRed > iBlue )
                {
                    ChangeClientTeam( client, 3 )
                }
                else
                if( iRed < iBlue )
                {
                    ChangeClientTeam( client, 2 )
                }
                else
                if( iRed == iBlue )
                {
                    ChangeClientTeam( client, 2 )
                }
                CS_RespawnPlayer(client);
                           
            }
           
            case 2 : {
                ChangeClientTeam( client, 2 )
            }
           
            case 3 : {
                ChangeClientTeam( client, 3 )
            }
        }
    }
 
    return Plugin_Continue
}
public Action CmdListener_Changeteam(int client, const char[] command, int args)
{
    if(bIsAdminRoot(client))
        return Plugin_Continue;
    
    if(client > 0 && IsClientInGame(client) && GetClientTeam(client) > 0 && !IsFakeClient(client))
        return Plugin_Handled;
}
 
bool bIsAdminRoot(int client)
{
    if(GetUserFlagBits(client) & ADMFLAG_ROOT | ADMFLAG_GENERIC) 
        return true;
    return false;

    } 


Where did I make a mistake?

warning 209: function "CmdListener_Changeteam" should retur
n a value

[pride95]

PHP Code:


public Action CmdListener_Changeteam(int client, const char[] command, int args) 
{ 
    if(bIsAdminRoot(client)) 
        return Plugin_Continue; 
     
    if(client > 0 && IsClientInGame(client) && GetClientTeam(client) > 0 && !IsFakeClient(client)) 
        return Plugin_Handled;

    return Plugin_Handled;
} 


you return a value in if, but the function doesn't return a value if the both if are false.

[szogun]

I did it this way
Only now does not block the team change

PHP Code:

public Action CmdListener_Changeteam(int client, const char[] command, int args)
{
    if(bIsAdminRoot(client))
        return Plugin_Continue;
    
    if(client > 0 && IsClientInGame(client) && GetClientTeam(client) > 0 && !IsFakeClient(client))
        return Plugin_Handled; 
    return Plugin_Handled; 
} 


[pride95]

Originally Posted by szogun PHP Code: public Action CmdListener_Changeteam(int client, const char[] command, int args) {     if(bIsAdminRoot(client))         return Plugin_Continue;          if(client > 0 && IsClientInGame(client) && GetClientTeam(client) > 0 && !IsFakeClient(client))         return Plugin_Handled;      return Plugin_Continue;  }

return Plugin_Continue;

[szogun]

Unfortunately, the plugin still allows for a change of team

[pride95]

PHP Code:

    if(bIsAdminRoot(client)) 
        return Plugin_Continue; 


maybe this function returns true for all players. or you have root admin and it returns true for you, so you can change your team.

PHP Code:

public Action CmdListener_Changeteam(int client, const char[] command, int args) 
{ 
    if(bIsAdminRoot(client)) 
        return Plugin_Continue; 
     
     return Plugin_Handled;  
} 


an you should use this. that verification of client > 0 etc its useless.

[szogun]

I do not have root on the server I'm testing
I changed what you gave but you can still change the team
It seems to me that the problem must be there

PHP Code:

if(bIsAdminRoot(client)) 
        return Plugin_Continue; 


[pride95]

Originally Posted by szogun I do not have root on the server I'm testing I changed what you gave but you can still change the team It seems to me that the problem must be there PHP Code: if(bIsAdminRoot(client))          return Plugin_Continue;

use

PHP Code:

if(GetAdminFlag(GetUserAdmin(client), Admin_Root)) 


[szogun]

The code given above also works correctly, your method also works.
The problem arises when firing another plugin that triggers conflict.
Thanks for the help