[Hirsw0w]

HPVars
by Hirsw0w

Description:

This Include used for save player variable's without new parameters,
The Idea came from SAMP and this is neccery thing there.
the use is simple and not need to much, the save for Float,Int and string.

Defines:

#define MAX_VARNAME 32 // max var name length
#define MAX_VARINPUT 128 // max var input length
#define MAX_PLAYERS 32 // max players define
#define MAX_VARS 50 // max vars in once

Functions:

Set:
[[SetPVarString(playerid,varname[],varinput[]) // create\set string in player var.
SetPVarInt(playerid,varname[],varinput) // create\set int in player var.
SetPVarFloat(playerid,varname[],Float:varinput) // create\set Float in player var.

Get:
GetPVarString(playerid,varname[]) // get string from player var.
GetPVarInt(playerid,varname[]) // get int from player var.
GetPVarFloat(playerid,varname[]) // get Float from player var.

Others:
[DeletePVar(playerid,varname[]) // delete player var.
DeleteAllPVars(playerid) // delete all player vars
ResetVars() // reset all players vars.

code:

http://pastebin.com/s3EFj57G


I know that really easy to make, but that good,
sorry for my bad english and if you have comments for this i love to hear that.
builed by me.

Enjoy!!!

[YamiKaitou]

MAX_PLAYERS is already defined by default in 1.8.3, so you need to change your define to something else.


What is the point of this include file?

[Hirsw0w]

Originally Posted by YamiKaitou MAX_PLAYERS is already defined by default in 1.8.3, so you need to change your define to something else. What is the point of this include file?

the include is save variable for player like:

SetPVarInt(id,"points",1500);
GetPVarInt(id,"points");

and this save things and you dont need to do:

new Points[32];
and this save place and more comftubale

[YamiKaitou]

What kind of benefit does this include offer? Readability is definitely not one of them.

[Hirsw0w]

Originally Posted by YamiKaitou What kind of benefit does this include offer? Readability is definitely not one of them.

listen I don't know what to say to you, I know that good and this save lines and you don't need to create 1000 parameters...... and this saving you that work..

you can set string like float or int and get float or int like your chose... and you dont need convert string to float and that uppside. that good for some things I sure you find something to use it.

[Emp`]

The amount of memory you occupy by doing:

new nVar[MAX_PLAYERS][MAX_VARS][MAX_VARNAME];
new iVar[MAX_PLAYERS][MAX_VARS][MAX_VARINPUT]

is very expensive. If more than one plugin uses this system, you are now multiplying this memory usage by the number of plugins.

Also, having to look up a string within MAX_VARS before you can get/set a variable, makes these operations expensive too. Converting integers and floats to strings and back makes it even worse. Referencing/setting a variable is very fast in pawn; this system adds extra native calls for these simple operations.

The "ease of use" for "not creating" the variables is greatly outweighed by the extra memory and operations included in this system.

Other suggestions:

The copy native should be used where you are not formatting.

Your set Int/Float only support numbers of lengths 15 and 20 respectively, but it should support MAX_VARINPUT (though you would not need it).

#if defined MAX_PLAYERS
	#undef MAX_PLAYERS
#endif
#define MAX_PLAYERS 32

->

#if !defined MAX_PLAYERS
	#define MAX_PLAYERS 32
#endif

You should not empty strings like this:

nVar[playerid][i] = ""

instead use:

nVar[playerid][i][0] = EOS

Look into Tries:

• https://forums.alliedmods.net/showthread.php?t=88396
• https://forums.alliedmods.net/showthread.php?t=201872

[meTaLiCroSS]

Originally Posted by Hirsw0w the include is save variable for player like: SetPVarInt(id,"points",1500); GetPVarInt(id,"points"); and this save things and you dont need to do: new Points[32]; and this save place and more comftubale

Comfortable? When coding was something "comfortable" for the one who codes? This is just a waste of resources anyway, huge memory waste for just doing a function, which is useless when knowing how to assign a value to a variable easily

[HamletEagle]

@Emp, you mean like this ?

player_vars.inc

#include < celltrie >

enum eData
{
    iInteger,
    Float: fFloat,
    szString[ 256 ]
}

new Trie: g_tPlayerVars 
new g_szKey[ 20 ], g_Data[ eData ]

stock PVar_TrieIinit( )
{
    g_tPlayerVars =  TrieCreate( )  
}

stock PVar_TrieDestroy( )
{
    TrieDestroy( g_tPlayerVars )
}

stock SetPVarString( id, const szInput[ ] ) 
{
    GetKey( id, g_szKey, charsmax( g_szKey ) )
    
    copy( g_Data[ szString ], charsmax( g_Data ), szInput )
    TrieSetArray( g_tPlayerVars, g_szKey, g_Data, sizeof g_Data )
}

stock SetPVarInteger( id, iInput ) 
{
    GetKey( id, g_szKey, charsmax( g_szKey ) )
    g_Data[ iInteger ] = iInput
    TrieSetArray( g_tPlayerVars, g_szKey, g_Data, sizeof g_Data )
}

stock SetPVarFloat( id, Float: fInput ) 
{
    GetKey( id, g_szKey, charsmax( g_szKey ) )
    g_Data[ fFloat ] = _:fInput
    TrieSetArray( g_tPlayerVars, g_szKey, g_Data, sizeof g_Data )
}

stock GetPVarString( id, szOutPut[ ], iSize ) 
{
    GetKey( id, g_szKey, charsmax( g_szKey ) )
    
    if( TrieKeyExists( g_tPlayerVars, g_szKey ) )
    {
        TrieGetArray( g_tPlayerVars, g_szKey, g_Data, sizeof g_Data )
        copy( szOutPut, iSize, g_Data[ szString ] )
    }
}

stock GetPVarInteger( id )
{
    GetKey( id, g_szKey, charsmax( g_szKey ) )
    
    if( TrieKeyExists( g_tPlayerVars, g_szKey ) )
    {
        TrieGetArray( g_tPlayerVars, g_szKey, g_Data, sizeof g_Data )
        return g_Data[ iInteger ]
    }
    
    return 0
}

stock Float: GetPVarFloat( id )
{
    GetKey( id, g_szKey, charsmax( g_szKey ) )
    
    if( TrieKeyExists( g_tPlayerVars, g_szKey ) )
    {
        TrieGetArray( g_tPlayerVars, g_szKey, g_Data, sizeof g_Data )
        return g_Data[ fFloat ]
    }
    
    return 0.0
}

stock DeletePVar( id ) 
{
    GetKey( id, g_szKey, charsmax( g_szKey ) )
    
    if( TrieKeyExists( g_tPlayerVars, g_szKey ) )
    {
        TrieDeleteKey( g_tPlayerVars, g_szKey )
    }
}

stock DeleteAllPVars( ) 
{
    new iPlayers[ 32 ], iNum, id
    get_players( iPlayers, iNum )
    
    for( new i; i < iNum; i++ )
    {
        id = iPlayers[ i ]
        DeletePVar( id )
    }
}

stock GetKey( id, szOutPut[ ], iSize )
{
    num_to_str( id, szOutPut, iSize )
}

I used Trie[g/s]etArray because a trie is not a heterogeneous container, so it can't store both cell & multicell.

[Emp`]

Originally Posted by HamletEagle @Emp, you mean like this ? player_vars.inc #include < celltrie > enum eData {     iInteger,     Float: fFloat,     szString[ 256 ] } new Trie: g_tPlayerVars new g_szKey[ 20 ], g_Data[ eData ] stock PVar_TrieIinit( ) {     g_tPlayerVars =  TrieCreate( )  } stock PVar_TrieDestroy( ) {     TrieDestroy( g_tPlayerVars ) } stock SetPVarString( id, const szInput[ ] ) {     GetKey( id, g_szKey, charsmax( g_szKey ) )         copy( g_Data[ szString ], charsmax( g_Data ), szInput )     TrieSetArray( g_tPlayerVars, g_szKey, g_Data, sizeof g_Data ) } stock SetPVarInteger( id, iInput ) {     GetKey( id, g_szKey, charsmax( g_szKey ) )     g_Data[ iInteger ] = iInput     TrieSetArray( g_tPlayerVars, g_szKey, g_Data, sizeof g_Data ) } stock SetPVarFloat( id, Float: fInput ) {     GetKey( id, g_szKey, charsmax( g_szKey ) )     g_Data[ fFloat ] = _:fInput     TrieSetArray( g_tPlayerVars, g_szKey, g_Data, sizeof g_Data ) } stock GetPVarString( id, szOutPut[ ], iSize ) {     GetKey( id, g_szKey, charsmax( g_szKey ) )         if( TrieKeyExists( g_tPlayerVars, g_szKey ) )     {         TrieGetArray( g_tPlayerVars, g_szKey, g_Data, sizeof g_Data )         copy( szOutPut, iSize, g_Data[ szString ] )     } } stock GetPVarInteger( id ) {     GetKey( id, g_szKey, charsmax( g_szKey ) )         if( TrieKeyExists( g_tPlayerVars, g_szKey ) )     {         TrieGetArray( g_tPlayerVars, g_szKey, g_Data, sizeof g_Data )         return g_Data[ iInteger ]     }         return 0 } stock Float: GetPVarFloat( id ) {     GetKey( id, g_szKey, charsmax( g_szKey ) )         if( TrieKeyExists( g_tPlayerVars, g_szKey ) )     {         TrieGetArray( g_tPlayerVars, g_szKey, g_Data, sizeof g_Data )         return g_Data[ fFloat ]     }         return 0.0 } stock DeletePVar( id ) {     GetKey( id, g_szKey, charsmax( g_szKey ) )         if( TrieKeyExists( g_tPlayerVars, g_szKey ) )     {         TrieDeleteKey( g_tPlayerVars, g_szKey )     } } stock DeleteAllPVars( ) {     new iPlayers[ 32 ], iNum, id     get_players( iPlayers, iNum )         for( new i; i < iNum; i++ )     {         id = iPlayers[ i ]         DeletePVar( id )     } } stock GetKey( id, szOutPut[ ], iSize ) {     num_to_str( id, szOutPut, iSize ) } I used Trie[g/s]etArray because a trie is not a heterogeneous container, so it can't store both cell & multicell.

This is betterbecause it uses Tries, but you also lost the functionality of having custom names associated for the variables, which is what Hirsw0w was advocating. Your system only allows one variable per id number, but you could use incrementing offsets to get different id numbers.

But this is still adding extra native calls for getting/setting a variable. Below is a note from cellarray.inc, but I feel it applies to this too:

/**
 * These arrays are intended to be used for a form of global storage without 
 * requiring a #define that needs to be increased each time a person needs more 
 * storage.
 * These are not designed to be used as a replacement for normal arrays, as
 * normal arrays are faster and should be used whenever possible.
 */

[HamletEagle]

but you could use incrementing offsets to get different id numbers.

What do you mean by this ?