[Fyren]

Originally Posted by eyal282 not related to MaxClients at all.

And I said it doesn't matter. Think about the size of the array you're declaring. Think about what your loop indices are at the last iterations.

[Psyk0tik]

MaxClients-1 isn't recommended. Imagine having only 1 player on the server. That would be 1 - 1 = 0. That would result to client 0 (console/world).

As for MAXPLAYERS + 1, that accounts for the max players allowed on the server plus the console/world-spawn. The client count usually starts from Client 0 so that's what the + 1 is for.

Example: 32 player server

32 + 1 = Client 0, 1, 2, 3, ... 30, 31, 32

[Powerlord]

Originally Posted by Crasher_3637 MaxClients-1 isn't recommended. Imagine having only 1 player on the server. That would be 1 - 1 = 0. That would result to client 0 (console/world). As for MAXPLAYERS + 1, that accounts for the max players allowed on the server plus the console/world-spawn. The client count usually starts from Client 0 so that's what the + 1 is for. Example: 32 player server 32 + 1 = Client 0, 1, 2, 3, ... 30, 31, 32

Client indexes are entity indexes, and as you already pointed out, entity 0 is the console/world entity.

For a 32-player server, clients would be 1 through 32... but if you declare an array of size 32, it has indexes 0 through 31... hence the +1.

[Psyk0tik]

Originally Posted by Powerlord Client indexes are entity indexes, and as you already pointed out, entity 0 is the console/world entity. For a 32-player server, clients would be 1 through 32... but if you declare an array of size 32, it has indexes 0 through 31... hence the +1.

Basically:

PHP Code:

int iPlayerIndex[MAXPLAYERS + 1]; //Clients 1-32
int iPlayerIndex[32 + 1]; //Clients 1-32
int iPlayerIndex[32]; //Clients 0-31 


[ddhoward]

Originally Posted by Crasher_3637 Basically: PHP Code: int iPlayerIndex[MAXPLAYERS + 1]; //Clients 1-32 int iPlayerIndex[32 + 1]; //Clients 1-32 int iPlayerIndex[32]; //Clients 0-31

No.

PHP Code:

int iPlayerIndex[MAXPLAYERS + 1]; //66 indexes, clients 0 - 65
int iPlayerIndex[MAXPLAYERS]; //65 indexes, clients 0 - 64
int iPlayerIndex[32 + 1]; //33 indexes, clients 0-32
int iPlayerIndex[32]; //32 indexes, clients 0-31 


MAXPLAYERS is always 65. MaxClients is, basically, the number of player slots on the server. So you generally want to declare global arrays with size MAXPLAYERS+1, and non-global arrays with size MaxClients+1

[eyal282]

Originally Posted by ddhoward No. PHP Code: int iPlayerIndex[MAXPLAYERS + 1]; //66 indexes, clients 0 - 65 int iPlayerIndex[MAXPLAYERS]; //65 indexes, clients 0 - 64 int iPlayerIndex[32 + 1]; //33 indexes, clients 0-32 int iPlayerIndex[32]; //32 indexes, clients 0-31  MAXPLAYERS is always 65. MaxClients is, basically, the number of player slots on the server.

I'm confused. When declaring an array that is designed to represent players, use MAXPLAYERS or MAXPLAYERS + 1?

[ddhoward]

Originally Posted by eyal282 I'm confused. When declaring an array that is designed to represent players, use MAXPLAYERS or MAXPLAYERS + 1?

It depends. Are the indexes in the array supposed to represent the actual player indexes? If so, use the solution that causes the indexes to match the client indexes. In global arrays, this would be MAXPLAYERS+1. In non-global arrays, this would usually be MaxClients+1.

If the indexes in the array don't necessarily have to match the client indexes (for example, if the client indexes are the data being stored in the array...) then that extra index is unnecessary. You'd want to use MAXPLAYERS for global arrays and usually MaxClients for non-global.

[Powerlord]

Originally Posted by eyal282 I'm confused. When declaring an array that is designed to represent players, use MAXPLAYERS or MAXPLAYERS + 1?

MAXPLAYERS + 1

The reason being that CS:S (and CS:GO?) can have 64 players plus SourceTV. Meaning that client indexes are 1-65 and you need an array of size 66.

Edit: Take into consideration what ddhoward said about MaxClients + 1 first, though.

[eyal282]

Originally Posted by Powerlord MAXPLAYERS + 1 The reason being that CS:S (and CS:GO?) can have 64 players plus SourceTV. Meaning that client indexes are 1-65 and you need an array of size 66. Edit: Take into consideration what ddhoward said about MaxClients + 1 first, though.

And when I make a plugin exclusive to L4D2?