Raised This Month: $51 Target: $400
 12% 

Custom Votes Redux (v1.7 - 4/13/14)


Post New Thread Reply   
 
Thread Tools Display Modes
Phaiz
AlliedModders Donor
Join Date: Feb 2014
Location: USA
Old 02-10-2015 , 00:56   Re: Custom Votes Redux (v1.7 - 4/13/14)
Reply With Quote #171

Turns out this plugin has a major flaw which psychonic has tried to help me fix but so far we have not been successful. He would have to explain the "why" behind this but I can at least explain the "what".

Silenced players are still able to use this plugins commands, such as /voteban /votekick etc. It has something to do with this plugin using the trigger system.

If someone else out there has already found a fix for this please let me know
__________________
Phaiz is offline
Creampuffyness
Senior Member
Join Date: Jun 2009
Old 02-10-2015 , 13:10   Re: Custom Votes Redux (v1.7 - 4/13/14)
Reply With Quote #172

if anyone has a working voteban config beisdes Phaiz please post it. His does not seem to work in my Sourcebans 1.50F
__________________
Creampuffyness is offline
Phaiz
AlliedModders Donor
Join Date: Feb 2014
Location: USA
Old 02-10-2015 , 21:42   Re: Custom Votes Redux (v1.7 - 4/13/14)
Reply With Quote #173

Quote:
Originally Posted by Creampuffyness View Post
if anyone has a working voteban config beisdes Phaiz please post it. His does not seem to work in my Sourcebans 1.50F
Sourcebans 1.5f? Is that one of the forked versions by sarabveer? Call me crazy but that might be your problem.. it works on 1.4.11 which is the official Sourcebans version.
__________________
Phaiz is offline
Wolfseye
Senior Member
Join Date: Apr 2014
Location: Germany
Old 02-12-2015 , 12:33   Re: Custom Votes Redux (v1.7 - 4/13/14)
Reply With Quote #174

Quote:
Originally Posted by Phaiz View Post
Turns out this plugin has a major flaw which psychonic has tried to help me fix but so far we have not been successful. He would have to explain the "why" behind this but I can at least explain the "what".

Silenced players are still able to use this plugins commands, such as /voteban /votekick etc. It has something to do with this plugin using the trigger system.

If someone else out there has already found a fix for this please let me know
So i take it there is no point in using this plugin with that flaw you mentioned, right ?
Wolfseye is offline
Send a message via Skype™ to Wolfseye
Phaiz
AlliedModders Donor
Join Date: Feb 2014
Location: USA
Old 02-12-2015 , 17:19   Re: Custom Votes Redux (v1.7 - 4/13/14)
Reply With Quote #175

Quote:
Originally Posted by Wolfseye View Post
So i take it there is no point in using this plugin with that flaw you mentioned, right ?
Not at all. You can still use it and it will work, you just can't block anyone from using the commands because of how it is coded. What that means is if you silence people for vote abuse, like we do on my servers, they could still call votes. That's the flaw.
__________________
Phaiz is offline
pcmaster
AlliedModders Donor
Join Date: Sep 2009
Old 02-22-2015 , 08:49   Re: Custom Votes Redux (v1.7 - 4/13/14)
Reply With Quote #176

So I take it as there is currently no alternative to https://forums.alliedmods.net/showthread.php?t=72058 ?
__________________
Stopped hosting servers as of November 2018, no longer active around here.
pcmaster is offline
ClassicGuzzi
Veteran Member
Join Date: Oct 2013
Location: Argentina
Old 02-22-2015 , 17:17   Re: Custom Votes Redux (v1.7 - 4/13/14)
Reply With Quote #177

Quote:
Originally Posted by Phaiz View Post
Not at all. You can still use it and it will work, you just can't block anyone from using the commands because of how it is coded. What that means is if you silence people for vote abuse, like we do on my servers, they could still call votes. That's the flaw.
From basecomm.inc:

PHP Code:
/**
 * Returns whether or not a client is gagged
 *
 * @param client        Client index.
 * @return                True if client is gagged, false otherwise.
 */
native bool:BaseComm_IsClientGagged(client); 
ClassicGuzzi is offline
MaloModo
Veteran Member
Join Date: Aug 2008
Old 02-23-2015 , 11:34   Re: Custom Votes Redux (v1.7 - 4/13/14)
Reply With Quote #178

We have noticed this as well...it doesn't have anything to do with !votemenu or !settings commands?

Last edited by MaloModo; 02-23-2015 at 11:35.
MaloModo is offline
Phaiz
AlliedModders Donor
Join Date: Feb 2014
Location: USA
Old 02-23-2015 , 13:37   Re: Custom Votes Redux (v1.7 - 4/13/14)
Reply With Quote #179

Quote:
Originally Posted by ClassicGuzzi View Post
From basecomm.inc:

PHP Code:
/**
 * Returns whether or not a client is gagged
 *
 * @param client        Client index.
 * @return                True if client is gagged, false otherwise.
 */
native bool:BaseComm_IsClientGagged(client); 
I'm not sure what you are trying to say.
__________________
Phaiz is offline
ClassicGuzzi
Veteran Member
Join Date: Oct 2013
Location: Argentina
Old 02-23-2015 , 16:11   Re: Custom Votes Redux (v1.7 - 4/13/14)
Reply With Quote #180

Quote:
Originally Posted by Phaiz View Post
I'm not sure what you are trying to say.
You said that silenced players could still trigger votes.

Quote:
What that means is if you silence people for vote abuse, like we do on my servers, they could still call votes
So you could just check if the client it's gaged (since silence is just mute and gag ) and return Plugin_Continue if he/she is gaged, something like this:

PHP Code:
public Action:OnClientSayCmd(iVoter, const String:strCmd[], iArgc)
{
    if(!
IsValidClient(iVoter))
        return 
Plugin_Continue;
    if(
BaseComm_IsClientGagged(iVoter))
        return 
Plugin_Continue
And I think that you need to check it on Command_ChooseVote too.
ClassicGuzzi is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 23:39.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode