[Hennesy]

Hello mates, help please, the plugin does not work, it seems everything is fine, but the players from the queue are not transferred for CT.

I have a queue for CT, and at the end of the round, the balance of the players is checked and if there is someone in the queue, then transfer them for CT, and if there is no one in the queue, then move the random Terrorist for CT.

I write all the players into an array, and at the end I sort (add) those who are in the queue.

But the code doesn't work.

PHP Code:

public void Event_RoundEnd(Event hEvent, const char[] szEvName, bool bSilent)
{
    int[][] iPlayers = new int[2][MaxClients];
    int i = 1, iTeam, iClients[3];

    for(; i <= MaxClients; ++i)
    {
        g_bRoundUsed[i] = false;
        if(IsClientInGame(i) &&(iTeam = GetClientTeam(i)) > 1)
        {
            ++iClients[2];
            iTeam -= 2;
            iPlayers[iTeam][iClients[iTeam]++] = i;
        }
    }

    if(iClients[2] < 2)
        return;

    int iCTs = RoundToFloor(float(iClients[2])/100.0*RATIO);

    if(iCTs == iClients[2])
        return;

    if(iClients[1] > iCTs)
    {
        SortIntegers(iPlayers[1], iClients[1], Sort_Random);
        int iRatio = iClients[1] - iCTs;
        while(iRatio-- && iClients[1]) CS_SwitchTeam(iPlayers[1][--iClients[1]], 2);

        return;
    }
    
    SortArray(iPlayers[0], iClients[0]);

    int iRatio = iCTs - iClients[1];
    while(iRatio-- && iClients[0]) CS_SwitchTeam(iPlayers[0][--iClients[0]], 3);
}

stock void SortArray(int[] iArray, int iSize)
{
    int iQueueSize = g_hQueue.Length;
    if(!iQueueSize)
    {
        SortIntegers(iArray, iSize, Sort_Random);
        return;
    }

    for(int i = 1, j = iSize-1, k, iClient, index; i < iQueueSize; ++i)
    {
        iClient = GetClientOfUserId(g_hQueue.Get(i));
        if(!iClient || GetClientTeam(iClient) != 2 || CtBan_IsClientBanned(iClient) || !g_bToCT[iClient])
        {
            g_hQueue.Erase(i);
            --i;
            continue;
        }

        index = FindClientInArray(iClient, iArray, iSize);
        if(index != -1)
        {
            k = iArray[j];
            iArray[j] = iArray[index];
            iArray[index] = k;
            --j;
        }
    }
} 


[azalty]

Please comment your code, I shouldn't have to guess what it does

if(iClients[2] < 2)
        return;

int iCTs = RoundToFloor(float(iClients[2])/100.0*RATIO);

if(iCTs == iClients[2])
        return;

I don't understand what this is for, you didn't give us RATIO, and no comment as well, but I assume iClients[2] is the total number of players, iClients[0] the number of Ts and iClients[1] the number of CTs
(you could have used iClients[0]+iClients[1] instead of iClients[2] but whatever).

int iCTs -> the number of CTs you should have in order for the game to be balanced, I guess?


if(iClients[1] > iCTs) -> too much CTs, swap random ones, I assume

while(iRatio-- && iClients[1]) CS_SwitchTeam(iPlayers[1][--iClients[1]], 2); -> this is a bit complicated, you could have made it a lot easier. It's not really easy to understand, but I assume it works? You could have used a simple for loop.

The rest of this forward/event/whatever it is called is okay

SortArray:

for(int i = 1,...) -> i should be set to 0, indexes in ArrayLists and basic int arrays always start from 0, meaning you won't enter this loop if there's only one person in the queue


FindClientInArray is not specified here, can't know if it's wrong

The rest seems okay, at least from my -quick- look.
Seriously, organize your code, add comments, don't over complicate your code.

[Hennesy]

Originally Posted by azalty I don't understand what this is for, you didn't give us RATIO

PHP Code:

#define RATIO        30 // % from all players can be for CT 


PHP Code:

iClients[2] = total all players;
iClients[1] = total CT players
iClients[0] = total T players 


How many CT will be from% of all T

PHP Code:

int iCTs = RoundToFloor(float(iClients[2])/100.0*RATIO); 


PHP Code:

stock int FindClientInArray(int iClient, int[] iArray, int iSize)
{
    for(int i; i < iSize; ++i) if(iArray[i] == iClient) return i;
    return -1;
} 


Perhaps you can provide a solution that is simpler for me?

The problem is in SortArray, it must perform the task: If there are players in the queue (g_hQueue), then they must be transferred in priority for the terrorists. I kind of add them at the beginning of the Array and, according to the idea, they should be taken from there first.

[azalty]

Originally Posted by Hennesy Perhaps you can provide a solution that is simpler for me? The problem is in SortArray, it must perform the task: If there are players in the queue (g_hQueue), then they must be transferred in priority for the terrorists. I kind of add them at the beginning of the Array and, according to the idea, they should be taken from there first.

Your solution should work, if you just fix what I said earlier (int i in the for loop instead of int i = 1)

If it doesn't work, add some logging (I usually use LogMessage() for that)

[Hennesy]

Originally Posted by azalty i = 0

PHP Code:

L 09/10/2021 - 22:05:14: [SM] Exception reported: Client index 0 is invalid
L 09/10/2021 - 22:05:14: [SM] Blaming: plugin.smx
L 09/10/2021 - 22:05:14: [SM] Call stack trace:
L 09/10/2021 - 22:05:14: [SM]   [0] GetClientOfUserId
L 09/10/2021 - 22:05:14: [SM]   [1] Line 85, plugin.sp::SortArray
L 09/10/2021 - 22:05:14: [SM]   [0] GetClientTeam
L 09/10/2021 - 22:05:14: [SM]   [1] Line 86, plugin.sp::SortArray 


then such problems arise

PHP Code:

    for(int i = 0, j = iSize-1, k, iClient, index; i < iQueueSize; ++i)
    {
        iClient = GetClientOfUserId(g_hQueue.Get(i)); // <- error
        if(!iClient || GetClientTeam(iClient) != 2 || CtBan_IsClientBanned(iClient) || !g_bToCT[iClient]) // <- error 


[azalty]

Originally Posted by Hennesy PHP Code: L 09/10/2021 - 22:05:14: [SM] Exception reported: Client index 0 is invalid L 09/10/2021 - 22:05:14: [SM] Blaming: plugin.smx L 09/10/2021 - 22:05:14: [SM] Call stack trace: L 09/10/2021 - 22:05:14: [SM]   [0] GetClientOfUserId L 09/10/2021 - 22:05:14: [SM]   [1] Line 85, plugin.sp::SortArray L 09/10/2021 - 22:05:14: [SM]   [0] GetClientTeam L 09/10/2021 - 22:05:14: [SM]   [1] Line 86, plugin.sp::SortArray  then such problems arise PHP Code:     for(int i = 0, j = iSize-1, k, iClient, index; i < iQueueSize; ++i)     {         iClient = GetClientOfUserId(g_hQueue.Get(i)); // <- error         if(!iClient || GetClientTeam(iClient) != 2 || CtBan_IsClientBanned(iClient) || !g_bToCT[iClient]) // <- error

I don't get it, you shouldn't even enter GetClientTeam(iClient) since (!iClient) is right before.
GetClientOfUserId() cannot really error, it just returns 0
g_hQueue.Get(i) doesn't seem to error (and shouldn't)

btw index = FindClientInArray(iClient, iArray, iSize); is useless since i == index (at least I think)

[Hennesy]

Originally Posted by azalty I don't get it, you shouldn't even enter GetClientTeam(iClient) since (!iClient) is right before. GetClientOfUserId() cannot really error, it just returns 0 g_hQueue.Get(i) doesn't seem to error (and shouldn't) btw index = FindClientInArray(iClient, iArray, iSize); is useless since i == index (at least I think)

In the same place the logical expression || "OR"

iClient may be positive, but GetClientTeam may not.

Exception reported: Client index 0 is invalid

PHP Code:

iClient = GetClientOfUserId(g_hQueue.Get(i)); << error this line 


[azalty]

Originally Posted by Hennesy In the same place the logical expression || "OR" iClient may be positive, but GetClientTeam may not. Exception reported: Client index 0 is invalid PHP Code: iClient = GetClientOfUserId(g_hQueue.Get(i)); << error this line

if (true || GetClientTeam(1548455) != 2)

^ this should never error, since as soon as we have 'true' in a if/or check, we exit it. The error would have occured if && was there instead.

Originally Posted by Hennesy PHP Code: iClient = GetClientOfUserId(g_hQueue.Get(i)); << error this line

Again, this doesn't make any sense to me. It returns a value in case of error (0), not an actual error that stops the function. GetClientTeam() does, on the other hand.

[Hennesy]

Originally Posted by azalty if (true || GetClientTeam(1548455) != 2) ^ this should never error, since as soon as we have 'true' in a if/or check, we exit it. The error would have occured if && was there instead. Again, this doesn't make any sense to me. It returns a value in case of error (0), not an actual error that stops the function. GetClientTeam() does, on the other hand.

added Queue:

PHP Code:

int i = g_hQueue.Push(GetClientUserId(iClient)); 


g_hQueue.Get returns 0 index in this case, but should return userid -> then converts userid to index - and we are already working with it. But it returns 0

[Hennesy]

Maybe you can help me rewrite SortArray, it seems to me that the error is just in the loop itself.