[Salamon]

ahh i understand it now ^^

;* friend kiss haha xD

[Simon Logic]

Interesting one. Pity i have no time to play with amx/x more.

I suggest converting flashlight_drainfreq & flashlight_chargefreq into cvars called e.g. flashlight_deplete_secs & flashlight_fullcharge_secs (if possible of course) which will stand for number of seconds fully charged flashlight can emit light until is depleted & number of secs an exhausted flashlight have to be charged respectively. This is more user-friendly.

Also you can optimize calculations within Make_FlashLight(id) (looks like it can be called rather often):

iAttn = 256 + iDecay * get_pcvar_num(g_pcvarFlashAttn) // barney/dontaskme
-->
fTemp = 256 / (256 + iDecay * get_pcvar_num(g_pcvarFlashAttn))
...
write_byte((g_iColor[id][Red] * fTemp)

Also this one

#define SOUND_FLASHLIGHT_ON "items/flashlight1.wav"
#define SOUND_FLASHLIGHT_OFF    "items/flashlight1.wav" 

theoretically makes resource duplication (depends of number of macro entries in the code) in compiled plugin. I would rather use new const instead of #DEFINE for string constants especially when they occure twice or more in the source code.

Again, pity i could not test it in-game. As i remember Avalanche's plugin did not feed my needs in conjunction with Blinding Flashlight.

[ConnorMcLeod]

Thanks for suggestions.
I've changed cvars and #define thing.


I'm still confused on what is better for the attenuation thing as you may have missed that i need to have an integer/byte, so if i use floats i need to round them.
So what is optimized :

    static iDecay, iAttn

    iDecay = floatround( flDist * 255.0 / flMaxDist )
    iAttn = 256 + iDecay * get_pcvar_num(g_pcvarFlashAttn) // barney/dontaskme

    // [..]

    write_byte((g_iColor[id][Red] * 256) / iAttn)
    write_byte((g_iColor[id][Green] * 256) / iAttn)
    write_byte((g_iColor[id][Blue] * 256) / iAttn)

or

    static iDecay, Float:flAttn

    iDecay = floatround( flDist * 255.0 / flMaxDist )
    flAttn = 256.0 / (256 + iDecay * get_pcvar_num(g_pcvarFlashAttn))

    // [..]

    write_byte( floatround( g_iColor[id][Red] * flAttn ) )
    write_byte( floatround( g_iColor[id][Green] * flAttn ) )
    write_byte( floatround( g_iColor[id][Blue] * flAttn ) )

??

[jim_yang]

I still preferred the first one, obviously call triple floatround is not wise here. but I don't know if the pawn compiler has optimization about multiplying like this: (my guess is yes)
somevalue * 256 => somevalue<<8

also arrayset nonzero value is not so fast as your imagination.
so just set a loop

[ConnorMcLeod]

Updated to v0.3.0, thanks to both of you

[Son]

Not bad. ;) Karma.

[warzarmz]

theres a bug in your plugin i'm not sure your aware of.

Lets say my server is running Biohazard, and its also running this plugin. If a human has the flashlight on when he gets infected, the zombie can't turn off the light, it always stays on.

[ConnorMcLeod]

This is related to Biohazard plugin, ask author for modifications if you want, i can't do nothing about it.

-edit-
If Zombies are in fact terrorists, you can set per team color and T color to 000000000.

[luffy67]

Nice Job Connorr , +karma

[ConnorMcLeod]

Originally Posted by luffy67 Nice Job Connorr , +karma

Merci mec ;)