[lexzor]

hello. i have this code

PHP Code:

public client_disconnected(id)
{
    if(is_user_logged_in(id))
    {
        new szQuery[512];
        formatex(szQuery, charsmax(szQuery), "UPDATE `%s` SET `is_user_online` = '0' WHERE `email` = '%s'", g_szTables[0], g_UserData[id][szEmail]);
        SQL_ThreadQuery(g_SqlTuple, "FreeHandle", szQuery);
    }
}

public FreeHandle(FailState, Handle:Query, szError[], ErrorCode, szData[], iSize)
{
    if(FailState || ErrorCode)
        log_amx("^nSQL ERROR: %s^n", szError);

    SQL_FreeHandle(Query);
}

bool:is_user_logged_in(id)
{
    return g_UserData[id][iIsUserLoggedIn] == 1 ? true : false;
} 


the problem is that sometimes somehow the query is not sent to the database and column is_user_online is not updating to 0. how can i be sure the query is sent or how can i be sure the column is updated when player is disconnecting ?

[Shadows Adi]

It's not updating because it returns an error, because you pass two string arguments in your szQuery and give only one value:

"UPDATE `%s` // first param
 SET `is_user_online` = '0' WHERE
 `email` = '%s'", // second param
 g_UserData[id][szEmail] // only one string passed, not two. 

[lexzor]

Sorry, forgot to add it. The problem is still there.

[Natsheh]

Post everything essential to the problem, such as the Table layout in addition to the whole script.

[lexzor]

i already posted what is essential to the problem i don t see why i would post a 1800 lines script if my problem is a query that sometimes don't work.

[Shadows Adi]

formatex(szQuery, charsmax(szQuery), "UPDATE `%s` SET `is_user_online` = '0' WHERE `email` = ^"%s^";", g_szTables[0], g_UserData[id][szEmail]);

Try this.
Also, any errors in log?

 if(FailState || ErrorCode)
        log_amx("^nSQL ERROR: %s^n", szError);

[Bugsy]

I'd try what Shadows Adi suggested, as the email address(es) that are causing you issues may contain a ' character(s).

If you haven't done so already, add some logging to your plugin so you can identify which email addresses are causing you problems. (assuming it's not every single email)

[Natsheh]

Originally Posted by lexzor i already posted what is essential to the problem i don t see why i would post a 1800 lines script if my problem is a query that sometimes don't work.

How are you so certain that your problem doesn't relay in those 1800 lines.?


Also you don't need to free the handle in the thread function call back, read the documentation carefully.

PHP Code:

public FreeHandle(FailState, Handle:Query, szError[], ErrorCode, szData[], iSize)
{
    if(FailState || ErrorCode)
    {
        log_amx("^nSQL ERROR: %s^n", szError);
        return; // Always return when there's an error.
     }

    SQL_FreeHandle(Query); <---------- Remove this line!
}