Raised This Month: $51 Target: $400
 12% 

amxip, showip, printip


Post New Thread Reply   
 
Thread Tools Display Modes
Exolent[jNr]
Veteran Member
Join Date: Feb 2007
Location: Tennessee
Old 11-09-2009 , 09:39   Re: amxip, showip, printip
Reply With Quote #21

Then maybe you should put a note in the first post saying it is for communities with trustworthy admins only.
__________________
No private work or selling mods.
Quote:
Originally Posted by xPaw View Post
I love you exolent!
Exolent[jNr] is offline
Trafalete
Senior Member
Join Date: Sep 2008
Location: Bucuresti ( Printre nori
Old 11-09-2009 , 15:39   Re: amxip, showip, printip
Reply With Quote #22

i still say it isn't a good ideea
__________________


Trafalete is offline
Exolent[jNr]
Veteran Member
Join Date: Feb 2007
Location: Tennessee
Old 01-31-2010 , 18:13   Re: amxip, showip, printip
Reply With Quote #23

1. Don't create variables inside of loops.
Create them before the loop and then assign them values inside of the loop.

2. In print_all_ip(), don't mix return values.
Return 0 if fail and 1 if success is the standard.

3. Cache access(id, ADMIN_KICK) outside of the loop so you don't call it every time.

4. Don't use get_user_ip() and get_user_authid() in the loop unless player is not an admin.
Example:
Code:
if(access(iPlayer, ADMIN_KICK)) {     // format fake ip and steamid } else {     // use get_user_ip and get_user_authid }

5. Don't use #define for strings that are used more than once in the plugin.
You should use new const instead.

6. (OPTIONAL) If you want to make it even better, you could use the new Orpheu2 and hook the "status" command, block the results and print your own.
That way player's can't check if an admin's SteamID is fake.

Approval pending on changes.
__________________
No private work or selling mods.
Quote:
Originally Posted by xPaw View Post
I love you exolent!
Exolent[jNr] is offline
crazyeffect
Veteran Member
Join Date: Jul 2008
Location: Belgium
Old 02-15-2010 , 18:52   Re: amxip, showip, printip
Reply With Quote #24

Quote:
jayprakash

Junior Member

Last Activity: 30-12-09 166
__________________
crazyeffect is offline
Send a message via MSN to crazyeffect
Hawk552
AMX Mod X Moderator
Join Date: Aug 2005
Old 04-02-2010 , 18:52   Re: amxip, showip, printip
Reply With Quote #25

This is redundant and cannot be approved. There are other plugins which do the job equally or better.

This plugin has been given time to be fixed but no changes have been made.

If you would like any information regarding possible adjustments you could make or things you could do to make this better, please feel free to post here or PM me.

Unapproved.
__________________
Hawk552 is offline
Send a message via AIM to Hawk552
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 08:51.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode