[tuty]

that is hip_hop_x stock not mine , thanks for help.. will update soon

@ Spunky - good idea i will try something

[Spunky]

get_user_team() already works, I just want it to return 1 for Good, 2 for Evil, or 0/-1 for FFA. get_user_team() only returns 9 for the team ID.

stock esf_get_team(id)
{
    new szTeamName[6]
    get_user_team(id, szTeamName, 5)

    if (equal(szTeamName, "Good"))
        return 1

    else if (equal(szTeamName, "Evil"))
        return 2

    else
        return 0
}

Also, use stocks instead of macros. With a macro, a new stack allocation is made for each use of the macro, cluttering up DAT and using precious resources.

[YamiKaitou]

Originally Posted by Spunky Also, use stocks instead of macros. With a macro, a new stack allocation is made for each use of the macro, cluttering up DAT and using precious resources.

Macros are replaced at compile, so there is no reason not to use them (at least from what I understand of it).

[joaquimandrade]

Originally Posted by YamiKaitou Macros are replaced at compile, so there is no reason not to use them (at least from what I understand of it).

Yes.

each use of the macro

There isn't "each use of macro". A macro is a rule for text replacement applied before compiling. A way of avoid a function call.

[tuty]

@ Spunky thanks for idea and stock.. i will update this inc asap

[Nextra]

Originally Posted by Spunky get_user_team() already works, I just want it to return 1 for Good, 2 for Evil, or 0/-1 for FFA. get_user_team() only returns 9 for the team ID. PHP Code: stock esf_get_team(id)  {          new szTeamName[6]          get_user_team(id, szTeamName, 5)       if (equal(szTeamName, "Good"))              return 1       else if (equal(szTeamName, "Evil"))             return 2       else             return 0  }

Will get_user_team always return 9? If it does not and returns unique numbers you could just remap it - returning 1 if get_user_team is 9, 2 if it is 8 (or whatever).

If this does not apply I would use this instead of full string comparison (assuming that those are unique):

PHP Code:

stock esf_get_team(id) 
{     
    new szTeamName[2]     
    get_user_team(id, szTeamName, 1)      

if( szTeamName[0] == 'G' )         
    return 1      

else if( szTeamName[0] == 'E' )        
    return 2      

else        
    return 0 
} 


[tuty]

updated the INC... look at my esf_get_team

[Nextra]

Nice. Of course a switch is the next step of what I did. Should've come up with that by myself

[Spunky]

Originally Posted by YamiKaitou Macros are replaced at compile, so there is no reason not to use them (at least from what I understand of it).

Yeah, but look at this quote from BAILOPAN's dev log:

Originally Posted by BAILOPAN We noticed that the DAT section is not optimized. You can repeat a string a 800 times and the DAT section will have an entry for each repetition. The solution? //BAD #define COMMON_STRING   "Gaben" //GOOD new COMMON_STRING[] = "Gaben" This way, DAT will only have one reference. Furthermore, it might even be faster because in the case of non-const the compiler won’t have to copy it into the heap first. In many cases you know it will never be modified, and the native declaration simply forgot a ‘const’ keyword. Another example: //BAD stock GetWeaponName(id, name[], max) {    if (id==0)       copy(name, max, "weapon_none")    else if (id==1)       copy(name, max, "weapon_gaben")    //.... } //GOOD new g_WeaponNames[] = {      "weapon_none", //0     "weapon_gaben", //1 } A lookup table is near-instantaneous execution. The compiler simply has to add an integer to a base memory offset. Calling a function is expensive — branch prediction, cache misses, more instructions can add up very quickly. If you’re using the function very often, it’s a good idea to take the time to make these trivial and worth-while optimizations. You can do lookup tables in Small for anything which inputs an integer and outputs any other data type, as long as the set of inputs has fixed limits. It is okay to build the lookup table at runtime, as long as you don’t need to do it often (or building it often outweighs the cost of computing entries totally dynamically).

Greenberet told me about this and I was shocked at how unoptimized the Pawn compiler is.

[hleV]

I thought it's for strings only. So I shall not use const even if I'm not planing changing my variable?