[Bugsy]

Originally Posted by Corabika Bugsy Please How To Found Rank Pos And Thanks

You can't directly. You need to use nvault utility to read all entries into an array and then sort the array. You are better off using SQL in terms of ease and performance.

[Craxor]

Bugsy,opinion about this Save functions ?

public SaveGravity( id )
{
    new szKey[40] , szGravity[11] , szAuthID[35];
    get_user_authid( id, szAuthID, charsmax( szAuthID ) );

    formatex( szKey , charsmax( szKey ) , "%s-Grav" , szAuthID );
    formatex( szGravity , charsmax( szGravity ) , "%d" , g_iUserGravity[id] );

    nvault_set( g_nVault, szKey, szGravity );
}

public LoadGravity( id )
{
    new szKey[40] , szAuthID[35] , szGravity[11];
    get_user_authid( id, szAuthID, charsmax( szAuthID ) );

    formatex( szKey , charsmax( szKey ) , "%s-Grav" , szAuthID );
    formatex( szGravity , charsmax( szGravity ) , "%d" , g_iUserGravity[id] );

    new iGravity = nvault_get( g_nVault, szKey );
    SetGravity(id, iGravity);
}

[Bugsy]

public SaveGravity( id )
{
    new szKey[40] , szGravity[11] , szAuthID[35];

    get_user_authid( id, szAuthID, charsmax( szAuthID ) );
    //You should store all player id's in a global array so it can be used 
    //in all places without re-calling the native.

    formatex( szKey , charsmax( szKey ) , "%s-Grav" , szAuthID );
    formatex( szGravity , charsmax( szGravity ) , "%d" , g_iUserGravity[id] );
    //Since you are not formatting, use num_to_str() instead.

    nvault_set( g_nVault, szKey, szGravity );
}

public LoadGravity( id )
{
    new szKey[40] , szAuthID[35] , szGravity[11];
    get_user_authid( id, szAuthID, charsmax( szAuthID ) );

    formatex( szKey , charsmax( szKey ) , "%s-Grav" , szAuthID );
    formatex( szGravity , charsmax( szGravity ) , "%d" , g_iUserGravity[id] );
    //You do not need the szGravity variable or the above formatex(). In this
    //function you are loading data, there is no need to format a variable that
    //you would just overwrite (though you're not doing this) with data being loaded. 
    
    new iGravity = nvault_get( g_nVault, szKey );
    //I recommend using nvault_lookup() here so you can tell if data 
    //was found in the vault. nvault_get() will return 0 if a 0 exists as 
    //the data, or no data was found. If you prefer to use nvault_get(), 
    //which is ok, you should check that it's an acceptable value (>= X) 
    //before passing it to SetGravity().
    
    SetGravity(id, iGravity);
}

[Craxor]

What about my small example:

Click

#include <amxmodx>
#include <nvault>

// '32' store indexes, 31 the string size.
new szAuthId[32][31];
new iPoint[32];
new gNv;

public plugin_init( )
{
    register_clcmd( "say /test", "test" );
    register_clcmd( "say /points", "p" );

    gNv = nvault_open( "test_vault" );
}

public client_authorized( id )
{
    get_user_authid( id, szAuthId[id][0], charsmax( szAuthId[] ) );

    set_task( 1.5, "LoadPoints", id );
}

public plugin_ent( )
{
    nvault_close( gNv );
}

public test(id)
{
    client_print( id, print_chat, "Points: %i", iPoint[id] );
}

public p( id )
{
    iPoint[id] = iPoint[id] + 100;
    SavePoints( id );
}

SavePoints( id )
{
    new szPoints[9];
    num_to_str( iPoint[id], szPoints, charsmax( szPoints ) );

    nvault_set( gNv, szAuthId[id][0], szPoints );
}

public LoadPoints( id )
{
    //  nvault_get return the Value of the Respective key, so you need just the Vault and its key.
    new iPlayerPoints = nvault_get( gNv, szAuthId[id][0] )

    if( iPlayerPoints > 0 )
        iPoint[id] = iPlayerPoints;

    else
        iPoint[id] = 1; 
}

[PRoSToTeM@]

Why you wait for 1.5 seconds?

[Black Rose]

Originally Posted by Craxor What about my small example: Click #include <amxmodx> #include <nvault> // '32' store indexes, 31 the string size. new szAuthId[32][31]; new iPoint[32]; new gNv; public plugin_init( ) {     register_clcmd( "say /test", "test" );     register_clcmd( "say /points", "p" );     gNv = nvault_open( "test_vault" ); } public client_authorized( id ) {     get_user_authid( id, szAuthId[id][0], charsmax( szAuthId[] ) );     set_task( 1.5, "LoadPoints", id ); } public plugin_ent( ) {     nvault_close( gNv ); } public test(id) {     client_print( id, print_chat, "Points: %i", iPoint[id] ); } public p( id ) {     iPoint[id] = iPoint[id] + 100;     SavePoints( id ); } SavePoints( id ) {     new szPoints[9];     num_to_str( iPoint[id], szPoints, charsmax( szPoints ) );     nvault_set( gNv, szAuthId[id][0], szPoints ); } public LoadPoints( id ) {     //  nvault_get return the Value of the Respective key, so you need just the Vault and its key.     new iPlayerPoints = nvault_get( gNv, szAuthId[id][0] )     if( iPlayerPoints > 0 )         iPoint[id] = iPlayerPoints;     else         iPoint[id] = 1;  }

What about it?

Arrays using player id as index should have the size of 33 for ease of use and avoid conflicts when using non-dedicated.

new iPlayerPoints = nvault_get( gNv, szAuthId[id][0] )
This points towards the first character in the string, the result is the same though because of the way that pawn terminates and reads strings. Still, if this is the example to be used it should be correct.

new szPoints[9];
This makes room for 8 characters + null. The maximum possible number of this is 99 999 999.
Max integer: 2 147 483 647, only 2 characters longer. Useless optimization of saving temporary memory.


This example is wrong as pointed out by Bugsy, the key is handled as char and the individual cells can therefor be no higher than 127.
My personal preference is to mash the SteamID into an integer and use it as a key instead of saving strings globally. (Can't do that with names, so non-steamers have to think which we know they are incapable of...)
For example:

I'm bad code, don't use me.

I do love integers though.

[Craxor]

@prostetamoto: Just for safety, 'maybe' player is not fully connected so i make a little delay, is not big deal but just to be sure( and in my past i was having problems some times so this should be there ).

It's you preferences rose, but bugsy said to make a global var gAuthId to avoid calling get_user_authid more times, even if you make it in a stock calls are maded more times but that's about preferences.


About szPoints should be [11] sorry i did not know about max integers

Oo, about '33' as i know:

32 - the container wich hold the the arrays:

31 - id 32
30 - id 31
29 - id 30
28 - id 29
27 - 28
..... bla bla bla...
4 - id 5
3 - id 4
2 - id 3
2 - id 3
1 - id 2
0 - id 1.

So why using 33 ?

[klippy]

client_authorized() is called once the player gets authenticated (gets the Steam ID), so you can already safely retrieve their Steam ID.

[Craxor]

I know man.

Sometimes when server works slowly and more players connect in the same times it can appears problems, so for safety i'm using a task. ( Anyway players not even observe ) and i don't will ruin the whole code, it should be used that's my op.

[klippy]

There can be no problems with multiple players connecting "at the same time" because the game loop is completely single threaded. But whatever, do as you like.