[imyz]

Originally Posted by thewintersoldier97 I got a similar bug while using Item Hint before, do you also using it? It has been fixed on the current version of the plugin though.

No. And I didn't even know this 'Item Hint' you mentioned above.

As a matter of fact, including those plugins shipped with SourceMod by default, I have 26 plugins in total installed in my dedicated server. So, if you count this one and those xxx_shove plugins in by SilverShot, there is no room left anymore for other plugins at all

[Silvers]

The reason for items being attached to feet was a change to enable the weapon selection equip icon animation. I think the older version before 2.0 might of had this and after someone reported the equip icon was missing in 2.0 I've added it back in but I still don't know why the feet bug is happening now. It seems to be a lot rarer than it was after adding back in. Maybe one day I can compare the old versions and this to see if anything can be done. The whole bug makes no sense.

[NoroHime]

could you fire event "give_weapon" and "weapon_given"?
they should work like game work with thirdparty plugin

[Zheldorg]

Bug Report: if I exchange identical items with a bot, then the exchange can be done as much as you like (while the weapon changes to the main one with each exchange), but for example, exchanging a grenade for a Molotov will lead to the fact that I cannot exchange the received Molotov with any of the bots . It is required to go to idle and back in order to have a second opportunity to exchange.
I will clarify that items from other slots can still be tried to be exchanged until they also bug. An already bugged item cannot

P.S. I found that for me, as client 1, Event_WeaponDrop is called first, then OnWeaponEquip twice and again Event_WeaponDrop, which apparently resets the values in the cells g_iClientItem, g_iClientType. I still do not understand what the second Event_WeaponDrop calls, it is called before line 1481: if( IsFakeClient(target) ), but after line 1469: if( IsFakeClient(client) ). Here is the output of test PrintToChatAll:

PHP Code:

Zheldorg :  123
TransferItem step
TransferItem item 357
TransferItem item_ref -2065071771
TransferItem type 3
TransferItem type 3
TransferItem step 1
TransferItem step 2
TransferItem step IG
GiveItem step
Zheldorg обменял бомбу у Coach
Coach отдал желчь толстяка Zheldorg
Event_WeaponDrop step client 1
OnDrop step client 1
OnWeaponEquip client 1 weapon 514
OnWeaponEquip classname weapon_vomitjar
OnWeaponEquip ClientItem -2074799614
OnWeaponEquip ClientType 5
OnWeaponEquip client 1 weapon 514
OnWeaponEquip classname weapon_vomitjar
OnWeaponEquip ClientItem -2074799614
OnWeaponEquip ClientType 5
Event_WeaponDrop step client 1
OnDrop step client 1
OnWeaponEquip client 4 weapon 357
OnWeaponEquip classname weapon_pipe_bomb
OnWeaponEquip ClientItem -2065071771
OnWeaponEquip ClientType 4
TransferItem step finish
TransferItem client 1, ID0, Item 0, Type 0 
TransferItem client 1, ID1, Item -2095976014, Type 6 
TransferItem client 1, ID2, Item -2068115104, Type 1 


P.S.S line 1556: int CreateAndEquip(int client, int type), on the left for different types, on the right exchange of identical objects. It can be seen that in the second option, OnWeaponEquip and Event_WeaponDrop for GivePlayerItem() are not called, but a new entity is created because it is clear that the if( entity != INVALID_ENT_REFERENCE ) condition is triggered

PHP Code:

CreateAndEquip step client 1                           CreateAndEquip step client 1
Event_WeaponDrop step client 1                         
OnDrop step client 1                                   
OnWeaponEquip client 1 weapon 357                      
OnWeaponEquip classname weapon_molotov                 
OnWeaponEquip ClientItem -2065071771                   
OnWeaponEquip ClientType 3                             
CreateAndEquip GivePlayerItem step client 1            CreateAndEquip GivePlayerItem step client 1
OnWeaponEquip client 1 weapon 357                      OnWeaponEquip client 1 weapon 357
OnWeaponEquip classname weapon_molotov                 OnWeaponEquip classname weapon_molotov
OnWeaponEquip ClientItem -2065071771                   OnWeaponEquip ClientItem -2065047195
OnWeaponEquip ClientType 3                             OnWeaponEquip ClientType 3
Event_WeaponDrop step client 1                         Event_WeaponDrop step client 1
OnDrop step client 1                                   OnDrop step client 1
CreateAndEquip EquipPlayerWeapon step client 1         CreateAndEquip EquipPlayerWeapon step client 1
GiveItem IsFakeClient Finish step client 1             GiveItem IsFakeClient Finish step client 1
GiveItem Front IsFakeClient step client 1              GiveItem Front IsFakeClient step client 1
OnWeaponEquip client 2 weapon 517                      OnWeaponEquip client 2 weapon 484
OnWeaponEquip classname weapon_vomitjar                OnWeaponEquip classname weapon_molotov
OnWeaponEquip ClientItem -2065845755                   OnWeaponEquip ClientItem -2104466972
OnWeaponEquip ClientType 5                             OnWeaponEquip ClientType 3
GiveItem Front IsFakeClient step target 2              GiveItem Front IsFakeClient step target 2
TransferItem step finish                               TransferItem step finish
TransferItem client 1, ID0, Item 0, Type 0             TransferItem client 1, ID0, Item -2065047195, Type 3 
TransferItem client 1, ID1, Item -2137743001, Type 6   TransferItem client 1, ID1, Item -2137743001, Type 6 
TransferItem client 1, ID2, Item -2033082097, Type 1   TransferItem client 1, ID2, Item -2033082097, Type 1 


P.S.S.S void OnDrop(int client, int item), found out that the right case never passes if( item == g_iClientItem[client][i] )

P.S.S.S.S Everything looks like this: in "void GiveItem()" the client is a live player, the target is a bot, "if( transferType == METHOD_SWAP )" fires as "true", if( IsFakeClient(client) ) goes to "else ", detach the item from the bot RemovePlayerItem(target, ent_t) and destroy RemoveEdict(ent_t), call CreateAndEquip(client, type_t - 1), in the called one, create an object identical to the type that we destroyed earlier int entity = GivePlayerItem(client, classname), and here oddities arise , GivePlayerItem raises the event void Event_WeaponDrop in it, it tries to drop the object we have (this is clear from the comparison of int item = event.GetInt("propid") with g_iClientItem[client][' current slot']) since we did not untie our object beforehand (RemovePlayerItem(client, ent_c) will be called much later), then GivePlayerItem calls OnWeaponEquip to bind the newly created item to us, then EquipPlayerWeapon(client, entity) re-attaches the newly created item by calling OnWeaponEquip and then generates an event "Event_WeaponDrop", trying to drop an entity , although the item will not actually be dropped, in the OnDrop() function called next, the g_iClientItem and g_iClientType for the current item will be reset to zero, which will not allow the item to be exchanged again.

If the exchange is identical items, another nuance arises, int entity = GivePlayerItem(client, classname) will create an item, but will not call either Event_WeaponDrop or OnWeaponEquip. As a result, since the entity is correct, after if( entity != INVALID_ENT_REFERENCE ) EquipPlayerWeapon(client, entity) will be called, it will already call OnWeaponEquip for the newly created item, as well as Event_WeaponDrop but for the old non-detached item, in the OnDrop() function in the line if( item == g_iClientItem[client][i] ) will not match and g_iClientItem and g_iClientType will not be set to null. In general, all // TRANSFER code looks problematic from these shoving items.

OUTCOME
One line comment and a few line breaks seem to solve the problem. Attach l4d_gear_transfer.sp

[Silvers]

Originally Posted by Zheldorg Bug Report ---

Sorry I don't understand what should be changed. Can you clarify. The non-test version you posted is identical to the last release and the test version only has debug prints.

2.20 (01-Mar-2022)
    - Plugin now fires the "give_weapon" and "weapon_given" events. Requested by "NoroHime".

[Krufftys Killers]

After the update started getting an error

L 03/01/2022 - 20:41:56: Error log file session closed.
L 03/01/2022 - 20:43:46: SourceMod error session started
L 03/01/2022 - 20:43:46: Info (map "rocketbuild1") (file "C:\servers\kruffty\left4dead2\addons\sou rcem od\logs\errors_20220301.log")
L 03/01/2022 - 20:43:46: [SM] Exception reported: Invalid game event handle 0 (error 4)
L 03/01/2022 - 20:43:46: [SM] Blaming: l4d_gear_transfer.smx
L 03/01/2022 - 20:43:46: [SM] Call stack trace:
L 03/01/2022 - 20:43:46: [SM] [0] Event.SetInt
L 03/01/2022 - 20:43:46: [SM] [1] Line 2197, /home/forums/content/files/8/5/7/7/8/191210.attach::FireEventsGeneral
L 03/01/2022 - 20:43:46: [SM] [2] Line 1535, /home/forums/content/files/8/5/7/7/8/191210.attach::GiveItem
L 03/01/2022 - 20:43:46: [SM] [3] Line 1827, /home/forums/content/files/8/5/7/7/8/191210.attach::TimerAutoGive

[Silvers]

Thanks, should be fixed.

[Zheldorg]

Originally Posted by Silvers Sorry I don't understand what should be changed. Can you clarify. The non-test version you posted is identical to the last release and the test version only has debug prints.

I'm sorry, I don't understand how I do it, I attached the wrong file, now I've updated it.

[ZzZombo]

Could the bots pick items up ONLY naturally, w/o them magically appearing in their possession? I have seen them actually pick grenades and stuff they do not pick on their own by issuing the use command on many occasions, and I like that so much over the forced solution.

[Silvers]

Originally Posted by ZzZombo Could the bots pick items up ONLY naturally, w/o them magically appearing in their possession? I have seen them actually pick grenades and stuff they do not pick on their own by issuing the use command on many occasions, and I like that so much over the forced solution.

If you want to code it in I'll add to the main plugin. Reason I didn't do it like that is you would have to force them to walk to the grenade/items to pick up, because most of the time they wouldn't be close enough and walk past it, either using VScript to command a bot to that position (won't support L4D1) or L4D2_OnFindScavengeItem which would require Left4DHooks. Neither of which is something I really want to do.