[Psyk0tik]

Originally Posted by Peace-Maker The probem here is that both Functions sections are named the same, the arguments aren't important. All "Functions" sections in all loaded gamedata files are cached together due to a limitation in SourceMod's gamedata parser extension api. So the first plugin creates an entry in that cache with the name "CTerrorPlayer::StartReviving" and the given argument setup. When the second plugin loads its gamedata file, the "CTerrorPlayer::StartReviving" function is already present in the cache, so dhooks thinks you want to update the entry. It adds the "new" argument to the setup, since it's named differently, making the function look like it takes two arguments. This behavior is described in the release post in the "Game specific settings" section. It allows you to change details of a hook per game, if the rest is mostly the same.

Ohhh, that makes sense! I wasn't aware that the behavior described in that section applied across multiple gamedata files. This statement at the end of that section makes it seem like updating entries only works within the same file: "Later sections in the file add to the already parsed setup."

Originally Posted by Peace-Maker The idea was to avoid duplicate function hook info in the gamedata file, which appears to have been a stupid one. Sorry, but I think it's too late now to change the behavior - I'm not even sure what the right thing would be :D

I'm not sure either. It seems fine to leave it this way now that I understand the behavior.

Originally Posted by Peace-Maker I could add a server command which dumps all active detours and the plugins which are listening for them. It might be useless for detours and hooks created using the API instead of the "Functions" section though, since there is no name associated with the hook. But maybe we could print other relevant info which helps to identify which function is being hooked.

Sounds good. I haven't tried to create detours/hooks using the API yet, so I wouldn't know what other relevant info could even be made available with that potential command.

[Peace-Maker]

Dhooks itself doesn't do anything game specific that could break after an update. The plugins probably need updated gamedata.

[MAGNAT2645]

Originally Posted by Peace-Maker Dhooks itself doesn't do anything game specific that could break after an update. The plugins probably need updated gamedata.

Yeah, i didn't say that DHooks caused these crashes. Tried to update gamedata manually but idk which is outdated (used VTable Dumper to check but it seems that every gamedata config has up to date offsets, not sure about signatures though. Do Linux signatures change often like Windows' do?).

EDIT: VTable prints 264 and 265 offsets

L	W	Function
265	264	CBasePlayer::Weapon_Equip(CBaseCombatWeapon*)

but SM gamedata has this

			"WeaponEquip"
			{
				"windows"	"265"
				"linux"		"266"
				"mac"		"266"
			}

EDIT 2: OK, it seems that Hit Registration Fix Plugin had outdated offsets. Increased them by 1.

[Peace-Maker]

I've released a new version which includes a bunch of stability improvements thanks to the awesome crash reports by the community! Grab detours17 from the release post or github releases.


Changelog:

• Allow returning NULL for CBaseEntity return types by setting the return value to -1 (thanks arthurdead)
• Allow specifying object argument size in hexadecimal in gamedata similar to SM 1.11
• Fix SourceHook context leak when superceding virtual hooked functions (thanks nosoop and BotoX Drifter321#2)
  • This fixes a long standing issue with memory leaks, crashes and lag on map change
• Fix crash on CentOS7+ / SELinux with "allow_execheap" disabled (thanks vintagepc #22)
• Fix DHookIsNullParam checking wrong parameter for detour setups with parameters passed in custom registers (thanks GAMMACASE #15)
• Fix crash due to mismatching new[] + delete[] pair of return value buffer (thanks bottiger)

[jking]

Hi Peace, first off thanks so much for this update, I fired up the game for first time in many months and get this error for first time,

L 08/10/2021 - 21:14:02: SourceMod error session started
L 08/10/2021 - 21:14:02: Info (map "c5m1_waterfront") (file "C:\L4D2\left4dead2\addons\sourcemod\logs\errors_20210810.log")
L 08/10/2021 - 21:14:02: [left4dhooks.smx] Failed to find signature: ForceNextStage
L 08/10/2021 - 21:14:02: [left4dhooks.smx] Failed to find signature: CancelStagger
L 08/10/2021 - 21:14:02: [left4dhooks.smx] Failed to find signature: RegisterForbiddenTarget
L 08/10/2021 - 21:14:02: [left4dhooks.smx] Failed to find signature: UnRegisterForbiddenTarget
L 08/10/2021 - 21:14:02: [left4dhooks.smx] Failed to load "UseHealingItems" signature.
L 08/10/2021 - 21:14:08: Error log file session closed.

[Psyk0tik]

Originally Posted by jking Hi Peace, first off thanks so much for this update, I fired up the game for first time in many months and get this error for first time, L 08/10/2021 - 21:14:02: SourceMod error session started L 08/10/2021 - 21:14:02: Info (map "c5m1_waterfront") (file "C:\L4D2\left4dead2\addons\sourcemod\logs\errors_20210810.log") L 08/10/2021 - 21:14:02: [left4dhooks.smx] Failed to find signature: ForceNextStage L 08/10/2021 - 21:14:02: [left4dhooks.smx] Failed to find signature: CancelStagger L 08/10/2021 - 21:14:02: [left4dhooks.smx] Failed to find signature: RegisterForbiddenTarget L 08/10/2021 - 21:14:02: [left4dhooks.smx] Failed to find signature: UnRegisterForbiddenTarget L 08/10/2021 - 21:14:02: [left4dhooks.smx] Failed to load "UseHealingItems" signature. L 08/10/2021 - 21:14:08: Error log file session closed.

DHooks has nothing to do with those errors. Read the errors carefully as they clearly tell you which plugin they're coming from. There have been a few L4D2 updates so far this year that broke a lot of signatures.

[jking]

Originally Posted by Psyk0tik DHooks has nothing to do with those errors. Read the errors carefully as they clearly tell you which plugin they're coming from. There have been a few L4D2 updates so far this year that broke a lot of signatures.

Man I'm dumb, last night late, like I said I hadn't played in months and just before I had quit then, I just started to use Silvers Left 4 DHooks Direct (1.51),now all is well with his new version, thanks again as always to all of you that make our experience more pleasant.

[Levchik97]

Please update Gamedata

[asherkin]

Originally Posted by Levchik97 Please update Gamedata

DHooks doesn't have any gamedata - you need to look at the plugins you have using DHooks.

[Levchik97]

Originally Posted by asherkin DHooks doesn't have any gamedata - you need to look at the plugins you have using DHooks.

ok, thanks