Raised This Month: $12 Target: $400
 3% 

C4 Taker


Post New Thread Reply   
 
Thread Tools Display Modes
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 06-20-2016 , 04:21   Re: C4 Taker - joaquimandrade & ConnorMcLeod
Reply With Quote #21

Ask me what you didn't understand.
__________________
HamletEagle is offline
hellmonja
Senior Member
Join Date: Oct 2015
Old 06-21-2016 , 11:55   Re: C4 Taker - joaquimandrade & ConnorMcLeod
Reply With Quote #22

Quote:
Originally Posted by HamletEagle View Post
Ask me what you didn't understand.
Sorry for the late reply. I've been busy.

OK, I've re-read the list you gave me and I think I understood it a bit more and would like to take crack at it first. I'm expecting road blocks along the way so I'm sure I'll be asking you for some coding help. I just need some time to concentrate, work leaves exhausted at night and it's at night I can do most of my coding coz the kids are already asleep...

PS: Is it ok if I double post for updates? I mean so you guys would notice immediately?...
hellmonja is offline
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 06-21-2016 , 12:18   Re: C4 Taker - joaquimandrade & ConnorMcLeod
Reply With Quote #23

Yeah, for me it is okay. You can PM me anyway in case I don't see your post.
__________________
HamletEagle is offline
hellmonja
Senior Member
Join Date: Oct 2015
Old 06-24-2016 , 15:34   Re: C4 Taker - joaquimandrade & ConnorMcLeod
Reply With Quote #24

UPDATE v1.06
  • Code optimization.
Thanks to HamletEagle...
__________________
hellmonja is offline
hellmonja
Senior Member
Join Date: Oct 2015
Old 06-25-2016 , 08:47   Re: C4 Taker
Reply With Quote #25

UPDATE v1.07
  • Code consistency. Courtesy for those wanting to learn the script.
__________________

Last edited by hellmonja; 06-25-2016 at 11:56.
hellmonja is offline
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 06-25-2016 , 09:30   Re: C4 Taker
Reply With Quote #26

Hope that's the last thing to change:
1.Also be consistent with semicolons(;), use them everywhere or don't use them at all.
2.In EventStatusValue_PlayerID shouldn't you add if(!is_user_admin(id) && get_pcvar_num(admin_only) >= 1) check too?
3.
PHP Code:
if(idAim && (get_user_team(id) == get_user_team(idAim)) && user_has_weapon(idAimCSW_C4)) 
no longer needed to check if(idAnim) because you know user is alive, so connected.
4.Try to keep all the hooks in the order that you registered them.

That's all I have to say. Fix this and you know, approved.
__________________

Last edited by HamletEagle; 06-25-2016 at 09:36.
HamletEagle is offline
hellmonja
Senior Member
Join Date: Oct 2015
Old 06-25-2016 , 11:12   Re: C4 Taker
Reply With Quote #27

Done. Whew! That was a lot of semicolons I missed. I'll try to be careful next time.

Oh and--
Quote:
Originally Posted by HamletEagle View Post
4.Try to keep all the hooks in the order that you registered them.
I do apologize but I don't quite understand. I did, however, took the liberty of arranging these:
PHP Code:
    register_plugin(pluginversionauthor);
    
register_logevent("Bomb_Carrier_Spawned"3"2=Spawned_With_The_Bomb");
    
register_event("StatusValue""EventStatusValue_PlayerID""b""1=2""2>0");
    
register_event("StatusValue""Event_StatusValue_Hide""be""1=1""2=0");
    
RegisterHam(Ham_ObjectCaps"player""Use_Button"); 
Is that what you meant? I'm really sorry I'm still trying to get a hang on all the terminologies...
__________________
hellmonja is offline
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 06-25-2016 , 13:14   Re: C4 Taker
Reply With Quote #28

Yeah, this is what I mean. You forgot to upload the new version?
__________________
HamletEagle is offline
hellmonja
Senior Member
Join Date: Oct 2015
Old 06-25-2016 , 13:16   Re: C4 Taker
Reply With Quote #29

UPDATE v1.08
  • More optimization
  • A few more inconsistencies fixed

Quote:
Originally Posted by HamletEagle View Post
Yeah, this is what I mean. You forgot to upload the new version?
Nah. I was waiting for verification. Don't want to get this thread too messy with all the updates...
__________________

Last edited by hellmonja; 06-25-2016 at 13:21.
hellmonja is offline
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 06-25-2016 , 13:21   Re: C4 Taker
Reply With Quote #30

Everything looks ok.
Approved.
__________________
HamletEagle is offline
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 16:00.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode