[Solved] Loop order

edon1337 · **Author**

Hey,

I've been trying to fix these bugs for days now, but they still occur..
There's 2 bugs in this plugin, as for now:

1) I've put ReadFile() at the top of the code, but Prefix still doesn't change, but flags do, it's so weird, so if my current prefix in the .ini file is 'Prefix1', and I change it to 'Prefix2', it still will display 'Prefix1' in say chat.
As I've put ReadFile() at the top, it logically should update everything, but prefix only gets updated when map changes. I think the loop order overrides the updated prefix and replaces it with the old one.. The problem occurs in the task named OnTaskCheckStealAdmin() (I've already left a comment there).

PHP Code:


			
#define TASK_CHECK_STEAL 1.0



enum _:PlayerData

{

    Player_Name[ 32 ],

    Player_Password[ 18 ],

    Player_AccessFlags[ 32 ],

    Player_Prefix[ 24 ]

}



new g_iItems[ PlayerData ];

new Array:g_aDatabase;

new const g_szFile[ ] = "AccountUsers.ini";



public plugin_init( )

{    

    g_aDatabase = ArrayCreate( PlayerData );

    

    register_clcmd( "say", "OnHookSay" );

    register_clcmd( "say_team", "OnHookSay" );

    

    set_task( TASK_CHECK_STEAL, "OnTaskCheckStealAdmin", _, _, _, "b" );

    

    ReadFile( );

}



public OnTaskCheckStealAdmin( ) // the part of the code that bugs

{

    ReadFile( ); // I've added ReadFile but it isn't updating the prefix



    new szPlayers[ 32 ], iNum, szName[ 32 ], szAuthID[ 32 ], szPassword[ 18 ];

    get_players( szPlayers, iNum );

    

    static iTempID;



    new iArraySize = ArraySize( g_aDatabase );



    for( new i; i < iNum; i++ )

    {

        iTempID = szPlayers[ i ];



        for( new iIndex=0; iIndex < iArraySize; iIndex++ )

        {

            ArrayGetArray( g_aDatabase, iIndex, g_iItems );

            

            get_user_info( iTempID, "name", szName, charsmax( szName ) );

            get_user_authid( iTempID, szAuthID, charsmax( szAuthID ) );

            get_user_info( iTempID, "_pw", szPassword, charsmax( szPassword ) );

            

            if( equal( g_iItems[ Player_Name ], szName ) || equal( g_iItems[ Player_Name ], szAuthID ) )

            {

                if( ! g_iItems[ Player_Password ][ 0 ] || equal( g_iItems[ Player_Password ], szPassword ) )

                {

                    remove_user_flags( iTempID );

                    set_user_flags( iTempID, read_flags( g_iItems[ Player_AccessFlags ] ) );

                }

                

                else if( ! equal( g_iItems[ Player_Password ], szPassword ) )

                {

                    remove_user_flags( iTempID );

                    server_cmd( "kick #%d ^"KICKED: you have no entry to this server^"", get_user_userid( iTempID ) );

                }

            }

        }

    }

}



public OnHookSay( id )

{

    ReadFile( );



    new iArraySize = ArraySize( g_aDatabase );

    new szArgs[ 192 ], szName[ 32 ], szAuthID[ 32 ], szPassword[ 18 ];

    

    for( new iIndex; iIndex < iArraySize; iIndex++ )

    {

        ArrayGetArray( g_aDatabase, iIndex, g_iItems );

        

        read_args( szArgs, charsmax( szArgs ) );

        remove_quotes( szArgs );

        

        get_user_info( id, "name", szName, charsmax( szName ) );

        get_user_authid( id, szAuthID, charsmax( szAuthID ) );

        get_user_info( id, "_pw", szPassword, charsmax( szPassword ) );

        

        if( equal( g_iItems[ Player_Name ], szName ) || equal( g_iItems[ Player_Name ], szAuthID ) )

        {

            if( ! g_iItems[ Player_Password ][ 0 ] || equal( g_iItems[ Player_Password ], szPassword ) )

            {

                if( szPlayerPrefix[ id ][ 0 ] )

                {

                    if( is_user_alive( id ) )

                    {

                        client_print_color( 0, DontChange, "^4%s ^3%s^1: ^4%s", szPlayerPrefix[ id ][ 0 ], szName, szArgs );                        

                        return PLUGIN_HANDLED_MAIN;

                    }

                    

                    else

                    {

                        client_print_color( 0, DontChange, "^1*DEAD* ^4%s ^3%s^1: ^4%s", szPlayerPrefix[ id ][ 0 ], szName, szArgs );

                        return PLUGIN_HANDLED_MAIN;

                    }

                }

                

                else

                return PLUGIN_CONTINUE;

            }

        }

    }

    return PLUGIN_CONTINUE;

}



ReadFile( )

{

    new szConfigs[ 32 ], szFormat[ 64 ], szPlayerData[ 512 ], szName[ 32 ], szPassword[ 18 ], szAccessFlags[ 25 ], szPrefix[ 24 ];

    get_configsdir( szConfigs, charsmax( szConfigs ) );

    

    formatex( szFormat, charsmax( szFormat ), "%s/%s", szConfigs, g_szFile );

    

    new iFile = fopen( szFormat, "r" );

    

    if( iFile )

    {

        while( ! feof( iFile ) )

        {    

            fgets( iFile, szPlayerData, charsmax( szPlayerData ) );

            trim( szPlayerData );

            

            if( szPlayerData[ 0 ] == ';' || ( szPlayerData[ 0 ] == '/' && szPlayerData[ 1 ] == '/' ) )

            continue;

            

            parse( szPlayerData, szName, charsmax( szName ), szPassword, charsmax( szPassword ), szAccessFlags, charsmax( szAccessFlags ), szPrefix, charsmax( szPrefix ) );

            

            g_iItems[ Player_Name ] = szName;

            g_iItems[ Player_Password ] = szPassword;

            g_iItems[ Player_AccessFlags ] = szAccessFlags;

            g_iItems[ Player_Prefix ] = szPrefix;

            

            ArrayPushArray( g_aDatabase, g_iItems );

        }

        fclose( iFile );

    }

}

I created a temporary fix by storing the prefix into a 2nd variable, but it isn't the best way..
It works properly, but isn't the best way. Any ideas why this is happening?

PHP Code:


			
#define TASK_CHECK_STEAL 1.0



enum _:PlayerData

{

    Player_Name[ 32 ],

    Player_Password[ 18 ],

    Player_AccessFlags[ 32 ],

    Player_Prefix[ 24 ]

}



new szPlayerPrefix[ 33 ][ 24 ]; // bugfix v1.2

new g_iItems[ PlayerData ];

new Array:g_aDatabase;

new const g_szFile[ ] = "AccountUsers.ini";



public plugin_init( )

{    

    g_aDatabase = ArrayCreate( PlayerData );

    

    register_clcmd( "say", "OnHookSay" );

    register_clcmd( "say_team", "OnHookSay" );

    

    set_task( TASK_CHECK_STEAL, "OnTaskCheckStealAdmin", _, _, _, "b" );

    

    ReadFile( );

}



public client_connect( id )

FreeString( szPlayerPrefix[ id ] );



public OnTaskCheckStealAdmin( )

{

    ReadFile( );



    new szPlayers[ 32 ], iNum, szName[ 32 ], szAuthID[ 32 ], szPassword[ 18 ];

    get_players( szPlayers, iNum );

    

    static iTempID;



    new iArraySize = ArraySize( g_aDatabase );



    for( new i; i < iNum; i++ )

    {

        iTempID = szPlayers[ i ];



        for( new iIndex=0; iIndex < iArraySize; iIndex++ )

        {

            ArrayGetArray( g_aDatabase, iIndex, g_iItems );

            

            get_user_info( iTempID, "name", szName, charsmax( szName ) );

            get_user_authid( iTempID, szAuthID, charsmax( szAuthID ) );

            get_user_info( iTempID, "_pw", szPassword, charsmax( szPassword ) );

            

            if( equal( g_iItems[ Player_Name ], szName ) || equal( g_iItems[ Player_Name ], szAuthID ) )

            {

                if( ! g_iItems[ Player_Password ][ 0 ] || equal( g_iItems[ Player_Password ], szPassword ) )

                {

                    remove_user_flags( iTempID );

                    set_user_flags( iTempID, read_flags( g_iItems[ Player_AccessFlags ] ) );

                                        

                    if( ! equal( szPlayerPrefix[ iTempID ], g_iItems[ Player_Prefix ] ) )

                    {

                        copy( szPlayerPrefix[ iTempID ], charsmax( szPlayerPrefix[ ] ), g_iItems[ Player_Prefix ] );

                        continue;

                    }

                }

                

                else if( ! equal( g_iItems[ Player_Password ], szPassword ) )

                {

                    remove_user_flags( iTempID );

                    server_cmd( "kick #%d ^"KICKED: you have no entry to this server^"", get_user_userid( iTempID ) );

                }

            }

        }

    }

}



public OnHookSay( id )

{

    ReadFile( );



    new iArraySize = ArraySize( g_aDatabase );

    new szArgs[ 192 ], szName[ 32 ], szAuthID[ 32 ], szPassword[ 18 ];

    

    for( new iIndex; iIndex < iArraySize; iIndex++ )

    {

        ArrayGetArray( g_aDatabase, iIndex, g_iItems );

        

        read_args( szArgs, charsmax( szArgs ) );

        remove_quotes( szArgs );

        

        get_user_info( id, "name", szName, charsmax( szName ) );

        get_user_authid( id, szAuthID, charsmax( szAuthID ) );

        get_user_info( id, "_pw", szPassword, charsmax( szPassword ) );

        

        if( equal( g_iItems[ Player_Name ], szName ) || equal( g_iItems[ Player_Name ], szAuthID ) )

        {

            if( ! g_iItems[ Player_Password ][ 0 ] || equal( g_iItems[ Player_Password ], szPassword ) )

            {

                if( szPlayerPrefix[ id ][ 0 ] )

                {

                    if( is_user_alive( id ) )

                    {

                        client_print_color( 0, DontChange, "^4%s ^3%s^1: ^4%s", szPlayerPrefix[ id ][ 0 ], szName, szArgs );                        

                        return PLUGIN_HANDLED_MAIN;

                    }

                    

                    else

                    {

                        client_print_color( 0, DontChange, "^1*DEAD* ^4%s ^3%s^1: ^4%s", szPlayerPrefix[ id ][ 0 ], szName, szArgs );

                        return PLUGIN_HANDLED_MAIN;

                    }

                }

                

                else

                return PLUGIN_CONTINUE;

            }

        }

    }

    return PLUGIN_CONTINUE;

}



ReadFile( )

{

    new szConfigs[ 32 ], szFormat[ 64 ], szPlayerData[ 512 ], szName[ 32 ], szPassword[ 18 ], szAccessFlags[ 25 ], szPrefix[ 24 ];

    get_configsdir( szConfigs, charsmax( szConfigs ) );

    

    formatex( szFormat, charsmax( szFormat ), "%s/%s", szConfigs, g_szFile );

    

    new iFile = fopen( szFormat, "r" );

    

    if( iFile )

    {

        while( ! feof( iFile ) )

        {    

            fgets( iFile, szPlayerData, charsmax( szPlayerData ) );

            trim( szPlayerData );

            

            if( szPlayerData[ 0 ] == ';' || ( szPlayerData[ 0 ] == '/' && szPlayerData[ 1 ] == '/' ) )

            continue;

            

            parse( szPlayerData, szName, charsmax( szName ), szPassword, charsmax( szPassword ), szAccessFlags, charsmax( szAccessFlags ), szPrefix, charsmax( szPrefix ) );

            

            g_iItems[ Player_Name ] = szName;

            g_iItems[ Player_Password ] = szPassword;

            g_iItems[ Player_AccessFlags ] = szAccessFlags;

            g_iItems[ Player_Prefix ] = szPrefix;

            

            ArrayPushArray( g_aDatabase, g_iItems );

        }

        fclose( iFile );

    }

}



FreeString( szString[ ] )

{

    for( new i; i < strlen( szString ); i++ )

    {

        szString[ i ] = EOS;

    }

    return 1;

}

2) This is my .ini file format

Quote:

"myname" "mypassword" "myflags" "myprefix"

So it actually is like this:

Quote:

"Edon" "123456" "abcdefghijklmnopqrstu" "[Owner]"

And now, I change my password (notice it's 1-5 not 1-6).

Quote:

"Edon" "12345" "abcdefghijklmnopqrstu" "[Owner]"

So basically it keeps trying to kick me (as I'm testing on a listenserver, it can't kick me), that's ok, but, when I change my password to what it is in the .ini (1-5), even though my password is the same as the one in the .ini file, it still keeps kicking me, I made some debugs, and it appears that it executes both parts of the code, the one that should get executed when your password is the same as the one in the .ini file and the part which kicks you on invalid password.

Thanks!

**Bugsy** · 01-14-2018 , 19:05 Re: Loop order

I would do a step by step debug. You have a good understanding of the process your plugin takes to do things. At each step I would put a print and you can then determine which code is getting reached when it shouldn't or vice versa. Also a good idea to check values in these prints as well.

Clauu · 01-14-2018 , 19:37 Re: Loop order

Since you're using global vars, you should empty them before reading again
g_iItems[ index ][0]=0
Same thing for the array g_aDatabase, it should be emptied too before adding new entries.
g_iItems[ Player_Name ] = szName // you shouldn't do this, use copy or format(ex) or better parse directly in to g_iItems[ index ]
And instead of iterating through each char szString[ i ] = EOS, use directly szString[ 0 ] = 0
And also as a thing of optimization i don't think that it's a good ideea to parse files in chat hook, set_task is enough for this job

Natsheh · 01-15-2018 , 06:33 Re: Loop order

You forgot to remove the quotes from szName, etc...

And check if the line you retrieved is greater than 5 characters

Also use this use this for freeingthestring

#define FreeString(%1) %1[0]=EOS

edon1337 · 01-15-2018 , 08:25 Re: Loop order

Quote:

Originally Posted by Bugsy

I would do a step by step debug. You have a good understanding of the process your plugin takes to do things. At each step I would put a print and you can then determine which code is getting reached when it shouldn't or vice versa. Also a good idea to check values in these prints as well.

Debug with a 10 second delay, if you wanna test it, here's the code, just stay with 0.x second delay to see the real bug. With the 10 second delay, you can barely notice it.
First of all, put a new entry in the .ini file with your information, second, when you're in-game, change the password in .ini file then change it in-game just like it is in the .ini, it still will keep kicking you. Make sure to disable admin.amxx.

PHP Code:


			
[The part that works correctly]
L 01/15/2018 - 14:11:58: #1 Called | Player_Name: DoNii | szName: DoNii | Player_Password: kenshi77 | szPassword: kenshi77 |
L 01/15/2018 - 14:11:58: #2 Called | Player_Name: DoNii | szName: DoNii | Player_Password: kenshi77 | szPassword: kenshi77 |
L 01/15/2018 - 14:11:58: #3 Called | Player_Name: DoNii | szName: DoNii | Player_Password: kenshi77 | szPassword: kenshi77 |
L 01/15/2018 - 14:11:58: #1 Called | Player_Name: DoNii | szName: DoNii | Player_Password: kenshi77 | szPassword: kenshi77 |
L 01/15/2018 - 14:11:58: #3 Called | Player_Name: DoNii | szName: DoNii | Player_Password: kenshi77 | szPassword: kenshi77 |

[The part that also works correctly, I changed my setinfo _pw]
L 01/15/2018 - 14:12:09: #1 Called | Player_Name: DoNii | szName: DoNii | Player_Password: kenshi77 | szPassword: kenshi77 |
L 01/15/2018 - 14:12:09: #3 Called | Player_Name: DoNii | szName: DoNii | Player_Password: kenshi77 | szPassword: kenshi77 |
L 01/15/2018 - 14:12:09: #1 Called | Player_Name: DoNii | szName: DoNii | Player_Password: kenshi77 | szPassword: kenshi77 |
L 01/15/2018 - 14:12:09: #3 Called | Player_Name: DoNii | szName: DoNii | Player_Password: kenshi77 | szPassword: kenshi77 |
L 01/15/2018 - 14:12:09: #4 Called | Player_Name: DoNii | szName: DoNii | Player_Password: kenshi7 | szPassword: kenshi77 |

[The part that bugs, my setinfo = kenshi7 | my pw in .ini = kenshi7 , but Player_Password hasn't changed]
L 01/15/2018 - 14:12:19: #4 Called | Player_Name: DoNii | szName: DoNii | Player_Password: kenshi77 | szPassword: kenshi7 |
L 01/15/2018 - 14:12:19: #4 Called | Player_Name: DoNii | szName: DoNii | Player_Password: kenshi77 | szPassword: kenshi7 |
L 01/15/2018 - 14:12:19: #1 Called | Player_Name: DoNii | szName: DoNii | Player_Password: kenshi7 | szPassword: kenshi7 |
L 01/15/2018 - 14:12:19: #3 Called | Player_Name: DoNii | szName: DoNii | Player_Password: kenshi7 | szPassword: kenshi7 |
L 01/15/2018 - 14:12:19: #1 Called | Player_Name: DoNii | szName: DoNii | Player_Password: kenshi7 | szPassword: kenshi7 |
L 01/15/2018 - 14:12:19: #3 Called | Player_Name: DoNii | szName: DoNii | Player_Password: kenshi7 | szPassword: kenshi7 |

Code:

PHP Code:


			
#include < amxmodx >
#include < amxmisc >
#include < colorchat >

#define PLUGIN_AUTHOR "DoNii"
#define PLUGIN_VERSION "1.2"
#define PLUGIN_NAME "New Admin System"

#define TASK_CHECK_STEAL 0.3

#define ADMIN_ADD_FLAG ADMIN_RCON

enum _:PlayerData
{
    Player_Name[ 32 ],
    Player_Password[ 18 ],
    Player_AccessFlags[ 32 ],
    Player_Prefix[ 24 ]
}

new szPlayerPrefix[ 33 ][ 24 ]; // bugfix v1.2
new g_iItems[ PlayerData ];
new Array:g_aDatabase;
new const g_szFile[ ] = "AccountUsers.ini";

public plugin_init( )
{
    register_plugin( PLUGIN_NAME, PLUGIN_VERSION, PLUGIN_AUTHOR );
    
    register_concmd( "amx_addadmin", "OnAddNewAdmin" );
    
    g_aDatabase = ArrayCreate( PlayerData );
    
    register_clcmd( "say", "OnHookSay" );
    register_clcmd( "say_team", "OnHookSay" );
    
    set_task( TASK_CHECK_STEAL, "OnTaskCheckStealAdmin", _, _, _, "b" );
    
    ReadFile( );
}

public client_connect( id )
FreeString( szPlayerPrefix[ id ] );

public OnAddNewAdmin( id )
{
    if( ~ get_user_flags( id ) & ADMIN_ADD_FLAG )
    {
        client_print( id, print_console, "You have no Access to this command" );
        return PLUGIN_HANDLED;
    }

    if( read_argc( ) != 5 )
    {
        client_print( id, print_console, "Usage is : amx_addadmin <Nick|SteamID> <Password> <Flags> <Prefix>" );
        return PLUGIN_HANDLED;
    }

    new szAdminName[ 32 ], szAdminPassword[ 18 ], szAdminFlags[ 32 ], szAdminPrefix[ 18 ];
    
    read_argv( 1, szAdminName, charsmax( szAdminName ) );
    read_argv( 2, szAdminPassword, charsmax( szAdminPassword ) );
    read_argv( 3, szAdminFlags, charsmax( szAdminFlags ) );
    read_argv( 4, szAdminPrefix, charsmax( szAdminPrefix ) );
    
    if( ( strlen( szAdminName ) < 3 ) || ( strlen( szAdminFlags ) < 1 ) )
    {
        client_print( id, print_console, "ERROR: Incorrect Format of Admin" );
        return PLUGIN_HANDLED;
    }
    
    new szConfigs[ 64 ], szFormat[ 128 ];
    get_configsdir( szConfigs, charsmax( szConfigs ) );
    
    formatex( szFormat, charsmax( szFormat ), "%s/%s", szConfigs, g_szFile );
    new iFile = fopen( szFormat, "r+" ); 

    new szByteVal[ 1 ], szNewLine[ 256 ]; 
    
    fseek( iFile , -1 , SEEK_END ); 
    
    fread_raw( iFile , szByteVal , sizeof( szByteVal ) , BLOCK_BYTE ); 
    
    fseek( iFile , 0 , SEEK_END ); 
    
    formatex( szNewLine , charsmax( szNewLine ) , "%s^"%s^" ^"%s^" ^"%s^" ^"%s^"" , ( szByteVal[ 0 ] == 10 ) ? "" : "^n", szAdminName, szAdminPassword, szAdminFlags, szAdminPrefix ); 

    fprintf( iFile, szNewLine );
    fclose( iFile );  
    
    client_print( id, print_console, "Successfully Added New Admin: Name: %s | Password: %s | Flags: %s | Prefix: %s |", szAdminName, szAdminPassword, szAdminFlags, szAdminPrefix );
    return PLUGIN_CONTINUE;
}

public OnTaskCheckStealAdmin( )
{
    ReadFile( );

    new szPlayers[ 32 ], iNum, szName[ 32 ], szAuthID[ 32 ], szPassword[ 18 ];
    get_players( szPlayers, iNum );
    
    static iTempID;

    new iArraySize = ArraySize( g_aDatabase );

    for( new i; i < iNum; i++ )
    {
        iTempID = szPlayers[ i ];

        for( new iIndex; iIndex < iArraySize; iIndex++ )
        {
            ArrayGetArray( g_aDatabase, iIndex, g_iItems );
            
            get_user_info( iTempID, "name", szName, charsmax( szName ) );
            get_user_authid( iTempID, szAuthID, charsmax( szAuthID ) );
            get_user_info( iTempID, "_pw", szPassword, charsmax( szPassword ) );
            
            if( equal( g_iItems[ Player_Name ], szName ) || equal( g_iItems[ Player_Name ], szAuthID ) )
            {
                if( ! g_iItems[ Player_Password ][ 0 ] || equal( g_iItems[ Player_Password ], szPassword ) )
                {
                    remove_user_flags( iTempID );
                    set_user_flags( iTempID, read_flags( g_iItems[ Player_AccessFlags ] ) );
                    
                    log_to_file( "DebugTest.txt", "#1 Called | Player_Name: %s | szName: %s | Player_Password: %s | szPassword: %s |", g_iItems[ Player_Name ], szName, g_iItems[ Player_Password ], szPassword );
                    
                    if( ! equal( szPlayerPrefix[ iTempID ], g_iItems[ Player_Prefix ] ) )
                    {
                        copy( szPlayerPrefix[ iTempID ], charsmax( szPlayerPrefix[ ] ), g_iItems[ Player_Prefix ] );
                        log_to_file( "DebugTest.txt", "#2 Called | Player_Name: %s | szName: %s | Player_Password: %s | szPassword: %s |", g_iItems[ Player_Name ], szName, g_iItems[ Player_Password ], szPassword );
                    }
                    
                    log_to_file( "DebugTest.txt", "#3 Called | Player_Name: %s | szName: %s | Player_Password: %s | szPassword: %s |", g_iItems[ Player_Name ], szName, g_iItems[ Player_Password ], szPassword );
                }
                
                else if( ! equal( g_iItems[ Player_Password ], szPassword ) )
                {
                    remove_user_flags( iTempID );
                    server_cmd( "kick #%d ^"KICKED: you have no entry to this server^"", get_user_userid( iTempID ) );
                    
                    log_to_file( "DebugTest.txt", "#4 Called | Player_Name: %s | szName: %s | Player_Password: %s | szPassword: %s |", g_iItems[ Player_Name ], szName, g_iItems[ Player_Password ], szPassword );
                }
            }
        }
    }
}

public client_infochanged( id )
{
    new szOldName[ 32 ], szNewName[ 32 ];
    get_user_name( id, szOldName, charsmax( szOldName ) );
    get_user_info( id, "name", szNewName, charsmax( szNewName ) );

    if( ! equal( szOldName, szNewName ) )
    remove_user_flags( id );
}    

public client_authorized( id )
{
    new iArraySize = ArraySize( g_aDatabase );
    new szName[ 32 ], szAuthID[ 32 ], szPassword[ 18 ];
    
    for( new iIndex; iIndex < iArraySize; iIndex++ )
    {
        ArrayGetArray( g_aDatabase, iIndex, g_iItems );
        
        get_user_info( id, "name", szName, charsmax( szName ) );
        get_user_authid( id, szAuthID, charsmax( szAuthID ) );
        get_user_info( id, "_pw", szPassword, charsmax( szPassword ) );
        
        if( equal( g_iItems[ Player_Name ], szName ) || equal( g_iItems[ Player_Name ], szAuthID ) )
        {
            if( ! g_iItems[ Player_Password ][ 0 ] || equal( g_iItems[ Player_Password ], szPassword ) )
            {                
                remove_user_flags( id );
                set_user_flags( id, read_flags( g_iItems[ Player_AccessFlags ] ) );
            }
            
            else
            {            
                server_cmd( "kick #%d ^"KICKED: you have no entry to this server^"", get_user_userid( id ) );
            }
        }
    }
    return PLUGIN_CONTINUE;
}

public OnHookSay( id )
{
    ReadFile( );

    new iArraySize = ArraySize( g_aDatabase );
    new szArgs[ 192 ], szName[ 32 ], szAuthID[ 32 ], szPassword[ 18 ];
    
    for( new iIndex; iIndex < iArraySize; iIndex++ )
    {
        ArrayGetArray( g_aDatabase, iIndex, g_iItems );
        
        read_args( szArgs, charsmax( szArgs ) );
        remove_quotes( szArgs );
        
        get_user_info( id, "name", szName, charsmax( szName ) );
        get_user_authid( id, szAuthID, charsmax( szAuthID ) );
        get_user_info( id, "_pw", szPassword, charsmax( szPassword ) );
        
        if( equal( g_iItems[ Player_Name ], szName ) || equal( g_iItems[ Player_Name ], szAuthID ) )
        {
            if( ! g_iItems[ Player_Password ][ 0 ] || equal( g_iItems[ Player_Password ], szPassword ) )
            {
                if( szPlayerPrefix[ id ][ 0 ] )
                {
                    if( is_user_alive( id ) )
                    {
                        client_print_color( 0, DontChange, "^4%s ^3%s^1: ^4%s", szPlayerPrefix[ id ][ 0 ], szName, szArgs );                        
                        return PLUGIN_HANDLED_MAIN;
                    }
                    
                    else
                    {
                        client_print_color( 0, DontChange, "^1*DEAD* ^4%s ^3%s^1: ^4%s", szPlayerPrefix[ id ][ 0 ], szName, szArgs );
                        return PLUGIN_HANDLED_MAIN;
                    }
                }
                
                else
                return PLUGIN_CONTINUE;
            }
        }
    }
    return PLUGIN_CONTINUE;
}

ReadFile( )
{
    new szConfigs[ 32 ], szFormat[ 64 ], szPlayerData[ 512 ], szName[ 32 ], szPassword[ 18 ], szAccessFlags[ 25 ], szPrefix[ 24 ];
    get_configsdir( szConfigs, charsmax( szConfigs ) );
    
    formatex( szFormat, charsmax( szFormat ), "%s/%s", szConfigs, g_szFile );
    
    new iFile = fopen( szFormat, "r" );
    
    if( iFile )
    {
        while( ! feof( iFile ) )
        {    
            fgets( iFile, szPlayerData, charsmax( szPlayerData ) );
            trim( szPlayerData );
            
            if( szPlayerData[ 0 ] == ';' || ( szPlayerData[ 0 ] == '/' && szPlayerData[ 1 ] == '/' ) )
            continue;
            
            parse( szPlayerData, szName, charsmax( szName ), szPassword, charsmax( szPassword ), szAccessFlags, charsmax( szAccessFlags ), szPrefix, charsmax( szPrefix ) );
            
            g_iItems[ Player_Name ] = szName;
            g_iItems[ Player_Password ] = szPassword;
            g_iItems[ Player_AccessFlags ] = szAccessFlags;
            g_iItems[ Player_Prefix ] = szPrefix;
            
            ArrayPushArray( g_aDatabase, g_iItems );
        }
        fclose( iFile );
    }
}

FreeString( szString[ ] )
{
    for( new i; i < strlen( szString ); i++ )
    {
        szString[ i ] = EOS;
    }
    return 1;
}

Quote:

Originally Posted by Clauu

Since you're using global vars, you should empty them before reading again

Which global vars?

Quote:

Originally Posted by Clauu

g_iItems[ index ][0]=0

What even is that? Makes no sense at all.

Quote:

Originally Posted by Clauu

Same thing for the array g_aDatabase, it should be emptied too before adding new entries.

How do you empty an array? And where should I do that?

Quote:

Originally Posted by Clauu

g_iItems[ Player_Name ] = szName // you shouldn't do this, use copy or format(ex) or better parse directly in to g_iItems[ index ]

I don't really get what this index thingy of yours is, at all. Why should I call a native when I can do it directly!?

Quote:

Originally Posted by Clauu

And also as a thing of optimization i don't think that it's a good ideea to parse files in chat hook, set_task is enough for this job

Neither do I get this one. Where do you see parse in chat hook?

Quote:

Originally Posted by Natsheh

You forgot to remove the quotes from szName, etc...

Where?

Quote:

Originally Posted by Natsheh

And check if the line you retrieved is greater than 5 characters

Which line?

Quote:

Originally Posted by Natsheh

#define FreeString(%1) %1[0]=EOS

Thanks!

Clauu · 01-15-2018 , 09:51 Re: Loop order

First of all, is this code written by you?

Quote:

Originally Posted by edon1337

Which global vars?

Code:

g_iItems

Quote:

Originally Posted by edon1337

What even is that? Makes no sense at all.

Is how you empty any string array, 0 is the null char that indicates the end of the string, @Natsheh has given you a more elegant way FreeString(%1) which is the same thing

Quote:

Originally Posted by edon1337

How do you empty an array? And where should I do that?

ArrayClear(array), at the start of the readfile function, before adding values to it.

Quote:

Originally Posted by edon1337

I don't really get what this index thingy of yours is, at all. Why should I call a native when I can do it directly!?

g_iItems[ Player_Name ] // index = Player_Name
Using that assignment you have to be always careful at the array sizes, beside that you don't call it more than once in a second, so there are no performance issues.

Quote:

Originally Posted by edon1337

Neither do I get this one. Where do you see parse in chat hook?

Code:

public OnHookSay( id )
{
    ReadFile( );

edon1337 · 01-15-2018 , 10:03 Re: Loop order

Quote:

Originally Posted by Clauu

First of all, is this code written by you?

Of course it is, why else would I want to fix the bugs?

Quote:

Originally Posted by Clauu

g_iItems[ Player_Name ] // index = Player_Name
Using that assignment you have to be always careful at the array sizes, beside that you don't call it more than once in a second, so there are no performance issues.

Where should I empty g_iItems?

Clauu · 01-15-2018 , 11:32 Re: Loop order

Before reading into it, for ex here:

PHP Code:


			
ReadFile( )
{
    FreeString(g_iItems[ Player_Name ]);
    new szConfigs[ 32 ], szFormat[ 64 ], szPlayerData[ 512 ], szName[ 32 ], szPassword[ 18 ], szAccessFlags[ 25 ], szPrefix[ 24 ];

But after reading more carefully you have more issues in your code. So..
1. forget about global var g_iItems, use it only local in functions to parse data into it
2. for global use, you have g_aDatabase array. Use only this for global scope to retrieve data from it.

edon1337 · 01-15-2018 , 12:43 Re: Loop order

Quote:

Originally Posted by Clauu

Before reading into it, for ex here:

PHP Code:


			
ReadFile( )

{

    FreeString(g_iItems[ Player_Name ]);

    new szConfigs[ 32 ], szFormat[ 64 ], szPlayerData[ 512 ], szName[ 32 ], szPassword[ 18 ], szAccessFlags[ 25 ], szPrefix[ 24 ];

But after reading more carefully you have more issues in your code. So..
1. forget about global var g_iItems, use it only local in functions to parse data into it
2. for global use, you have g_aDatabase array. Use only this for global scope to retrieve data from it.

So, like this?

PHP Code:


			
ReadFile( )

{

    ArrayClear( g_aDatabase );



    FreeString( g_iItems[ Player_Name ] );

    FreeString( g_iItems[ Player_Password ] );

    FreeString( g_iItems[ Player_AccessFlags ] );

    FreeString( g_iItems[ Player_Prefix ] );



    new szConfigs[ 32 ], szFormat[ 64 ], szPlayerData[ 512 ], szName[ 32 ], szPassword[ 18 ], szAccessFlags[ 25 ], szPrefix[ 24 ];

    get_configsdir( szConfigs, charsmax( szConfigs ) );

    

    formatex( szFormat, charsmax( szFormat ), "%s/%s", szConfigs, g_szFile );

    

    new iFile = fopen( szFormat, "r" );

    

    if( iFile )

    {

        while( ! feof( iFile ) )

        {    

            fgets( iFile, szPlayerData, charsmax( szPlayerData ) );

            trim( szPlayerData );

            

            if( szPlayerData[ 0 ] == ';' || ( szPlayerData[ 0 ] == '/' && szPlayerData[ 1 ] == '/' ) )

            continue;

            

            parse( szPlayerData, szName, charsmax( szName ), szPassword, charsmax( szPassword ), szAccessFlags, charsmax( szAccessFlags ), szPrefix, charsmax( szPrefix ) );

            

            g_iItems[ Player_Name ] = szName;

            g_iItems[ Player_Password ] = szPassword;

            g_iItems[ Player_AccessFlags ] = szAccessFlags;

            g_iItems[ Player_Prefix ] = szPrefix;

            

            ArrayPushArray( g_aDatabase, g_iItems );

        }

        fclose( iFile );

    }

}

edon1337 · 01-15-2018 , 13:57 Re: Loop order

Okay, so, finally I got it to work, PROPERLY! I'll report if I find any other bug. Here's the code if anyone else will experience the same problem in the future!

PHP Code:


			
#include < amxmodx >
#include < amxmisc >
#include < colorchat >

#define PLUGIN_AUTHOR "DoNii"
#define PLUGIN_VERSION "1.3"
#define PLUGIN_NAME "New Admin System"

#define TASK_CHECK_STEAL 3.0
#define ADMIN_ADD_FLAG ADMIN_RCON
#define FreeString(%1) %1[0]=EOS

enum _:PlayerData
{
    Player_Name[ 32 ],
    Player_Password[ 18 ],
    Player_AccessFlags[ 32 ],
    Player_Prefix[ 24 ]
}

new g_iItems[ PlayerData ];
new Array:g_aDatabase;
new const g_szFile[ ] = "AccountUsers.ini";

public plugin_init( )
{
    register_plugin( PLUGIN_NAME, PLUGIN_VERSION, PLUGIN_AUTHOR );
    
    register_concmd( "amx_addadmin", "OnAddNewAdmin" );
    
    g_aDatabase = ArrayCreate( PlayerData );
    
    register_clcmd( "say", "OnHookSay" );
    register_clcmd( "say_team", "OnHookSay" );
    
    set_task( TASK_CHECK_STEAL, "OnTaskCheckStealAdmin", _, _, _, "b" );
    
    ReadFile( );
}

public OnAddNewAdmin( id )
{
    if( ~ get_user_flags( id ) & ADMIN_ADD_FLAG )
    {
        client_print( id, print_console, "You have no Access to this command" );
        return PLUGIN_HANDLED;
    }

    if( read_argc( ) != 5 )
    {
        client_print( id, print_console, "Usage is : amx_addadmin <Nick|SteamID> <Password> <Flags> <Prefix>" );
        return PLUGIN_HANDLED;
    }

    new szAdminName[ 32 ], szAdminPassword[ 18 ], szAdminFlags[ 32 ], szAdminPrefix[ 18 ];
    
    read_argv( 1, szAdminName, charsmax( szAdminName ) );
    read_argv( 2, szAdminPassword, charsmax( szAdminPassword ) );
    read_argv( 3, szAdminFlags, charsmax( szAdminFlags ) );
    read_argv( 4, szAdminPrefix, charsmax( szAdminPrefix ) );
    
    if( ( strlen( szAdminName ) < 3 ) || ( strlen( szAdminFlags ) < 1 ) )
    {
        client_print( id, print_console, "ERROR: Incorrect Format of Admin" );
        return PLUGIN_HANDLED;
    }
    
    new szConfigs[ 64 ], szFormat[ 128 ];
    get_configsdir( szConfigs, charsmax( szConfigs ) );
    
    formatex( szFormat, charsmax( szFormat ), "%s/%s", szConfigs, g_szFile );
    new iFile = fopen( szFormat, "r+" ); 

    new szByteVal[ 1 ], szNewLine[ 256 ]; 
    
    fseek( iFile , -1 , SEEK_END ); 
    
    fread_raw( iFile , szByteVal , sizeof( szByteVal ) , BLOCK_BYTE ); 
    
    fseek( iFile , 0 , SEEK_END ); 
    
    formatex( szNewLine , charsmax( szNewLine ) , "%s^"%s^" ^"%s^" ^"%s^" ^"%s^"" , ( szByteVal[ 0 ] == 10 ) ? "" : "^n", szAdminName, szAdminPassword, szAdminFlags, szAdminPrefix ); 

    fprintf( iFile, szNewLine );
    fclose( iFile );  
    
    client_print( id, print_console, "Successfully Added New Admin: Name: %s | Password: %s | Flags: %s | Prefix: %s |", szAdminName, szAdminPassword, szAdminFlags, szAdminPrefix );
    return PLUGIN_CONTINUE;
}

public OnTaskCheckStealAdmin( )
{
    ReadFile( );

    new szPlayers[ 32 ], iNum, szName[ 32 ], szAuthID[ 32 ], szPassword[ 18 ], szName2[ 32 ], szPassword2[ 18 ], szFlags[ 32 ];
    get_players( szPlayers, iNum );
    
    static iTempID;

    new iArraySize = ArraySize( g_aDatabase );

    copy( szName2, charsmax( szName2 ), g_iItems[ Player_Name ] );
    copy( szPassword2, charsmax( szPassword2 ), g_iItems[ Player_Password ] );
    copy( szFlags, charsmax( szFlags ), g_iItems[ Player_AccessFlags ] );
    
    for( new i; i < iNum; i++ )
    {
        iTempID = szPlayers[ i ];

        for( new iIndex; iIndex < iArraySize; iIndex++ )
        {
            ArrayGetArray( g_aDatabase, iIndex, g_iItems );
            
            get_user_info( iTempID, "name", szName, charsmax( szName ) );
            get_user_authid( iTempID, szAuthID, charsmax( szAuthID ) );
            get_user_info( iTempID, "_pw", szPassword, charsmax( szPassword ) );
            
            if( equal( szName2, szName ) || equal( szName2, szAuthID ) )
            {
                if( ! szPassword2[ 0 ] || equal( szPassword2, szPassword ) )
                {
                    remove_user_flags( iTempID );
                    set_user_flags( iTempID, read_flags( szFlags ) );
                    
                    //log_to_file( "DebugTest.txt", "#1 Called | Player_Name: %s | szName: %s | Player_Password: %s | szPassword: %s |", g_iItems[ Player_Name ], szName, g_iItems[ Player_Password ], szPassword );
                }
                
                //log_to_file( "DebugTest.txt", "#2 Called | Player_Name: %s | szName: %s | Player_Password: %s | szPassword: %s |", g_iItems[ Player_Name ], szName, g_iItems[ Player_Password ], szPassword );
                
                else if( ! equal( szPassword2, szPassword ) )
                {
                    remove_user_flags( iTempID );
                    server_cmd( "kick #%d ^"KICKED: you have no entry to this server^"", get_user_userid( iTempID ) );
                    
                    //log_to_file( "DebugTest.txt", "#3 Called | Player_Name: %s | szName: %s | Player_Password: %s | szPassword: %s |", g_iItems[ Player_Name ], szName, g_iItems[ Player_Password ], szPassword );
                }
            }
        }
    }
}

public client_infochanged( id )
{
    new szOldName[ 32 ], szNewName[ 32 ];
    get_user_name( id, szOldName, charsmax( szOldName ) );
    get_user_info( id, "name", szNewName, charsmax( szNewName ) );

    if( ! equal( szOldName, szNewName ) )
    remove_user_flags( id );
}    

public client_authorized( id )
{
    new iArraySize = ArraySize( g_aDatabase );
    new szName[ 32 ], szAuthID[ 32 ], szPassword[ 18 ];
    
    for( new iIndex; iIndex < iArraySize; iIndex++ )
    {
        ArrayGetArray( g_aDatabase, iIndex, g_iItems );
        
        get_user_info( id, "name", szName, charsmax( szName ) );
        get_user_authid( id, szAuthID, charsmax( szAuthID ) );
        get_user_info( id, "_pw", szPassword, charsmax( szPassword ) );
        
        if( equal( g_iItems[ Player_Name ], szName ) || equal( g_iItems[ Player_Name ], szAuthID ) )
        {
            if( ! g_iItems[ Player_Password ][ 0 ] || equal( g_iItems[ Player_Password ], szPassword ) )
            {                
                remove_user_flags( id );
                set_user_flags( id, read_flags( g_iItems[ Player_AccessFlags ] ) );
            }
            
            else
            {            
                server_cmd( "kick #%d ^"KICKED: you have no entry to this server^"", get_user_userid( id ) );
            }
        }
    }
    return PLUGIN_CONTINUE;
}

public OnHookSay( id )
{
    new iArraySize = ArraySize( g_aDatabase );
    new szArgs[ 192 ], szName[ 32 ], szAuthID[ 32 ], szPassword[ 18 ], szName2[ 32 ], szPassword2[ 18 ], szPrefix[ 24 ];
    
    for( new iIndex; iIndex < iArraySize; iIndex++ )
    {
        ArrayGetArray( g_aDatabase, iIndex, g_iItems );
        
        read_args( szArgs, charsmax( szArgs ) );
        remove_quotes( szArgs );
        
        get_user_info( id, "name", szName, charsmax( szName ) );
        get_user_authid( id, szAuthID, charsmax( szAuthID ) );
        get_user_info( id, "_pw", szPassword, charsmax( szPassword ) );
        
        copy( szName2, charsmax( szName2 ), g_iItems[ Player_Name ] );
        copy( szPassword2, charsmax( szPassword2 ), g_iItems[ Player_Password ] );
        copy( szPrefix, charsmax( szPrefix ), g_iItems[ Player_Prefix ] );
        
        if( equal( szName2, szName ) || equal( szName2, szAuthID ) )
        {
            if( ! szPassword2[ 0 ] || equal( szPassword2, szPassword ) )
            {
                if( szPrefix[ 0 ] )
                {
                    if( is_user_alive( id ) )
                    {
                        client_print_color( 0, DontChange, "^4%s ^3%s^1: ^4%s", szPrefix, szName, szArgs );                        
                        return PLUGIN_HANDLED_MAIN;
                    }
                    
                    else
                    {
                        client_print_color( 0, DontChange, "^1*DEAD* ^4%s ^3%s^1: ^4%s", szPrefix, szName, szArgs );
                        return PLUGIN_HANDLED_MAIN;
                    }
                }
                
                else
                return PLUGIN_CONTINUE;
            }
        }
    }
    return PLUGIN_CONTINUE;
}

ReadFile( )
{
    ArrayClear( g_aDatabase );

    FreeString( g_iItems[ Player_Name ] );
    FreeString( g_iItems[ Player_Password ] );
    FreeString( g_iItems[ Player_AccessFlags ] );
    FreeString( g_iItems[ Player_Prefix ] );

    new szConfigs[ 32 ], szFormat[ 64 ], szPlayerData[ 512 ], szName[ 32 ], szPassword[ 18 ], szAccessFlags[ 25 ], szPrefix[ 24 ];
    get_configsdir( szConfigs, charsmax( szConfigs ) );
    
    formatex( szFormat, charsmax( szFormat ), "%s/%s", szConfigs, g_szFile );
    
    new iFile = fopen( szFormat, "r" );
    
    if( iFile )
    {
        while( ! feof( iFile ) )
        {    
            fgets( iFile, szPlayerData, charsmax( szPlayerData ) );
            trim( szPlayerData );
            
            if( szPlayerData[ 0 ] == ';' || ( szPlayerData[ 0 ] == '/' && szPlayerData[ 1 ] == '/' ) )
            continue;
            
            parse( szPlayerData, szName, charsmax( szName ), szPassword, charsmax( szPassword ), szAccessFlags, charsmax( szAccessFlags ), szPrefix, charsmax( szPrefix ) );
            
            g_iItems[ Player_Name ] = szName;
            g_iItems[ Player_Password ] = szPassword;
            g_iItems[ Player_AccessFlags ] = szAccessFlags;
            g_iItems[ Player_Prefix ] = szPrefix;
            
            ArrayPushArray( g_aDatabase, g_iItems );
        }
        fclose( iFile );
    }
}

Now I am open to suggestions on improving the code. It's not a plugin worthy of publishing for Approval but it reduces CPU usage compared to admin.amxx (~1.0% as of my i5 3470 3.2 GHz.)

Thanks everyone! I owe you a lot.