[CrazY.]

Hello, I'm trying to change weapon iMaxClip/iMaxAmmo1, but I'm getting a problem to hook function from class.

new const g_pszNameGalil[] = "weapon_galil";

public plugin_precache()
{
    OrpheuRegisterHook(OrpheuGetFunctionFromClass(g_pszNameGalil, "GetItemInfo", "CBasePlayerItem"), "CGalil_GetItemInfo_Post", OrpheuHookPost);
}

public CGalil_GetItemInfo_Post(this, hItemInfo)
{
    if (entity_get_int(this, EV_INT_impulse) != 100)
        return;

    new iMaxClip = get_pcvar_num(g_pCvarGalilMaxClip);
    new iMaxAmmo = get_pcvar_num(g_pCvarGalilMaxAmmo);

    OrpheuSetParamStructMember(2, "iMaxClip", iMaxClip);
    OrpheuSetParamStructMember(2, "iMaxAmmo1", iMaxAmmo);
}

Log error

L 10/08/2018 - 15:47:10: [ORPHEU] Invalid virtual function "CBasePlayerItem::GetItemInfo"
L 10/08/2018 - 15:47:10: [AMXX] Displaying debug trace (plugin "orpheu_galil.amxx", version "unknown")
L 10/08/2018 - 15:47:10: [AMXX] Run time error 10: native error (native "OrpheuGetFunctionFromClass")
L 10/08/2018 - 15:47:10: [AMXX]    [0] orpheu_galil.sma::plugin_precache (line 132)

[HamletEagle]

You are hooking on the wrong class. https://github.com/s1lentq/ReGameDLL..._galil.cpp#L36

[CrazY.]

OrpheuRegisterHook(OrpheuGetFunctionFromClass(g_pszNameGalil, "GetItemInfo", "CGalil"), "CGalil_GetItemInfo_Post", OrpheuHookPost);

Same problem. I have no idea how to work with orpheu, by chance I need a signature for CGalil::GetItemInfo? Anyway, I'm trying to change weapon clip but I don't think will be easy with default hlds as an I though.

As an I read here https://forums.alliedmods.net/showthread.php?p=1793160, I will need to recode some parts of the weapon to be able to manage clip. Is there any signature list? Because I'm getting problem to get them with myself due my computer.

[HamletEagle]

Sorry I was talking bullshit, it's okay how you are hooking. Use a signature like this:

PHP Code:

{
     "name"      : "GetItemInfo",
     "class"     : "CBasePlayerItem",
     "library"   : "mod",
     "arguments" :
     [
         {
             "type" : "ItemInfo *"
         }
     ],
     "return" :     
     {
         "type" : "int"
     },
     "indexes" :
     [
         {
             "os"    : "windows",
             "mod"   : "cstrike",
             "value" : 61
         },         
         {
             "os"    : "linux",
             "mod"   : "cstrike",
             "value" : 61
         }
     ] 
} 


[CrazY.]

As an expected, now it worked but had no effect. Any idea?

public plugin_precache()
{
    OrpheuRegisterHook(OrpheuGetFunctionFromClass(g_pszNameGalil, "GetItemInfo", "CBasePlayerItem"), "CGalil_GetItemInfo_Post", OrpheuHookPost);
}

public CGalil_GetItemInfo_Post(this, hItemInfo)
{
    if (!IsMagnumDrill(this))
        return;

    static iMaxClip, iMaxAmmo;

    iMaxClip = get_pcvar_num(g_pCvarDrillMaxClip);
    iMaxAmmo = get_pcvar_num(g_pCvarDrillMaxAmmo);

    OrpheuSetParamStructMember(2, "iMaxClip", iMaxClip);
    OrpheuSetParamStructMember(2, "iMaxAmmo1", iMaxAmmo);
}

[meTaLiCroSS]

Because GetItemInfo is called at server first start instance (UTIL_PrecacheOtherWeapon), and values are cached on CBasePlayerItem::ItemInfoArray array. After that, gamedll uses values from that array. If you want to change those values in mid game, you'll need to hook every function that uses, in this case, iMaxClip and iMaxAmmo1 members from ItemInfoArray.

[HamletEagle]

Originally Posted by meTaLiCroSS Because GetItemInfo is called at server first start instance (UTIL_PrecacheOtherWeapon), and values are cached on CBasePlayerItem::ItemInfoArray array. After that, gamedll uses values from that array. If you want to change those values in mid game, you'll need to hook every function that uses, in this case, iMaxClip and iMaxAmmo1 members from ItemInfoArray.

Or just alter ItemInfoArray directly.

[meTaLiCroSS]

Originally Posted by HamletEagle Or just alter ItemInfoArray directly.

Originally Posted by meTaLiCroSS If you want to change those values in mid game, you'll need to hook every function that uses, in this case, iMaxClip and iMaxAmmo1 members from ItemInfoArray.

I assume you understood the context given here. He's trying to make a custom weapon, plus, use a different max clip ammo for itself, without altering original weapon.

PHP Code:

public CGalil_GetItemInfo_Post(this, hItemInfo)
{
    if (!IsMagnumDrill(this))
        return;
    // ... 


So...

you'll need to hook every function that uses, in this case, iMaxClip and iMaxAmmo1 members from ItemInfoArray.

A mix of hooks with AddPrimaryAmmo, DefaultReload, ItemPostFrame, and I guess others. At least I need those for altering max clip without altering default/other (custom or not) weapons.

[CrazY.]

What @meTaLiCroSS said make totally sense, since I did without orpheu and looks working. I needed to "recode":

CBasePlayerWeapon::DefaultReload
CBasePlayerWeapon::ItemPostFrame

to manage iMaxClip (I didn't even try AddPrimaryAmmo yet). To manage iMaxAmmo1 I'm still getting some trouble in "buy primary ammo" at buy menu.

[meTaLiCroSS]

Originally Posted by CrazY. What @meTaLiCroSS said make totally sense, since I did without orpheu and looks working. I needed to "recode": CBasePlayerWeapon::DefaultReload CBasePlayerWeapon::ItemPostFrame to manage iMaxClip (I didn't even try AddPrimaryAmmo yet). To manage iMaxAmmo1 I'm still getting some trouble in "buy primary ammo" at buy menu.

AddPrimaryAmmo helps a lot in this case, you'll need Orpheu for it also. Just a parameter changing, same like DefaultReload