[maqi]

Hey guys, I recently made this plugin for my server, and everything looked and worked well.

Today I entered a server and for everyone else it worked perfectly, but for me, I had the default say ( Like it returned continue ). Then my brother joined and he had the default say and everything was working fine for me.

Im loosing my mind and have no clue whats happening, please help.

Also please dont answer me something on the lines of "There is a plugin for this already" We had some problems with those so i made this one which does exactly what i need, no reason to use anything more. But if there are any code errors please be sure to point them out!

PHP Code:

#include <amxmodx>
#include <amxmisc>

#include < colorchat >

#pragma semicolon 1

new const     plugin[]    =    "chat",
        version[]    =    "1.4",
        author[]    =    "maqi";

#define ADMIN_FLAGS     ADMIN_BAN
#define VIP_FLAGS     ADMIN_LEVEL_C

new const    ADMIN_PREFIX[]     =     "[Admin]",
        VIP_PREFIX[]     =     "[Vip]";
        
new        bool:hasPrefix[32] = true;

new Color:iColor;

public plugin_init() 
{
    register_plugin( plugin, version, author );
    
    register_clcmd( "say", "SayRegistered" );
    register_clcmd( "say_team", "SayRegistered" );
}
public client_authorized( id )
    hasPrefix[ id ] = true;

public SayRegistered( id )
{
    new     said[192],
        player[32],
        team[20],
        cmd[9],
        arg1[9],
        prefix[8],
        dead[8];
        
    
    read_argv( 0, cmd, charsmax(cmd) );
    read_argv( 1, arg1, charsmax(arg1) );
    read_args( said, charsmax(said) );
    remove_quotes( said );
    get_user_name( id, player, charsmax(player) );
        
    if( equali( arg1, "/prefix" ) )
        PrefixToggle( id );    
        
    if( said[0] == '/' || equali( said, "" ) )
        return PLUGIN_HANDLED;
    
    if( get_user_flags( id ) & ADMIN_FLAGS && hasPrefix[ id ] )
        copy( prefix, charsmax(prefix), ADMIN_PREFIX );
    else if ( get_user_flags( id ) & VIP_FLAGS && hasPrefix[ id ] )
        copy( prefix, charsmax(prefix), VIP_PREFIX );    
    else
        copy( prefix, charsmax(prefix), "" );
        
    if( get_user_team( id ) == 3 )
        copy( dead, charsmax(dead), " SPEC " );    
    else if( !is_user_alive( id ) )
        copy( dead, charsmax(dead), " DEAD " );    
    else
        copy( dead, charsmax(dead), "" );
    
    switch ( get_user_team( id ) )
    {
        case 1:
        {
            if( equal( cmd, "say_team") )
                copy( team, charsmax(team), "(Terrorist)" );
            iColor = RED;
        }
        case 2:
        {
            if( equal( cmd, "say_team") )
                copy( team, charsmax(team), "(Counter-Terrorist)" ); 
            iColor = BLUE;
        }
        case 3:
        {
            if( equal( cmd, "say_team") )
                copy( team, charsmax(team), "(Spectator)" );    
            iColor = GREEN;
        }
        default:
            return PLUGIN_CONTINUE;
    }
    
    new    sFormat[192];
    
    if( !is_user_alive( id ) )
        format( sFormat, charsmax(sFormat), "^x04%s^x01%s%s^x03%s: ^x01%s", prefix, dead, team, player, said ); 
    else if( ( get_user_flags( id ) & ADMIN_FLAGS  || get_user_flags( id ) & VIP_FLAGS || equal( cmd, "say_team") ) && hasPrefix[ id ] )
        format( sFormat, charsmax(sFormat), "^x04%s^x01%s%s^x03 %s: ^x01%s", prefix, dead, team, player, said );
    else
        format( sFormat, charsmax(sFormat), "^x04%s^x01%s%s^x03%s: ^x01%s", prefix, dead, team, player, said ); 
        
    if( equal( cmd, "say_team") )
    {
        new    pnum,
            players[32];
        
        get_players( players,pnum );
        
        for( new i;i < pnum;i++ )
        {
            if( get_user_team( id ) == get_user_team( player[i] ) || get_user_flags( player[i] ) & ADMIN_FLAGS )
                ColorChat( players[i] , iColor, sFormat );
        }
    }
    
    ColorChat( 0, iColor, sFormat );
    
    return PLUGIN_HANDLED;
}

public PrefixToggle( id )
{
    if( get_user_flags( id ) & ADMIN_FLAGS || get_user_flags( id ) & VIP_FLAGS )
    {
        if( hasPrefix[ id ] )
        {
            hasPrefix[ id ] = false;
            ColorChat( id, GREEN, "^x04[chat]^x01 Admin Prefix Disabled." );
        } else {
            hasPrefix[ id ] = true;
            ColorChat( id, GREEN, "^x04[chat]^x01 Admin Prefix Enabled." );
        }
    }
} 


Thanks in advance

[VINAGHOST]

Did you try "return PLUGIN_HANDLED;" to "return PLUGIN_HANDLED_MAIN" ?
I saw in "Admin Prefixes" - m0skVi4a, he use it ._.

And look like you forgot "else" here

PHP Code:

if( equal( cmd, "say_team") ) 
    { 
        new    pnum, 
            players[32]; 
         
        get_players( players,pnum ); 
         
        for( new i;i < pnum;i++ ) 
        { 
            if( get_user_team( id ) == get_user_team( player[i] ) || get_user_flags( player[i] ) & ADMIN_FLAGS ) 
                ColorChat( players[i] , iColor, sFormat ); 
        } 
    } 
 else //HERE
         ColorChat( 0, iColor, sFormat ); 


Sorry for my bad English ._.

[edon1337]

You can't use read_argv in say/say_team. You have to use trim() and strbreak() from string.inc. You can learn to use them by looking at the /donate plugin from Zombie Plague.

[maqi]

@VINAGHOST
Yes i did forget, but it worked even without it ( No double messages )
Such a simple plugin but nothing makes sense to me

@edon1337
I dont get if you are saying i shouldnt or that it wont work. Because that part is working perfectly

Im just having problems with why is my plugin acting like its returning PLUGIN_CONTINUE

[Black Rose]

What you do is find out what the errors have in common. "Random" is not a cause, code doesn't behave that way. The code will do what you tell it to.

From what I can see you will get double messages whenever writing a team-message, and everyone will get it.
To fix this you either put a "return PLUGIN_HANDLED" after the team message is sent or you put the ColorChat() for the main chat inside an else-statement.
It is also possible another plugin is interfering but I would say that seems unlikely.

[maqi]

I agree with you, but i fixed that mistake.

My question is why is the say message ever happening if my plugin is essentially this:

PHP Code:

public plugin_init() 
    register_clcmd( "say", "SayRegistered" );
public SayRegistered(id)
    return PLUGIN_HANDLED 


[Black Rose]

Simple answer: It doesn't.

[maqi]

Man you can see my code, ur answer like that doesnt help me at all Either find a mistake or tell me a plugin is interfearing or something else

[Black Rose]

How would I know? I don't know what plugins you're running.



Here's another problem:

L 11/19/2017 - 22:22:51: Invalid player id 66
L 11/19/2017 - 22:22:51: [AMXX] Displaying debug trace (plugin "test1.amxx")
L 11/19/2017 - 22:22:51: [AMXX] Run time error 10: native error (native "get_use
r_flags")
L 11/19/2017 - 22:22:51: [AMXX]    [0] test1.sma::SayRegistered (line 111)
(Counter-Terrorist) Black Rose : hello

        new    pnum, 
            players[32]; 
         
        get_players( players,pnum ); 
         
        for( new i;i < pnum;i++ ) 
        { 
            if( get_user_team( id ) == get_user_team( player[i] ) || get_user_flags( player[i] ) & ADMIN_FLAGS ) 
                ColorChat( players[i] , iColor, sFormat ); 
        }

player[] is a string containing the player name, players[] is the array of players.
have you even looked at the log? It's so much easier to debug things with the server console at least partially visible on screen so you see when bugs occur. That will help you to figure out the cause.

[maqi]

Example ( Plugin is working normaly for everyone and all of a sudden one random admin doesnt have it working, instead they have a default say message: *DEAD* nick : message

And i dont know how to recreate it, or i would probably find a way to fix it, that is why this is so weird.