Changes have been requested via PM.
PHP Code:
new thickness
new a_enable
new d_color
new c4_color
new t_color
new ct_color
new custom_enable
Consider tagging these with a global variable identifier.
This breaks convention for macros and should not be capitalized from front to back.
PHP Code:
new r
new g
new b
These are rather short. Consider adding prefix to them such as "color_".
PHP Code:
set_task(1.0, "GlowStart", 0)
Unnecessary extra typing. The task_id parameter defaults to 0.
PHP Code:
HUDSYNC=CreateHudSyncObj();
Inconsistent style. You should either always or never add spaces between operators.
PHP Code:
public client_putinserver(id){
set_task(12.0, "anuncio", id)
return PLUGIN_CONTINUE
}
Unnecessary return. Inconsistent spacing (you added a space after the function prototype in plugin_init).
PHP Code:
public anuncio(id){
printMsg(id);
client_print(id, print_chat,"%L",LANG_PLAYER, "GLOW_MSG")
return PLUGIN_CONTINUE
}
Function name is not descriptive. Is this Italian for "announce" or something?
PHP Code:
new mensaje[500]
Extremely expensive. Consider making this static as it is called relatively often. Indescriptive name, unless it's in another language.
PHP Code:
format(mensaje, 499, "%L", LANG_PLAYER, "GLOW_INFO")
set_hudmessage ( 200, 150, 0, 0.005, 0.2, 2, 0.1, 10.0, 0.05, 1.0, 1)
if(get_pcvar_num(a_enable) == 1){
ShowSyncHudMsg(id, HUDSYNC, mensaje)
}
return PLUGIN_HANDLED
Unnecessary check. Just see if it evaluates to true. Unnecessary return.
PHP Code:
public GlowStart(){
new players[32], pnum, id;
Inconsistent spacing.
PHP Code:
else if(get_user_team(id) == 1){
Poor allocation of resources. Cache the player's team and then check that.
PHP Code:
if(cs_get_user_defuse(id) == 1){
You already checked this and the same for user_has_weapon() etc., so merge them together.
PHP Code:
(set_task(0.1, "GlowStart", 0))
Unnecessary brackets.
PHP Code:
return PLUGIN_CONTINUE;
Inconsistent styling. Either always or never use semicolons.
05-16-2009, 13:11
thx
Linear Mode
