[fysiks]

You should only use geoip_code2_ex() once. Twice is inefficient and pointless.

[.MMYTH.]

check once at putinserver with [id] ?

[fysiks]

Originally Posted by .MMYTH. check once at putinserver with [id] ?

What do you think? If you don't know you should test it. You are doing the exact same thing twice.

[.MMYTH.]

New version v1.5

[fysiks]

You need to stop using one function several times for no reason. That being said, you already cache the player's country so you should use that.

Also, I would do playernation[id][0] = 0 at the begining of client_putinserver(id).

[nikhilgupta345]

Exactly what fysiks said, but just to add to it and make it more clear:

Stop using the if statements that use the geoip_code2_ex as the check, and instead do the command before the if, and then just use if( playernation[id] ), that way you only use 1 call to geoip_code2_ex.

ANd like fysiks said, you already put the nation in playernation[33], so you don't have to keep calling geoip_code2_ex in client_infochanged.

[fysiks]

Originally Posted by nikhilgupta345 Exactly what fysiks said, but just to add to it and make it more clear: Stop using the if statements that use the geoip_code2_ex as the check, and instead do the command before the if, and then just use if( playernation[id] ), that way you only use 1 call to geoip_code2_ex. ANd like fysiks said, you already put the nation in playernation[33], so you don't have to keep calling geoip_code2_ex in client_infochanged.

if( playernation[id] )

if( playernation[id][0] )

[.MMYTH.]

I test and the [id][0] bug's.

[nikhilgupta345]

Then you need to clear the user's array on disconnect.

[fysiks]

Originally Posted by .MMYTH. I test and the [id][0] bug's.

Not possible if you did it correctly. Show the new code.

Also, when you say it "bugs" you need tell us what you mean. It doesn't help at all when you are extremely vague.