[Freezo Begin]

There is no need to create a variable to hold get_pcvar_num & use it one time, i'm talking about

new iMaxTerorrists, iMaxCTs;

Also here :

if( iEnableTo == 1 || iEnableTo == 3 )
{	
         [...]					
}	
if( iEnableTo == 2 || iEnableTo == 3 )
{		
         [...]
}

Also,

new id, iTarget;
new i, j

Can be declared after the check.

		
if( iEnableTo == 1 || iEnableTo == 3 )
{	
         -> Here

Small things...

̷S̷h̷o̷u̷l̷d̷n̷'̷t̷ ̷y̷o̷u̷ ̷a̷d̷d̷ ̷a̷ ̷e̷v̷e̷n̷t̷ ̷f̷o̷r̷ ̷t̷h̷e̷ ̷f̷i̷r̷s̷t̷ ̷r̷o̷u̷n̷d̷?̷

[HamletEagle]

There is no need to create a variable to hold get_pcvar_num & use it one time, i'm talking about

Didn't matter much, you could say this is for readability. It's not tragic. Author could change if he wants to.

if( iEnableTo == 1 || iEnableTo == 3 ) { [...] } if( iEnableTo == 2 || iEnableTo == 3 ) { [...] }

Don't understand what it's your point with this. If cvar is 3 it should enter in the both checks.

new id, iTarget; new i, j

Not really, you would have to declare them two times.

Shouldn't you add a event for the first round?

What ? HLTV is the new round event.

@Askhanar:
Just few more thing:

1.You should reset iFakeIndex to g_iHostageCount between the for loops. See 2.
2.Your both for's have the same code, you could probably factorize it, to avoid duplicated code. Something like:

PHP Code:

UTIL_LoopPlayers(const Team[], const TeamCount, const Enemies[], const EnemiesCount)
{
    new iFakeIndex = g_iHostageCount
    new i, j, id
    for(i = 0; i < TeamCount; i++)
    {
        id = Team[i]
        for(j = 0; j < EnemiesCount; j++)
        {
            UTIL_ShowOnRadar(id, Enemies[j], ++iFakeIndex)
        }
    }
} 


Then, in the task:

PHP Code:

if( iEnableTo == 1 || iEnableTo == 3 )
{    
    UTIL_LoopPlayers(iAliveTerorrists, iAliveTerorristsNum, iAliveCTs, iAliveCTsNum)
}
        
if( iEnableTo == 2 || iEnableTo == 3 )
{        
    UTIL_LoopPlayers(iAliveCTs, iAliveCTsNum, iAliveTerorrists, iAliveTerorristsNum)
} 


[Freezo Begin]

This is what happen when you(/i) have a bad english.

Anyway, the iEnable 3 should be first then he need to check iEnable 1 & then 2 there is no need to repeat the check with the operator or ||.

I mean the first start round on change map.

[HamletEagle]

Anyway, the iEnable 3 should be first then he need to check iEnable 1 & then 2 there is no need to repeat the check with the operator or ||.

No. You should understand the code logic.
If 1 only T will see enemies on radar. if 2 only CT will see enemies on radar. If 3 both teams see enemies on radar. If we firstly check 3 then values 1 & 2 of the cvar will become useless, also no one won't see anything, because cvar can be either 1 or 2 or 3. Your suggestion would be good only if the check was && and not ||.

Current code works like:
-If cvar is 1 show for tero(enter only in the first check)
-If cvar is 2 show for ct.(enter only in second check)
-If cvar is 3 then show for both tero and ct(will enter in the first check -> show for tero and will enter in the second check too -> show for ct).

Abut first round, it's not needed, HLTV is well called from the first round if game started scoring. If not(only one player or all players in the same team) it won't be called from first round, but that's not an issue. In this case players won't have enemies so there is nothing to display on radar. Also g_bMessageShown is already false and needs to be reseted only next round, so HLTV being called on very first round or not doesn't really matter.

[Freezo Begin]

Originally Posted by HamletEagle Your suggestion would be good only if the check was && and not ||.

Lol, i'm blind.

Thanks a lot for the explanation.

[red_bull2oo6]

Once again, all done.

[HamletEagle]

Right now you are sending HostagePos message each time, even if the player is not moving. What you could do in order to reduce the number of messages send(so the network usage) is to send this message only if player moved. For this, ideally you could check origin and oldorigin, and getting the distance between this. Also small distances does not matter from player and radar point of view. So, if the distance if bigger than let's say 72(or anything between 72 and 100) you show the message. Do this only for HostagePos message, HostageK should be always send(because it's hold time is only 1.5 seconds, unlike HostagePos which is 9999 - thanks arkshine for client code).

One last thing, in UTIL_ShowOnRadar fOrigin should be static, since it's called from a loop.

[red_bull2oo6]

I'ts done, sorry for being late ^^.

[HamletEagle]

Bothering you again:
1.You should likely not retrieve origin at spawn, because it will fuck up the radar. When player is spawned he should appear on radar, only after message was send one time succesfully you should check if he moved or not. Do you even test before releasing an update ?
2.fOrigin should be static.

[HamletEagle]

More than 15 days have passed and I don't see any changes from the author. Since section needs to be cleaned I'll unapprove this for now, but don't worry, your plugin can be reviewed at any time. PM a plugin approver after you made the changes.

Shame that for this two small changes I have to unapprove it.