You might have see this comment comming :
you should allow someone to keep his clan tag. Always being ONLINE can be annoying (let a clan be a clan).
EDIT :
You should also rework your code to get your plugin approved...
Use "MAXPLAYERS + 1" rather than "32". Some servers have more than 31 players ("new bob[32]" will create a 32-sized array with 0 to 31 indexes, making it bug for player #32 and not work for over 32 players).
Code:
for (new i = 1; i <= MaxClients; i++)
{
if (i > 0 )
I don't really see why "i" would be equal to 0. I also doubt MaxClients would do an integer overflow...
Code:
if (index == -1)
{
index = PushArrayCell(posList, GetClientUserId(i))
}
else
position2[0] = GetArrayCell(posList, index, 1); // position[0]
position2[1] = GetArrayCell(posList, index, 2); // position[1]
position2[2] = GetArrayCell(posList, index, 3); // position[2]
WHUTTT ?!?!? seriously.... (else)
Code:
if (index == -1 || position2[0] != position[0] || position2[1] != position[1] || position2[2] != position[2] || angles2[0] != angles[0] || angles2[1] != angles[1] || angles2[2] != angles[2])
I suggest you do it on multiple lines to allow a better code-reading from other people.
Code:
iif (AFKTimers[client] != INVALID_HANDLE)
{
if(CloseHandle(AFKTimers[client]))
{
AFKTimers[client] = INVALID_HANDLE
}
AFKTimers[client] = CreateTimer(GetConVarFloat(FindConVar("sm_clafk_time")), StatusAFK, client)
CS_SetClientClanTag(client, "ONLINE");
}
else
{
AFKTimers[client] = CreateTimer(GetConVarFloat(FindConVar("sm_clafk_time")), StatusAFK, client)
CS_SetClientClanTag(client, "ONLINE");
}
Duplicated code. You don't need "else" if you're doing it in both case.
Good thing you thought about using them.
You should either always use semi-columns (;) or never, that way your code has some coherence. If you want them you can add "#pragma semicolon 1" at the top of your file if you want the compiler to tell you when you're not using them.
I also think you should space out more your code so it is more readable (add some linefeed (newline) between different codeblocks).