[Ravager01]

Did you happen to get this error?

[SM] Plugin encountered error 15: Array index is out of bounds
[SM] Displaying call stack trace for plugin "restrict.smx":
[SM]   [0]  Line 240, restrict.sp::Command_Restrict()

I get this when attempting to restrict the smoke grenade. All other weapons, including the HE and Flash grenades, can be restricted without any errors.

[Liam]

Okay, so here is what I've found:

// Lets parse our input and then restrict the weapons
f_Weapon = LookupWeaponNumber(f_WeaponString);
f_Amount = StringToInt(f_AmountString);
f_Team = LookupTeam(f_TeamString);
RestrictWeapon(client, f_Weapon, f_Amount, f_Team);
PerformTimedRemove(-1); // remove all restricted weapons in-game
// log the command
if(f_Team == TEAM_ALL)
{
    if(f_Amount == 0)
    {
        LogAction(client, -1, "sm_restrict - Restricted the %s.", 
        g_ShortWeaponNames[f_Weapon]);
    }
    else
    {
        LogAction(client, -1, "sm_restrict - Restricted the %s to %d per team.", 
        g_ShortWeaponNames[f_Weapon], f_Amount);
    }
}
else
{
    if(f_Amount == 0)
    {
        LogAction(client, -1, "sm_restrict - Restricted the %s for the %s team.", 
        g_ShortWeaponNames[f_Weapon], f_Team == TEAM_T ? "Terrorist" : "Counter-Terrorist");
    }
    else
    {
        LogAction(client, -1, "sm_restrict - Restricted the %s to %d for the %s team.", 
        g_ShortWeaponNames[f_Weapon], f_Amount, f_Team == TEAM_T ? "Terrorist" : "Counter-Terrorist");
    }
}

Those are the lines generating the error. I've only managed to replicate this after putting my restrict commands in a .cfg file.

Now: I tracked this back by adding the following code.

// Lets parse our input and then restrict the weapons
f_Weapon = LookupWeaponNumber(f_WeaponString);
f_Amount = StringToInt(f_AmountString);
f_Team = LookupTeam(f_TeamString);
RestrictWeapon(client, f_Weapon, f_Amount, f_Team);
PerformTimedRemove(-1); // remove all restricted weapons in-game
 
/* NEW CODE */
if(f_Weapon == -1 || f_Amount == -1 || f_Team == -1)
{
    LogError("Invalid weapon number: WeaponString: %s, AmountString: %s, Team: %s", 
    f_WeaponString, f_AmountString, f_TeamString);
    return;
}
/* END NEW CODE */
// log the command
if(f_Team == TEAM_ALL)
{
    if(f_Amount == 0)
    {
        LogAction(client, -1, "sm_restrict - Restricted the %s.", 
        g_ShortWeaponNames[f_Weapon]);
    }
    else
    {
        LogAction(client, -1, "sm_restrict - Restricted the %s to %d per team.", 
        g_ShortWeaponNames[f_Weapon], f_Amount);
    }
}
else
{
    if(f_Amount == 0)
{
        LogAction(client, -1, "sm_restrict - Restricted the %s for the %s team.", 
        g_ShortWeaponNames[f_Weapon], f_Team == TEAM_T ? "Terrorist" : "Counter-Terrorist");
}
    else
{
        LogAction(client, -1, "sm_restrict - Restricted the %s to %d for the %s team.", 
        g_ShortWeaponNames[f_Weapon], f_Amount, f_Team == TEAM_T ? "Terrorist" : "Counter-Terrorist");
}
}

What I found is that when something like the following is executed:

sm_restrict awp

It was actually sending to the server

sm_restrict t awp

I modified the plugin I was using to handle my cfg files appropriately and got it to work. If I have to write a standalone restriction file which the server will handle parsing and executing to fix this, I'll do it.

However, if a few of you feel froggy enough, add those lines into your restrict.sp, recompile it, and let me know if that is indeed, where your getting the error.

Thanks,
-Liam

[PStar]

Hy, i aded the lines (hopefully in the correct lines), but getting this errors whe compling.

[Liam]

Fix the return on those lines to say return Plugin_Handled;

Don't worry about the loose indention.

[Ravager01]

I think I may have found the problem.

In restrict.inc, in the new String:g_WeaponNames[][] section:

"weapon_flashbang", "weapon_hegrenade", "weapon_smokegrenade,",

Remove the unneeded comma in the enclosed weapon_smokegrenade tag and recompile the plugin. Smoke Grenade restriction should now work.

[Liam]

Originally Posted by Ravager01 I think I may have found the problem. In restrict.inc, in the new String:g_WeaponNames[][] section: "weapon_flashbang", "weapon_hegrenade", "weapon_smokegrenade,", Remove the unneeded comma in the enclosed weapon_smokegrenade tag and recompile the plugin. Smoke Grenade restriction should now work.

Good catch, but thats not the original problem. The original problem was a buffer overflow issue.

Will give it a try though.

Plugin has been updated.

[Ravager01]

In that case, s/the/a/. (if that's how it's supposed to look) O_o

[sessus]

the sm_knives option does not seem to work,
good plugin otherwise, well dome liam

[doa]

I have tried several difeerent ways to restict awp to one per team with no success, I have tried:
sm_restrict awp 1
sm_restrict awp 1 ct/t
sm_restrict awp 1 all


I have no problem to restict weapons to 0.

Any clues?

[PStar]

Originally Posted by doa I have tried several difeerent ways to restict awp to one per team with no success, I have tried: sm_restrict awp 1 sm_restrict awp 1 ct/t sm_restrict awp 1 all I have no problem to restict weapons to 0. Any clues?

It should look like this:

sm_restrict weapon_awp 1 CT sm_restrict weapon_awp 1 T sm_restrict weapon_scout 2 CT sm_restrict weapon_scout 2 T sm_restrict weapon_g3sg1 1 CT sm_restrict weapon_sg550 1 T