[pokezao]

Hi, I want to force non-admin Spectators to only spectate CT players in a Hide'n'Seek day (Jailbreak mod).

What I'm doing right now is hooking CBasePlayer_Observer_IsValidTarget and doing this:

PHP Code:

public CBasePlayer_Observer_IsValidTarget(const this, iPlayerIndex, bool:bSameTeam) 
{
    if( is_user_alive(iPlayerIndex) && day == HIDENSEEK )
    {
        if( !(get_user_flags(this) & ADMIN_FLAG) )
        {
            if( cs_get_user_team(iPlayerIndex) != CS_TEAM_CT )
            {
                static id; id = iPlayerIndex;
                while( (id = find_ent_by_class(id, "player")) != iPlayerIndex ) 
                {
                    if( !is_user_alive(id) ) continue;
                    if( cs_get_user_team(id) != CS_TEAM_CT ) 
                        continue;
                    
                    SetHookChainReturn(ATYPE_INTEGER, id);
                    break;
                }
            }
        }
    }
} 


This is working for observing players that are in a team (T or CT) but not for SPECTATOR players.

PS: Another thing to note is that I'm changing "mp_forcechasecam" to 2 only in HNS day, normally it is set to 0.

[Natsheh]

learn to use get_players instead looping the player entity

[pokezao]

Does that solve my problem?
I'm only doing as suggested here: https://forums.alliedmods.net/showpo...50&postcount=2

[lexzor]

use this as an example: https://amxx-bg.info/forum/viewtopic.php?f=18&t=1009


use flags parameters from get_players to get only ct team players, it's a better practice than loop every entity from the map

[pokezao]

I appreciate your help, but that's not the problem here.
This code is working if the observing player is in a team (T or CT) but, for some reason, doesn't work for Spectators.
I'm only interested in knowing why and what I can do to force ALL players, including spectators, to spectate only the CT team.

[Natsheh]

there.....

PHP Code:

public CBasePlayer_Observer_IsValidTarget(const this, const iTarget, const bool:bSameTeam)
{
    static players[32], pnum;
    get_players(players, pnum, "ahe", "CT");

    const PDATA_SAFE = 2;

    if( !iTarget || ( pev_valid(iTarget) == PDATA_SAFE && cs_get_user_team(iPlayerIndex) != CS_TEAM_CT ) )
    {
        if(pnum > 0)
        {
            SetHookChainArg(2, ATYPE_INTEGER, players[random( pnum )]);
            SetHookChainArg(3, ATYPE_BOOL, false);
        }
    }
} 


[MrPickles]

where is used "bSameTeam"? xd

cs_get_user_team(iPlayerIndex) = cs_get_user_team(iTarget) ?

[WaLkMaN]

Originally Posted by Natsheh there.....

A small edit:

#include <amxmodx>
#include <reapi>

public plugin_init()
{
    register_plugin("Force Spectate", "1.0", "Alliedmods");
    
    RegisterHookChain(RG_CBasePlayer_Observer_IsValidTarget, "Observer_IsValidTarget_Pre", .post = false);
}

public Observer_IsValidTarget_Pre(const this, const iTarget, const bool:bOnlyTeam)
{
    static players[32], pnum;
    get_players(players, pnum, "ahe", "CT");
    
    static currentPlayerId = 0;

    if ( !iTarget || ( is_user_alive(iTarget) && get_member(iTarget, m_iTeam) != TEAM_CT ) )
    {
        if (pnum > 0)
        {
            if (currentPlayerId >= pnum)
            {
                currentPlayerId = 0
            }

            SetHookChainArg(2, ATYPE_INTEGER, players[currentPlayerId]);
            SetHookChainArg(3, ATYPE_BOOL, false);
            
            currentPlayerId++;
        }
    }
}

[pokezao]

I have yet to test it but I trust it's working perfectly!

Just to understand: the problem was that I was not returning "false" on bSameTeam? Or it has something to do with the PDATA_SAFE thingy?
I deduce that this PDATA_SAFE condition is just a way to check if iTarget is a player, right?

Thank you very much Natsheh for the correct solution, and WaLkMaN for the small edit!

[pokezao]

Guys, for some reason it is working but exactly the opposite of what it should: we can only spectate Terrorists and not CTs