[lexzor]

hello again.

i have a problem with a part of code

PHP Code:

/* Plugin generated by AMXX-Studio */

#include <amxmodx>
#include <amxmisc>

#define PLUGIN "New Plug-In"
#define VERSION "1.0"
#define AUTHOR "super"

static key = keys...

static aCvarValue

public plugin_init() {
    register_plugin(PLUGIN, VERSION, AUTHOR)
    
    register_menu("randommenu", key, "randommenu_handler")
}

public randommenu(id){
    
    aCvarValue = get_cvar_num("some_cvar")
    
    new szMenu[650], ilen
    ilen = 0
    
    ilen += formatex(szMenu[ilen], charsmax(szMenu), "Menu^n^n")    
    ilen += formatex(szMenu[ilen], charsmax(szMenu), "\r1. \wFirst menu item - %s^n", aCvarValue == 0 ? "[ON]" : "[OFF]")
    
}

public randommenu_handler(id, key){
    
    switch(key):{
        
        case 0:{    
            switch(aCvarValue){        
                case 1:{
                    aCvarValue = 0
                    //code                
                }
                
                case 0:{
                    aCvarValue = 1
                    //code
                }
            }
        }
    }
} 


this is just a simulation of what I really want to do. the problem is that switch of the variable "aCvarValue" because regardless of the situation, the output will be the last "case" of the switch. The same situation with "if". I don't understand why it doesn't work, I've done this before and it worked, but now I can't figure it out

[LondoN]

aCvarValue > 0 ? some_function(id) : some_function2(id);

[OciXCrom]

The "randommenu" function is being called only once at map start, so of course that "get_cvar_num" is read only once as well.

Why are you using old-style menus in 2021?

aCvarValue = !aCvarValue ?

Also, modifying aCvarValue won't change the actual cvar. It's just a variable that stores its value. You need to use "set_cvar_num".

[Bugsy]

Agree with OciXCrom, if I understand correctly just do the below. This will always toggle on to off and off to on.

PHP Code:

public randommenu_handler(id, key)
{
    switch( key )
    {
        case 0:
        {    
            aCvarValue = !aCvarValue
            set_pcvar_num( cvarPtr , aCvarValue);
        }
    }
} 


[lexzor]

I used london solution. Thanks you all!

[Bugsy]

LondoN's solution is not ideal here, it's what people typically do just to have less lines of code. While I'm a fan of ternary expressions, they should not replace an if-statement.

Example:

Does not make sense to do this:

( val == 5 ) ? Func1() : Func2()

It is better for readability to do this:

if ( val == 5 )
    Func1()
else
    Func2()

They are best used in this type of scenario. Here you can avoid having formatex() twice in your code, whereas in LonDon's example, there is no benefit other than reducing code at the cost of readability.

formatex( str , charsmax( str ) , "Hello %s" , val==1 ? "bugsy" : "someone else" )

[lexzor]

Thanks bugsy!

what menu should i use and what benefits would be? idk what are the new menus

[Bugsy]

https://forums.alliedmods.net/showthread.php?t=46364

[lexzor]

is this required or i can simply use that method from first post ?

i mean when i was trying to use menu_additem the numbers had no colors. like the code was

"1. First item"

and i want to do something like this

"\r1. \wFirst item"

can i do this ?

EDIT: I seen that i can use this:

PHP Code:

 menu_setprop( iMenu, MPROP_NUMBER_COLOR, "\y" ); 


Thanks!

But how can i add an item that don't have any number?

[CrazY.]

But how can i add an item that don't have any number?

Either by using menu_addtext or breaking the line with the ^n just like the code below

menu_additem(menu, "Item 1^nItem 2")