[ish12321]

LoL

[Arkshine]

You could have long city name with unicode characters, though it probably doesn't happen often.
The GeoIP module uses 256k as buffer length to be large enough but 64 or 128 should be fine too I guess.
Not like it does matter for this plugin anyway.

@OP:

- new Array:gA_BannedCities = view_as<Array>(null);
Global variables are already initialized to 0 by default, you don't need to do that. You have also a define for that, Invalid_Array (0 as value).
- Don't create variables in a loop
- Don't hardcode the buffer max length, use charsmax() (macro for sizeof(var) - 1, and yeah in AMXX, you need to do -1, it's important)
- Instead of using an Array, you could use a Trie, and just checking the key with TrieKeyExists (less code, more efficient, even though it's probably trivial here).

What do you mean by "do not kick properly"?

[siriusmd99]

Some sugestions:

- Make command like amx_reloadbannedcities (it will reload cities to the trie)
- Make something like whitelist and blacklist. For example i want to allow only players from my city. Then i must find all cities in the world and add them to the list? I don't this it would be a good idea.
- Also, make countries ban too.

[HamletEagle]

The ideea is nice, the implementation... well, not the best:
-a trie would suit better than an array here
-an invalid file pointer will be 0, not -1(INVALID_HANDLE)
-no need to check both file exists and the fFile
-the for does not make much sense.
-never create variables inside a loop
-what's your problem with "kick" command?

Unapproved since section needs to be cleaned. PM me after you make the changes.