Senior Member
|
12-10-2013
, 16:37
Re: Knife Levels v1.0.
|
#11
|
Quote:
Originally Posted by Kia
PHP Code:
if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 1 ) { SetHamParamFloat(4, damage + 1 ) } if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 2 ) { SetHamParamFloat(4, damage + 2 ) } if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 3 ) { SetHamParamFloat(4, damage + 3 ) } if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 4 ) { SetHamParamFloat(4, damage + 4 ) } if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 5 ) { SetHamParamFloat(4, damage + 5 ) } if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 6 ) { SetHamParamFloat(4, damage + 6 ) } if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 7 ) { SetHamParamFloat(4, damage + 7 ) } if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 8 ) { SetHamParamFloat(4, damage + 8) } if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 9 ) { SetHamParamFloat(4, damage + 9 ) } if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 10 ) { SetHamParamFloat(4, damage + 10 ) } if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 11 ) { SetHamParamFloat(4, damage + 11 ) } if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 12 ) { SetHamParamFloat(4, damage + 12 ) } if ( is_valid_player( attacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 13 ) { SetHamParamFloat(4, damage + 13 ) }
This be can made better, and you know that.
PHP Code:
if(iLevel[id]==0) { new menu = menu_create( szItem, "Knife_Handler" ); menu_additem(menu, "\wNormal Knife [\yUNLOCKED\w]", "", 0 ); // Normal Knife menu_additem(menu, "\d???? ????? [\rLEVEL 1 REQUIRE\d]", "", 1 ); // Alien Knife menu_additem(menu, "\d?????? ?????? [\rLEVEL 2 REQUIRE\d]", "", 1 ); // Ellium Dagger menu_additem(menu, "\d???? ?????? [\rLEVEL 3 REQUIRE\d]", "", 1 ); // Dark Dagger menu_additem(menu, "\d??????????? ????? [\rLEVEL 4 REQUIRE\d]", "", 1 ); // Transparent Knife menu_additem(menu, "\d??????? ?????? [\rLEVEL 5 REQUIRE\d]", "", 1 ); // Genuine Dagger menu_additem(menu, "\d???? ????? [\rLEVEL 6 REQUIRE\d]", "", 1 ); // Hunt Blade menu_additem(menu, "\d?????? ????? [\rLEVEL 7 REQUIRE\d]", "", 1 ); // Shadow Blade menu_additem(menu, "\d??????????? ??? [\rLEVEL 8 REQUIRE\d]", "", 1 ); // Slaughterer Axe menu_additem(menu, "\d?????? ?????? [\rLEVEL 9 REQUIRE\d]", "", 1 ); // Golden Katana menu_additem(menu, "\d???????? ????? [\rLEVEL 10 REQUIRE\d]", "", 1 ); // Assasin's Blade menu_additem(menu, "\d?????????? [\rLEVEL 11 REQUIRE\d]", "", 1 ); // Lightsaber menu_additem(menu, "\d?????? ????????? ????? [\rLEVEL 12 REQUIRE\d]", "", 1 ); // Bloody Wolverine Claws menu_additem(menu, "\d?????? ??? [\rLEVEL 13 REQUIRE\d]", "", 1 ); // Proton Axe menu_setprop( menu, MPROP_EXIT, MEXIT_ALL ); menu_display( id, menu, 0 ); }
This one too, check for the Level and decide then what string to display, saves much code.
PHP Code:
case 0:{ SetKnife(id , 0) ColorChat(id,"The knife you chose is: ^4Normal Knife^1."); } case 1:{ SetKnife(id , 1) ColorChat(id,"The knife you chose is: ^4Alien Knife^1."); } case 2:{ SetKnife(id , 2) ColorChat(id,"The knife you chose is: ^4Ellium Dagger^1."); } case 3:{ SetKnife(id , 3) ColorChat(id,"The knife you chose is: ^4Dark Dagger^1."); } case 4:{ SetKnife(id , 4) ColorChat(id,"The knife you chose is: ^4Transparent Knife^1."); } case 5:{ SetKnife(id , 5) ColorChat(id,"The knife you chose is: ^4Genuine Dagger^1."); } case 6:{ SetKnife(id , 6) ColorChat(id,"The knife you chose is: ^4Hunt Blade^1."); } case 7:{ SetKnife(id , 7) ColorChat(id,"The knife you chose is: ^4Shadow Blade^1."); } case 8:{ SetKnife(id , 8) ColorChat(id,"The knife you chose is: ^4Slaughterer Axe^1."); } case 9:{ SetKnife(id , 9) ColorChat(id,"The knife you chose is: ^4Golden Katana^1."); } case 10:{ SetKnife(id , 10) ColorChat(id,"The knife you chose is: ^4Assasin's Blade^1."); } case 11:{ SetKnife(id , 11) ColorChat(id,"The knife you chose is: ^4Lightsaber^1."); } case 12:{ SetKnife(id , 12) ColorChat(id,"The knife you chose is: ^4Bloody Wolverine Claws^1."); } case 13:{ SetKnife(id , 13) ColorChat(id,"The knife you chose is: ^4Proton Axe^1."); }
Same for here.
You have much redundant code in your plugin, review your code and update it.
|
I know its a lot of necessary lines but Im ain't got any idea how to do this with less lines, if you can give me idea it will very helpfull thank's for this comment you are very help me.
and Thank's for all for telling me how to make it better your's comments are helping a lot, Im just beginer so thanks all its very helping to another stuff's really thank's.
Last edited by ShLuMieL; 12-10-2013 at 16:43.
|
|