[vamppa]

what would be the best performance friendly method to query client cvars ?

in example you can think about When to query and check cvars.
- on events vs set_task or vs get_gametime? or is it possible on get_user_aiming, something else ?

what checks to set before comparing the cvar value like.
- is_user_alive, is_user_hltv, is_user_bot

are there more ways how to check besides query_client_cvar?
get_cvar_string?

[fysiks]

get_user_aiming() is a function, not a forward or event. You need to be more specific about what exactly you are trying to do (less vague). Also, get_cvar_string() is for server-side cvars.

[vamppa]

what im trying to do is checking client cvars on the most lag free way.
am gathering knowledge before I wanted to start.
did some searching, programming n testing
so far I got

PHP Code:

#include <amxmodx>
#include <amxmisc>

public plugin_init() 
{
    register_plugin( "query cvar test" , "1.0" , "vamp" );
    register_event( "ItemPickup", "age_check_all_users_cvars", "b");
}
public client_putinserver(id) 
{
   check_specific_user_cvars(id);
   return PLUGIN_CONTINUE;
}
public age_cvar_check_fps_max(id, const szCvar, const szValue[]) 
{          
   new Float:fValue = str_to_float(szValue);
   if( fValue > 125.0 ) {  
   new name[32];
   get_user_name(id,name,31);
   client_print(0,print_chat,"Ehll - %s has been kicked for having more then 125 fps !", name);
   server_cmd("kick #%d for having more then 125 fps !", get_user_userid(id));
  }
}
public Netcvar( id , const cvar[], const szrValue[])
{
   client_print( 0 , print_chat , "value=%s" , szrValue );  
}
public check_specific_user_cvars(id) 
{
   query_client_cvar( id , "fps_max" , "age_cvar_check_fps_max" );
   query_client_cvar( id , "fps_modem" , "age_cvar_check_fps_max" );
   query_client_cvar( id , "cl_cmdrate" , "Netcvar" );
   return PLUGIN_CONTINUE;
}
public age_check_all_users_cvars () 
{
   new players[32], numplayers, id;
   get_players ( players, numplayers );
   for ( new i=0; i<numplayers; i++ ) {
   id=players[i];
   check_specific_user_cvars( id );
  }
} 


the idea: if a client cvar has the wrong value he/she will get kicked.
for fps_max good values would be 60,72,100,125.
right now I use the > but it should all be = 60,72,100,125 otherwise kick
so nobody would be able to use 81.3 fps or 250fps during a clanwar.

[rak]

PHP Code:

#include <amxmodx>

#define PLUGIN "Rates Check"
#define VERSION "1.0"
#define AUTHOR "[R]ak"

new Trie:Cvars
public plugin_init()
    register_plugin(PLUGIN, VERSION, AUTHOR)

public plugin_cfg() {
    Cvars = TrieCreate()
    TrieSetString(Cvars, "rate", "25000")
    TrieSetString(Cvars, "cl_updaterate", "101")
    TrieSetString(Cvars, "cl_cmdrate", "101")
}
public client_connect(id) { 
    if (!is_user_bot(id)) {
        query_client_cvar(id, "rate", "Cvar_Result")
        query_client_cvar(id, "cl_updaterate", "Cvar_Result")
        query_client_cvar(id, "cl_cmdrate", "Cvar_Result")
    }
        
} 

public Cvar_Result(id, const cvar[], const value[]) { 
    static value_check[6]
    
    TrieGetString(Cvars, cvar, value_check, charsmax(value_check))
    
    if(!equal(value, value_check))
        server_cmd("kick #%d ^"If you would enter to the server needs this rates; rate 25000; cl_updaterate 101; cl_cmdrate 101^"", get_user_userid(id))
} 


[vamppa]

thanks
how would I check a value 4 times if it is equal to a number?

PHP Code:

if(equal(value, 125))
return PLUGIN_CONTINUE;

if(equal(value, 100))
return PLUGIN_CONTINUE;

if(equal(value, 72))
return PLUGIN_CONTINUE;

if(equal(value, 60))
return PLUGIN_CONTINUE;

else 
server_cmd("kick #%d for having illegal fps value !", get_user_userid(id)); 


[jimaway]

PHP Code:


switch (value) {
  case 60, 72, 100, 125: {
    return PLUGIN_CONTINUE;
  }
  default: {
    server_cmd("kick #%d for having illegal fps value !", get_user_userid(id));
  }
} 


[rak]

PHP Code:

public Cvar_Result(id, const cvar[], const value[]) { 
    new iValue = str_to_num(value)
    
    if(iValue > 125)
        server_cmd("kick #%d for having illegal fps value !", get_user_userid(id))
        
} 


[feren02]

What if the cvar was aliased?

For example:
they typed /rate 99999
then
alias rate

What will happen with the query_client_cvar?


Thanks!

[fysiks]

Aliases are for the console so I suspect that it won't prevent the query from working. I'd recommend trying it and seeing what happens.