[Fearts]

After the last TF2 update the gamedata signatures I believe have broken for this plugin. If someone could fix this it would be very helpful.

[Mikusch]

Originally Posted by Fearts After the last TF2 update the gamedata signatures I believe have broken for this plugin. If someone could fix this it would be very helpful.

Valve changed something in CPopulationManager::FindPopulationFileByShort Name, so that signature needs updating, as well as the offset for g_pFullFileSystem.

Update these lines:

            "addr_g_pFullFileSystem"
            {
                "linux"
                {
                    "signature" "g_pFullFileSystem"
                    "read"    "0"
                }
                "windows"
                {
                    "signature" "CPopulationManager::FindPopulationFileByShortName"
                    "read"    "52"
                    "read"    "0"
                }
            }

"CPopulationManager::FindPopulationFileByShortName"
{
    "library"        "server"
    "windows"    "\x55\x8B\xEC\x81\xEC\x04\x01\x00\x00\x8D\x85\xFC\xFE\xFF\xFF\x56\x68\x04\x01\x00\x00\x6A\x00\x50\xE8\x2A\x2A\x2A\x2A\x8B\x75\x08"
}

[PC Gamer]

Originally Posted by Mikusch Valve changed something in CPopulationManager::FindPopulationFileByShort Name, so that signature needs updating, as well as the offset for g_pFullFileSystem. Update these lines:

Tested and confirmed working. Thanks Mikusch!

[Zethax]

I hope this doesn't count as advertising, but I made a repo for some custom attributes I'm making that use this plugin as a backbone. They can be applied onto custom weapons and base weapons alike.
also if I could get some criticism on the code itself that'd be GREAT

There's only one attribute in the repo at the time of writing, but I'm planning on adding more. Link

[FlaminSarge]

Of note, that I think 'ability doubletap teleport' isn't for teleporters, it instead causes you to teleport/'blink' in the direction you doubletap. Currently STAGING_ONLY in TF2 so probably can't function regardless.

[nosoop]

Originally Posted by Zethax also if I could get some criticism on the code itself that'd be GREAT

Since you asked, I'd highly recommend using my fork of TF2Attributes. It's able to use the game's own functions for calculating attribute values in aggregate, so you don't have to iterate over client / weapons for the same effect nor retrieve the values manually.

e.g. with kill_with_any_weapon_heals, you could drop the loop and simplify the code down to

int iHealAmount = TF2Attrib_HookValueInt(0, "health_on_kill_any_weapon", iAttacker);
HealPlayer(iAttacker, iHealAmount, 1.5);

[404UserNotFound]

Originally Posted by FlaminSarge Of note, that I think 'ability doubletap teleport' isn't for teleporters, it instead causes you to teleport/'blink' in the direction you doubletap. Currently STAGING_ONLY in TF2 so probably can't function regardless.

Likely correct, definitely something I need to look into for the TCRF.net "Development:Team_Fortress_2" article where I'm documenting the source code leak's staging build features. I definitely need to set a server up and mess with this plugin and get some footage of things.

[possibly_yaboi_mark]

Originally Posted by Mikusch Valve changed something in CPopulationManager::FindPopulationFileByShort Name, so that signature needs updating, as well as the offset for g_pFullFileSystem. Update these lines: "addr_g_pFullFileSystem" { "linux" { "signature" "g_pFullFileSystem" "read" "0" } "windows" { "signature" "CPopulationManager::FindPopulationFileByShortName" "read" "52" "read" "0" } } "CPopulationManager::FindPopulationFileByShortName" { "library" "server" "windows" "\x55\x8B\xEC\x81\xEC\x04\x01\x00\x00\x8D\x85\xFC\xFE\xFF\xFF\x56\x68\x04\x01\x00\x00\x6A\x00\x50\xE8\x2A\x2A\x2A\x2A\x8B\x75\x08" }

so, after installing this (into addons/sourcemod), my server crashes whenever it attempts to load the plugin, and seeing this and the fact i'm running a windows server, i assumed that i needed to add the above code into tf2hiddenattribs.sp. the problem is i have no idea how i'm supposed to read this post (im new here (signed up yesterday), and i'm historically bad at seeing small details only, so please humor me here). do i add these two bits of code somewhere (doesnt state where in the file)? do i need to replace one already existing code and place in the other (cant find the code im supposed to replace)? i generally cannot tell.

[PC Gamer]

Originally Posted by possibly_yaboi_mark do i add these two bits of code somewhere (doesnt state where in the file)? do i need to replace one already existing code and place in the other (cant find the code im supposed to replace)? i generally cannot tell.

Those were suggested edits to the tf2.hiddenattribs.txt gamedata file. I've edited it for you. You can place the attached edited tf2.hiddenattribs.txt file into your /sourcemod/gamedata/ folder.

Enjoy!

[Naydef]

It seems TF2 update (October 5, 2022) broke one of the signatures for Windows. I uploaded an updated gamedata file.