[Robotex]

I am writing a plugin that needs to know how many players are connected.

However I am not sure about these matters:

1. On map changes, do the functions GetNumPlayers/GetClientCount still return the number of players that haven't quitted the game and will be playing in next map?
2. In OnClientDisconnected, is the disconnected player still counted in GetNumPlayer/GetClientCount?

Thanks in advance.

[SytekBox]

Originally Posted by Robotex I am writing a plugin that needs to know how many players are connected. However I am not sure about these matters: On map changes, do the functions GetNumPlayers/GetClientCount still return the number of players that haven't quitted the game and will be playing in next map? In OnClientDisconnected, is the disconnected player still counted in GetNumPlayer/GetClientCount? Thanks in advance.

I could be wrong as i've been out of the game for long now (Used to do work on 1.7 and don't know much about 1. but i recall seeing in one of the Docs for 1.7 that the GetNumPlayers would retrieve the Total of Connected players, therefor if that's correct then relatively speaking OnClientDisconnected wouldn't be able to find said player (As it's not longer being counted due to being offline otherwise it would be a bit wrong to keep counting a Ghost -that's what i think-).

Of course, i've been away from SM in general for a long time and i could be wrong. Better wait for a more accurate and updated answer from one of this genius chaps at AM.

Nonetheless, you could've debugged the results in order to see if it's indeed like you think it is. That's the easiest way to find your answers

Have a good one

[RumbleFrog]

1. GetClientCount(bool inGameOnly) will include clients as they are passed through OnClientPutInServer() forward

2. I don't believe so.

[ambn]

You can also try this stock:

PHP Code:

int GetPlayerCount()
{
    int PlayerNumb = 0;
    for (int x = 1; x <= MaxClients; x++)
    {
        if(IsClientInGame(x) && !IsFakeClient(x))
        {
            PlayerNumb++;
        }
    }
    return PlayerNumb;
} 


[Robotex]

Well after some tests this is what I noticed:
1. GetClientCount returns the number of currently playing+connecting players, HOWEVER when a map change occurs it will return 0 because clients will be briefly disconnected (OnClientDisconnected is called).
2. In OnClientDisconnected the user that has left is not counted.

So my question now is, how can I get reliably the number of players when the map change triggers? I believe the server must know it because otherwise it would go on hibernation. Maybe querying the master server somehow?

[Chaosxk]

Yes GetClientCount will return 0 if called OnMapStart because clients will briefly disconnect and reconnect. Perhaps you can call OnMapEnd?
Or OnConfigsExecuted (should be called after OnMapStart). Or call an event (depending on your game) such as round start or something? Or create a 2/3/4 second timer OnMapStart?

[Robotex]

Originally Posted by Chaosxk Yes GetClientCount will return 0 if called OnMapStart because clients will briefly disconnect and reconnect. Perhaps you can call OnMapEnd? Or OnConfigsExecuted (should be called after OnMapStart). Or call an event (depending on your game) such as round start or something? Or create a 2/3/4 second timer OnMapStart?

Is OnMapEnd called when all players disconnect in middle of game? I cannot use any OnXXXXStart simply because... there won't be any called! My plugin has the objective of running a "quit" command once nobody is playing as part of a self updating infrastructure.
So speaking back about the idea of querying the Master server, I have noticed that an another extension called Left4Downtown2 hooks the value in CBaseServer::GetMasterServerPlayerCounts but I cannot find any reference on the net of that method in other games so it seems that won't be portable.
My other thought now is hooking an "OnHibernate" event that is fired only when it's really empty, however it seems there's none exported from SourceMod by default, which uses it in PlayerManager::OnServerHibernationUpdate..

// EDIT:
I guess I can exclude OnServerHibernationUpdate because for some reason hooking it breaks up the engine in an endless reboot..