[Visual77]

Hi. There seems to be a lot of confusion regarding whether you should close handles created by CreateEvent or not. I would like to know the one and only way. The documentation says:

The Handle should not be closed via CloseHandle(). It must be closed via event.Fire() or event.Cancel().

Sourcemod api says:

Event.FireToClient Method - Fires a game event to only the specified client. Unlike Fire, this function DOES NOT close the event Handle. Event.Fire Method - This function closes the event Handle after completing.

So if I'm reading correctly, this would appear right?

stock void CreateDeathEvent(int victim, int attacker, const char[] sWeapon = "",  bool toAll)
{
	Event event = CreateEvent("player_death");

	if (event != null)
	{
		event.SetInt("userid", GetClientUserId(victim));
		event.SetInt("attacker", GetClientUserId(attacker));
		event.SetString("weapon", sWeapon);

		if (toAll)
		{
			event.Fire(false);

			/* Event.Fire closes the handle automaticlly. I don't need to clear the handle here. */
		}
		else
		{
			if (IsValidClient(victim))
			{
				event.FireToClient(victim); 
			}

			if (IsValidClient(attacker) && attacker != victim) 
			{
				event.FireToClient(attacker);
			}

                        /* The documentation says not to close the handle using CloseHandle which is equivalent to delete handle, so the handle is deleted using what the documentation says. */

                       event.Cancel();  // I've now deleted the handle?  

		}
	}
}

[cravenge]

That seems about right.

[Neuro Toxin]

Does the event get received when fired to client after cancel is called?

If == true
What you're doing would be the right way.

[asherkin]

At least since FireToClient was added, CloseHandle/delete is equivalent to Event.Cancel, so either should be good.

[Visual77]

Originally Posted by Neuro Toxin Does the event get received when fired to client after cancel is called? If == true What you're doing would be the right way.

Not had time to try if that is true yet. I looked at so many plugins and most of them left the handle to be stored in memory, so I did the same.

Originally Posted by asherkin At least since FireToClient was added, CloseHandle/delete is equivalent to Event.Cancel, so either should be good.

Thanks, that's good to know.

I have two more question. The wiki says to use the Event.Cancel on events that aren't fired. What scenario makes an event not fire, creating another unexpected leak?

Looking at my code. If I send my DeathEvent to the atacker and the victim only, then the other players on the server won't see the public kill announcment, right?

[cravenge]

Originally Posted by Visual77 What scenario makes an event not fire, creating another unexpected leak?

When either one of the players leave, thus invalidating their userid. It could also be when using timers to delay the firing of the event.

Originally Posted by Visual77 then the other players on the server won't see the public kill announcment, right?

Yes. It will only show to the two players involved in the event.

[Visual77]

Originally Posted by cravenge When either one of the players leave, thus invalidating their userid. It could also be when using timers to delay the firing of the event.

Ok. I'm already validating the client before sending the event, so I shouldn't have to worry.

Originally Posted by cravenge Yes. It will only show to the two players involved in the event.

Great! Thanks guys.