[Papero]

Hi,
Now I want to be sure what "delete" actually does. like if I do:

PHP Code:

delete TimerHandle; 


I need to check if Handle is " != null " ?
I need to set to to " null " after the delete ?

If the second is: no, why (for example) here they did it " = null "


And this is just out of curiosity, does "delete" 'calls' "CloseHandle" right? Because in some error logs i've found Invalid Handle (error), in the line of "delete" 'reporting CloseHandle as function'


Last think:
What's the main difference between using:

PHP Code:

delete TimerHandle;
CloseHandle(TimerHandle);
KillTimer(TimerHandle); 


[Kailo]

PHP Code:

delete X; 


This equal

PHP Code:

CloseHandle(X);
X = null; 


Read more

I wrote sample

PHP Code:

Handle g_var;

public void OnPluginStart()
{
    delete g_var;
} 


Opcode of this sample is

proc // start of OnPluginStart
break
break
load.pri 2220 // load g_var adress to primary register
push.pri // pass (push in stack) g_var as 1st parametr for CloseHandle call
sysreq.n 2 1 // Call CloseHandle
zero 2220 // Set g_var to 0
zero.pri 
retn

PHP Code:

CloseHandle(Handle hndl); 


Just close handle.

PHP Code:

KillTimer(Handle timer, bool autoClose = false); 


"If autoClose is true, the data that was passed to CreateTimer() will be closed as a handle if TIMER_DATA_HNDL_CLOSE was not specified."
If autoClose is false, equal to CloseHandle().
Overwise will call CloseHandle on data before close timer handle.

By the way, Handle is methodmap for now and have Handle.Close() method, that can be called on all "handled" types.

PHP Code:

Handle g_var;

public void OnPluginStart()
{
    g_var.Close();
} 


P.S. In case if you no matter to set variable to 0, like in menu callback. Calling close will more effective.

PHP Code:

public int MenuHandler(Menu menu, MenuAction action, int param1, int param2)
{
    if (action == MenuAction_End)
        menu.Close();
} 


[Papero]

Thanks for the reply,

So, makes no sense what they (AM Developers) did here?

[ddhoward]

Originally Posted by Papero Thanks for the reply, So, makes no sense what they (AM Developers) did here?

That's probably just an oversight. The plugins were all written in the old syntax before being converted over to the new syntax. Line 381 is not necessary there.

[Fyren]

In general, the base plugins were converted through basically automated find and replace.

[asherkin]

It is sad to say, but the base plugins should not really be used as a reference in any way.

Large portions of the code are absolutely awful, while they generally work fine, they're all very old from the very early days of SourceMod and do not get much love.

[asherkin]

Originally Posted by Kailo PHP Code: delete X;  This equal PHP Code: CloseHandle(X); X = null;

Not quite, it is equivalent to

PHP Code:

if (X != null) {
  CloseHandle(X);
  X = null;
} 


[Kailo]

Originally Posted by asherkin Not quite, it is equivalent to PHP Code: if (X != null) {   CloseHandle(X);   X = null; }

hmm... I'm not sure about it. SM 1.8. May be in 1.9 this is so.

Originally Posted by Kailo I wrote sample PHP Code: Handle g_var; public void OnPluginStart() {     delete g_var; }  Opcode of this sample is proc // start of OnPluginStart break break load.pri 2220 // load g_var adress to primary register push.pri // pass (push in stack) g_var as 1st parametr for CloseHandle call sysreq.n 2 1 // Call CloseHandle zero 2220 // Set g_var to 0 zero.pri retn