Raised This Month: $32 Target: $400
 8% 

Gameme plugin creates duplicate hooks and timers!


Post New Thread Reply   
 
Thread Tools Display Modes
Author Message
`666
AlliedModders Donor
Join Date: Jan 2006
Old 11-15-2021 , 22:41   Gameme plugin creates duplicate hooks and timers!
Reply With Quote #1

nvm

Last edited by `666; 11-17-2021 at 22:26.
`666 is offline
Marttt
Veteran Member
Join Date: Jan 2019
Location: Brazil
Old 11-16-2021 , 09:07   Re: Gameme plugin creates duplicate hooks and timers!
Reply With Quote #2

last commit 2019.
I believe there is no support at least on this repo, anyway thanks for reporting.
Maybe you should report which game has this behaviour, cause on L4D/2 I don't see much issues
__________________
Marttt is offline
`666
AlliedModders Donor
Join Date: Jan 2006
Old 11-16-2021 , 09:50   Re: Gameme plugin creates duplicate hooks and timers!
Reply With Quote #3

Quote:
Originally Posted by Marttt View Post
last commit 2019.
I believe there is no support at least on this repo, anyway thanks for reporting.
Maybe you should report which game has this behaviour, cause on L4D/2 I don't see much issues
Duplicate hooks (unless some games unhook hookevents on map change?) for all games and and timer only for: L4D, L4DII and insurgency.
`666 is offline
asdfxD
Veteran Member
Join Date: Apr 2011
Old 11-17-2021 , 00:36   Re: Gameme plugin creates duplicate hooks and timers!
Reply With Quote #4

i use gameme in csgo, does this effect the performance in any way?

get_server_mod();

thats all i should remove?

edit: done & uploaded

Last edited by asdfxD; 11-17-2021 at 00:42.
asdfxD is offline
`666
AlliedModders Donor
Join Date: Jan 2006
Old 11-17-2021 , 08:57   Re: Gameme plugin creates duplicate hooks and timers!
Reply With Quote #5

Yes, just one line.
It does because with each map change you going to have extra set of these hooks
Code:
				HookEvent("weapon_fire",  		   	      Event_CSGOPlayerFire);
				HookEvent("weapon_fire_on_empty",  	      Event_CSGOPlayerFire);
				HookEvent("player_hurt",     	  		  Event_CSGOPlayerHurt);
				HookEvent("player_death", 			      Event_CSGOPlayerDeath);
				HookEvent("player_spawn",		     	  Event_CSGOPlayerSpawn);
				HookEvent("round_start",   	   	   	      Event_CSGORoundStart);
				HookEvent("round_end",       		  	  Event_CSGORoundEnd);
				HookEvent("round_announce_warmup",        Event_CSGOAnnounceWarmup);
				HookEvent("round_announce_match_start",   Event_CSGOAnnounceMatchStart);
				HookEvent("gg_player_levelup",            Event_CSGOGGLevelUp);
				HookEvent("ggtr_player_levelup",          Event_CSGOGGLevelUp);
				HookEvent("ggprogressive_player_levelup", Event_CSGOGGLevelUp);
				HookEvent("gg_final_weapon_achieved",     Event_CSGOGGWin);
				HookEvent("gg_leader",                    Event_CSGOGGLeader);
				HookEvent("round_mvp",                    Event_RoundMVP);

				HookEvent("bomb_dropped",		 	 gameME_Event_PlyBombDropped, EventHookMode_Pre);
				HookEvent("player_given_c4",     	 gameME_Event_PlyBombPickup,  EventHookMode_Pre);
				HookEvent("bomb_planted",    		 gameME_Event_PlyBombPlanted, EventHookMode_Pre);
				HookEvent("bomb_defused",    		 gameME_Event_PlyBombDefused, EventHookMode_Pre);
				HookEvent("hostage_killed",  		 gameME_Event_PlyHostageKill, EventHookMode_Pre);
				HookEvent("hostage_rescued", 		 gameME_Event_PlyHostageResc, EventHookMode_Pre);

Last edited by `666; 11-17-2021 at 08:58.
`666 is offline
asherkin
SourceMod Developer
Join Date: Aug 2009
Location: OnGameFrame()
Old 11-17-2021 , 19:14   Re: Gameme plugin creates duplicate hooks and timers!
Reply With Quote #6

https://github.com/gamemedev/plugin-...gameme.sp#L986

It checks if the mod has already been detected before doing any of that logic, so it won't re-enter it multiple times.
__________________
asherkin is offline
`666
AlliedModders Donor
Join Date: Jan 2006
Old 11-17-2021 , 22:25   Re: Gameme plugin creates duplicate hooks and timers!
Reply With Quote #7

doh lol
`666 is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 05:54.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode