[delayedCoder]

x2 First Blood
Version: 0.3
Author: delayedCoder



Description:
When first blood is drawn, the attacker gets double the kill points instead of one.



Requirements:
- AMX Mod X 1.8.0 or above
- Ham Sandwich Module enabled



Changelog:
Version 0.1:
- initial release

Version 0.2:
- cleaned up code
- removed 'fun' module by using hamsandwich

Version 0.3:
- added a check to ensure that there is no loopholes
- added team check
- added suicide check

[bibu]

- You can easily avoid of using the hamsandwich module here.
- You can remove <amxmisc> , it isn't needed.
- You should have some checks, like that the attacker can be a Non-Player entity.

Would look like this:

PHP Code:

#include <amxmodx>
#include <fun>

#define VERSION    "0.1"

new bool:firstBlood = true;

new g_iMaxPlayers;
#define IsPlayer(%1)    ( 1 <= %1 <= g_iMaxPlayers )

public plugin_init()
{
    register_plugin("x2 First Blood", VERSION, "delayedCoder");
    
    register_event("DeathMsg","hook_death","a");
    register_event("HLTV", "newRound", "a", "1=0", "2=0");
    
    g_iMaxPlayers = get_maxplayers()
}

public hook_death()
{
    if (firstBlood)
    {
        new attacker = read_data(1);
        
        if(IsPlayer(attacker) && is_user_connected(attacker))
        {
            set_user_frags(attacker, get_user_frags(attacker) + 2);
        
            firstBlood = false;
        }
    }
}

public newRound()
{
    firstBlood = true;
} 


[drekes]

Originally Posted by bibu - You can easily avoid of using the hamsandwich module here.

What's wrong with ham ?
DeathMsg can be altered or faked by other plugins (jb for example).

[Honors]

Originally Posted by bibu PHP Code: set_user_frags(attacker, get_user_frags(attacker) + 2);

The game Counter-Strike already add 1 frag when killing an enemy. If you add 2 frags, they will win 3 frags. I'm wrong ?

[bibu]

Originally Posted by Honors The game Counter-Strike already add 1 frag when killing an enemy. If you add 2 frags, they will win 3 frags. I'm wrong ?

Yes wanted to point that out too, forgot it.

To drekes:

I don't have anything against ham, just in this case it isn't needed IMO. And what do you mean with altering and faking DeathMsg?

[drekes]

Originally Posted by bibu Yes wanted to point that out too, forgot it. To drekes: I don't have anything against ham, just in this case it isn't needed IMO. And what do you mean with altering and faking DeathMsg?

I think ham is more reliable in this case.

From messages.inc:

/* These are the same as above, except that the messages sent
 *  are also sent to all other plugins and Metamod plugins.
 * This means that if you send one of these messages, other plugins will
 *  be notified, which was previously impossible.  
 * BE CAREFUL! Using these incorrectly, or not for their intended purpose,
 *  could cause infinite recursion or something just as bad. 
 * NOTE! These natives are experimental.
 */
native emessage_begin(dest, msg_type, const origin[3] = {0,0,0}, player = 0);
native emessage_end();
native ewrite_byte(x);
native ewrite_char(x);
native ewrite_short(x);
native ewrite_long(x);
native ewrite_entity(x);
native ewrite_angle(x);
native ewrite_coord(x);
native ewrite_string(const x[]);

If a plugin send a msg with these, this plugin will also be triggered & give frags when it isn't necessary (depending on the code)

Also in lots of Jailbreak plugins, DeathMsg is registered using register_message() & the attacker id is changed to 0 to hide the terrorist's kills. This also may be a problem.

[bibu]

Who cares about JB?

[Shadymn]

Originally Posted by Honors The game Counter-Strike already add 1 frag when killing an enemy. If you add 2 frags, they will win 3 frags. I'm wrong ?

eagle eye

[drekes]

Originally Posted by bibu Who cares about JB?

It was just an example. Any plugin / mod can alter or fake it.

[ConnorMcLeod]

If ham is enabled, you can use Ham_AddPoint instead of get_user_frags + set_user_frags.