Raised This Month: $ Target: $400
 0% 

Stay On Feet v1.63 [Mod]


Post New Thread Reply   
 
Thread Tools Display Modes
D a N i
New Member
Join Date: Feb 2015
Old 03-24-2015 , 15:35   Re: Stay On Feet [Mod]
Reply With Quote #11

Thank you mentioned. I'll help where I can
D a N i is offline
DeteCT0R
Member
Join Date: Jun 2012
Location: My Home
Old 03-25-2015 , 03:34   Re: Stay On Feet [Mod]
Reply With Quote #12

Great job! Looks like fun
__________________
My steam:
DeteCT0R is offline
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 03-26-2015 , 13:14   Re: Stay On Feet [Mod]
Reply With Quote #13

Well, just some ideeas:
  • Can you please name your variables in english ? It makes easier to read and understand your code
  • Do not hardcode configs dir path(FajlUt[]), you have natives to retrieve it.
  • In plugin_precache you can create just one variable(a or b) and use it two times, in both loops.
  • new PalyaNev[12]; should be 32, not 12.
  • I guess that check if(equali(PalyaNev, "stayonfeet_")) is to see if mod can run on that map. If it is not passed just pause the plugin, else register all the stuffs.
  • FM_Touch is killing server resources, look for alternative in hamsandwich and engine.
  • If I'm not wrong, gravity doesn't reset, set it just one time, no need of doing this in CurWeapon. Also, for speed setting, you can go for Ham_Item_PreFrame, which is a bit better. Also, indent your code.
  • static in a client command is misused.
  • Since you don't use menu info param, this is useless:
    PHP Code:
    new data[9], name[64], Gomb;
        new 
    accesscallback;
        
    menu_item_getinfo(menuitemaccessdata,charsmax(data),
        
    namecharsmax(name), callback); 
  • get_pcvar_float already returns a float, tagging it again is not needed.
  • Ever heard of switch instead of a lot of if's ?
  • PHP Code:
    else
            {
                
    set_dhudmessage(255420, -1.00.7006.03.0);
                
    show_dhudmessage(id"%L"LANG_SERVER"NINCSELEGDOLLAROD");
            } 
    this keeps repeting, put it just one time.
  • PHP Code:
    get_user_msgid("Money"
    the value won't change, you can cache it in a global variable and use it's value.
  • Instead of using offset values, use offset names, so everyone can know what are you doing.
  • Egbolt seems to be useless, work directly with SkyBox[random(sizeof(SkyBox))]
  • When not formating in the same buffer from where you get values, use formatex and not format.
  • set_fail_state can format a string from 1.8.3 version of amxx. You can add support for that, I mean, format only if AMXX_VERSION_NUM < 183, else work directly with the native.
  • Do not hardcode string size, can use charsmax() to get it.
  • You get already map name in plugin_init, save it into a global variable to use it later, so you avoid calling get_mapname again.
  • This can be cached get_cvar_pointer("sv_restart")
  • You call Hud() function often, it would be a good ideea to make vars static.
  • Make sure Deszka entity is valid before doing anything to it.
  • As I said, don't use FM_Touch. At least, make strings static.

Maybe there are more things to fix, but this is what I saw at a quick look.
__________________

Last edited by HamletEagle; 03-27-2015 at 10:50.
HamletEagle is offline
jingojang
Senior Member
Join Date: Feb 2010
Location: The Moon
Old 03-26-2015 , 13:38   Re: Stay On Feet [Mod]
Reply With Quote #14

Really nice idea man. I might have some ideas for you that I will share later on.

EDIT: The plugin is not removing the boards when stepped on. At least not for me, maybe I forgot something. The plugins seem to be running.

Regards,
Jingo
__________________

Last edited by jingojang; 03-26-2015 at 14:09.
jingojang is offline
DeRoiD
Senior Member
Join Date: Feb 2015
Old 03-26-2015 , 17:53   Re: Stay On Feet [Mod]
Reply With Quote #15

Thanks HamletEagle!
DeRoiD is offline
ACM1PT
Member
Join Date: Feb 2014
Location: Argentina
Old 03-26-2015 , 22:03   Re: Stay On Feet [Mod]
Reply With Quote #16

Spanish translation
Attached Files
File Type: zip data.zip (1.6 KB, 85 views)
ACM1PT is offline
claudiuhks
Yam Inside®™℠
Join Date: Jan 2010
Location: Living Randomly
Old 03-27-2015 , 08:15   Re: Stay On Feet [Mod]
Reply With Quote #17

Quote:
Originally Posted by HamletEagle View Post
FM_Touch is killing server resources, look for alternative in hamsandwich and engine.
?

There are no server resources managed in FM_Touch, but entities.
__________________

Last edited by claudiuhks; 03-27-2015 at 08:17.
claudiuhks is offline
Send a message via MSN to claudiuhks Send a message via Yahoo to claudiuhks Send a message via Skype™ to claudiuhks
Jhob94
AMX Mod X Donor
Join Date: Jul 2012
Old 03-27-2015 , 09:59   Re: Stay On Feet [Mod]
Reply With Quote #18

Quote:
Originally Posted by claudiuhks View Post
?

There are no server resources managed in FM_Touch, but entities.
I guess that he meant cpu.
__________________
Jhob94 is offline
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 03-27-2015 , 10:49   Re: Stay On Feet [Mod]
Reply With Quote #19

Quote:
Originally Posted by claudiuhks View Post
?

There are no server resources managed in FM_Touch, but entities.
It is easy to understand what I mean, no need to think too much. I don't know what you understood, but I was talking about CPU.
__________________
HamletEagle is offline
claudiuhks
Yam Inside®™℠
Join Date: Jan 2010
Location: Living Randomly
Old 03-27-2015 , 11:36   Re: Stay On Feet [Mod]
Reply With Quote #20

Quote:
Originally Posted by Jhob94 View Post
I guess that he meant cpu.
Quote:
Originally Posted by HamletEagle View Post
It is easy to understand what I mean, no need to think too much. I don't know what you understood, but I was talking about CPU.
Even that, where did you find such Coding-related information that it's not recommended to use FM_Touch in order to avoid excessive CPU usage? I'd also like to read that.

There are a lot of plug-ins using FM_AddToFullPack which actually requires much more CPU to execute code.

@DeRoiD

There is no such language ("Roman") as there is no ("Hungar"). You probably mean ("Romanian").

And here is the correct translation:

Code:
[ro]
LEESSIK = %s a căzut!
NINCSELEGJATEKOS = Nu sunt destui jucători pentru a începe!
KEZDOUZENET = Jocul începe în %d secunde.
SIKERESVASARLAS = Achiziţionat cu succes!
NINCSELEGDOLLAROD = Nu aveţi destui dolari!
TULELOK = Supravieţuitor(i): %s
NINCSTULELOK = Niciun supravieţuitor!
HUD = Supravieţuitor(i): %d/%d^nPlăci rămase: %d
BOLTCIM = \wStay on your feet!\r Dolar(i):\d %d
BOLT1 = \y>> \rGravitaţie puţină \d3$
BOLT2 = \y>> \rMai multă viteză \d3$
BOLT3 = \y>> \rAbilitate de trecere prin pereţi \d6$
BOLT4 = \y>> \dNu cumpăr nimic!
JATEKVAN = Jocul rulează. Nu vă alăturaţi, aşteptaţi sfârşitul rundei!
And anyways, are you even testing your languages before updating? There were wrong %d and %s formatting rules.
__________________

Last edited by claudiuhks; 03-27-2015 at 11:55.
claudiuhks is offline
Send a message via MSN to claudiuhks Send a message via Yahoo to claudiuhks Send a message via Skype™ to claudiuhks
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 11:49.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode