[Bugsy]

Do some debugging before even posting for help. There has to be an issue with your code as I've been using nVault for years this way.

[fysiks]

Originally Posted by Supremache I mean if I have stopped the server using host or the server has shutdown the data doesn't get saved

plugin_end(), client_disconnect(), and client_disconnected() are all called when the server is shut down properly (i.e. using the "quit" or "exit" commands in console. If the process is killed at the operating system level or the process has a legitimate crash then it obviously won't.

So, maybe your host's script is improperly shutting down the server or your server is actually crashing (neither of which should happen on any regularity and generally can be ignored). Why would you be shutting down the server via that host while people are playing? These situations should be very very rare and if they are not something is wrong with either your process or you need to fix a crashing issue.

[Supremache]

I think my plugin isn't having any issues!, It's saving the data when the players get "exit, drop, kick, ban, timeout, etc" but it's not saving the data just when the server get shut down I was think nvault working like that but when @bugsy said plugin_end is calling when the server get shutdown so I said there is a solution for this !

[fysiks]

huh . . what?

[Bugsy]

You are saving player data at disconnect. You are closing the vault at plugin_end.

When a shutdown occurs, disconnect should be called on all, resulting in their data getting saved, and shortly after, plugin_end should get executed.

[Supremache]

Every time when i use nvault for saving the data, it's only save the data when the player get "disconnect, drop, timeout, kick and when i add the function of save data to other function" and doesn't save it when the server get shutdown.

[Supremache]

Originally Posted by Bugsy You are saving player data at disconnect. You are closing the vault at plugin_end. When a shutdown occurs, disconnect should be called on all, resulting in their data getting saved, and shortly after, plugin_end should get executed.

But why that never happening and my plugin doesn't have any issues with vault codes

[Bugsy]

Something else must be bad in your code.

I ran this plugin on a map change and then shutting down the server, both responded the same.

PHP Code:

public plugin_end()
{
    log_amx( "plugin end called" );
}

public client_disconnect( id )
{
    log_amx( "disconnect called on %d" , id );
} 


L 08/01/2021 - 21:19:57: [untitled.amxx] disconnect called on 1
L 08/01/2021 - 21:19:57: [untitled.amxx] disconnect called on 2
L 08/01/2021 - 21:19:57: [untitled.amxx] disconnect called on 3
L 08/01/2021 - 21:19:57: [untitled.amxx] disconnect called on 4
L 08/01/2021 - 21:19:57: [untitled.amxx] disconnect called on 5
L 08/01/2021 - 21:19:57: [untitled.amxx] plugin end called

L 08/01/2021 - 21:20:15: [untitled.amxx] disconnect called on 1
L 08/01/2021 - 21:20:15: [untitled.amxx] disconnect called on 2
L 08/01/2021 - 21:20:15: [untitled.amxx] disconnect called on 3
L 08/01/2021 - 21:20:15: [untitled.amxx] disconnect called on 4
L 08/01/2021 - 21:20:15: [untitled.amxx] disconnect called on 5
L 08/01/2021 - 21:20:15: [untitled.amxx] plugin end called

[Shadows Adi]

Extracted from: https://github.com/alliedmodders/amx....cpp#L692-L747

// Call plugin_end forward function  from plugins.
void C_ServerDeactivate()
{
    if (!g_activated)
        RETURN_META(MRES_IGNORED);

    for (int i = 1; i <= gpGlobals->maxClients; ++i)
    {
        CPlayer *pPlayer = GET_PLAYER_POINTER_I(i);

        if (pPlayer->initialized)
        {
            // deprecated
            executeForwards(FF_ClientDisconnect, static_cast<cell>(pPlayer->index));
            if (g_isDropClientHookAvailable && !pPlayer->disconnecting)
            {
                executeForwards(FF_ClientDisconnected, static_cast<cell>(pPlayer->index), FALSE, prepareCharArray(const_cast<char*>(""), 0), 0);
            }
        }

        if (pPlayer->ingame)
        {
            auto wasDisconnecting = pPlayer->disconnecting;

            pPlayer->Disconnect();
            --g_players_num;

            if (!wasDisconnecting && g_isDropClientHookAvailable)
            {
                executeForwards(FF_ClientRemove, static_cast<cell>(pPlayer->index), FALSE, const_cast<char*>(""));
            }
        }
    }

    if (g_isDropClientHookAvailable)
    {
        if (g_isDropClientHookEnabled)
        {
            if (RehldsApi)
            {
                RehldsHookchains->SV_DropClient()->unregisterHook(SV_DropClient_RH);
            }
            else
            {
                DropClientDetour->DisableDetour();
            }
            g_isDropClientHookEnabled = false;
        }
    }

    g_players_num   = 0;
    executeForwards(FF_PluginEnd);
    RETURN_META(MRES_IGNORED);
}

[Supremache]

Well, I dont know which wrong in my plugin that making the data doesn't save when the server got shutdown but i will do debugs to find the issue.

Thanks..!