[King_OXO]

̶C̶o̶u̶l̶d̶ ̶y̶o̶u̶ ̶c̶r̶e̶a̶t̶e̶ ̶r̶e̶t̶u̶r̶n̶s̶ ̶t̶o̶ ̶d̶e̶t̶e̶c̶t̶ ̶t̶h̶e̶ ̶v̶i̶c̶t̶i̶m̶s̶ ̶o̶f̶ ̶t̶h̶e̶ ̶i̶n̶f̶e̶c̶t̶e̶d̶?̶


Found

[NeoTM]

I got this error at startup but the server look fine.

Spoiler

L 06/28/2023 - 13:47:55: SourceMod error session started
L 06/28/2023 - 13:47:55: Info (map "c1m2_streets") (file "/home/test/l4d2/left4dead2/addons/sourcemod/logs/errors_20230628.log")
L 06/28/2023 - 13:47:55: [DHOOKS] Function "ForEachSurvivor<ClosestSurvivorDistanceScan> " doesn't have a "signature", "offset" nor "address" set: line: 41 col: 4
L 06/28/2023 - 13:49:08: Error log file session closed.

Is that important?

[cravenge]

Originally Posted by NeoTM I got this error at startup but the server look fine. Spoiler L 06/28/2023 - 13:47:55: SourceMod error session started L 06/28/2023 - 13:47:55: Info (map "c1m2_streets") (file "/home/test/l4d2/left4dead2/addons/sourcemod/logs/errors_20230628.log") L 06/28/2023 - 13:47:55: [DHOOKS] Function "ForEachSurvivor<ClosestSurvivorDistanceScan> " doesn't have a "signature", "offset" nor "address" set: line: 41 col: 4 L 06/28/2023 - 13:49:08: Error log file session closed. Is that important?

That's from my plug-in. It has nothing to do with this one.

[Sev]

Error

[left4dhooks.smx] Native L4D2_GetSurvivorSetMap should not be used before OnMapStart, please report to 3rd party plugin author.

[Spirit_12]

Hey Silver I noticed that you added the following forwards that can block the round end.

PHP Code:

// Called before score calculations and the scoreboard display
forward Action L4D2_OnEndVersusModeRound(bool countSurvivors);

// Called after all score calculations are complete and the scoreboard shows
forward void L4D2_OnEndVersusModeRound_Post();

// Called after all score calculations are complete and the scoreboard shows
// Only called when relative pre-hook is blocked by a plugin with return Plugin_Handled
forward void L4D2_OnEndVersusModeRound_PostHandled(); 


This created a challenge for me as once you block the round end it completely removes the condition and you have no way to end the round. Since all the signatures are shared, can you add a SDK call native to end the round as well?

I did the testing and the following code worked for me. This is partial code, but you already have the rest of the framework so it should work.

PHP Code:

    g_pDirector        = hGameData.GetAddress("CDirector");
    g_pVersusMode    = hGameData.GetOffset("VersusModePtr");
    g_pVersusMode    = LoadFromAddress(g_pDirector + view_as<Address>(g_pVersusMode), NumberType_Int32);
    
    StartPrepSDKCall(SDKCall_Raw);
    if( PrepSDKCall_SetFromConf(hGameData, SDKConf_Signature, "CDirectorVersusMode::EndVersusModeRound") == false )
    {
        LogError("Failed to find signature: \"CDirectorVersusMode::EndVersusModeRound\"");
    } else {
        PrepSDKCall_AddParameter(SDKType_Bool, SDKPass_Plain);
        PrepSDKCall_SetReturnInfo(SDKType_PlainOldData, SDKPass_Plain);
        g_hSDK_CDirectorVersusMode_EndVersusModeRound = EndPrepSDKCall();
        if( g_hSDK_CDirectorVersusMode_EndVersusModeRound == null )
            LogError("Failed to create SDKCall: \"CDirectorVersusMode::EndVersusModeRound\"");
    } 


Here is the actual call.

PHP Code:

SDKCall(g_hSDK_CDirectorVersusMode_EndVersusModeRound, g_pDirector, countSurvivors); 


I also noticed that the description isn't super clear here.

PHP Code:

// Called before score calculations and the scoreboard display
forward Action L4D2_OnEndVersusModeRound(bool countSurvivors); 


I would suggest adding more detail to the bool.

• 0 - Survivors didn't make it to saferoom.
• 1 - Survivors made to the saferoom

[Silvers]

Originally Posted by Spirit_12 This created a challenge for me as once you block the round end it completely removes the condition and you have no way to end the round. Since all the signatures are shared, can you add a SDK call native to end the round as well? I did the testing and the following code worked for me. This is partial code, but you already have the rest of the framework so it should work.

I added the native L4D_EndVersusModeRound but calling it only ends the first round, it does not end the second.

[Spirit_12]

Originally Posted by Silvers I added the native L4D_EndVersusModeRound but calling it only ends the first round, it does not end the second.

By first round you mean before the teams switch from survivor and infected right? If so then that's perfect and should be done that way.

Thanks!

[Silvers]

1.134 (10-Jul-2023)
    - Added "POINTER_SURVIVALMODE" enum for the "L4D_GetPointer" native to return the SurvivalMode pointer.
    - Added "L4D2CT_SurvivalSetupTimer" to the "L4D2CountdownTimer" enum for use with the "L4D2_CTimer*" natives.
    - Added stock "L4D_SetPlayerTempHealthFloat" to the "left4dhooks_stocks.inc" include file to set a players temporary health above 200 HP. Thanks to "Eyal282" for the code.
    - Added forwards "L4D_TankRock_BounceTouch", "L4D_TankRock_BounceTouch_Post" and "L4D_TankRock_BounceTouch_PostHandled" when a tank rock collides with something. Thanks to "Forgetest" for the code.
    - Added natives "L4D2_GetSurvivalStartTime" and "L4D2_SetSurvivalStartTime" to get and set the Survival start time. Requested by "Forgetest".
    - Added native "L4D2_SpawnAllScavengeItems" to spawn all Scavenge items. Thanks to "Eyal282" for some of the code and changes.
    - Added native "L4D2_Rematch" to restart a Versus game. Thanks to "Eyal282" for some of the code and changes.
    - Added native "L4D_EndVersusModeRound" to end the Versus round. Thanks to "Spirit_12" for some of the code and changes.
    - Fixed native "L4D2_Charger_StartCarryingVictim" removing teleporting and placement position bug. Thanks to "HarryPotter" for reporting.
    - Fixed L4D2 GameData offset for "L4D2_GetFirstSpawnClass" and "L4D2_SetFirstSpawnClass" natives. Thanks to "Forgetest" for reporting the new offset.
    - Errors about using natives before OnMapStart will now show the plugin causing it.

    - Updated: Plugin and test plugin.
    - Updated: "/scripting/gamedata/left4dhooks.l4d1.txt" GameData file.
    - Updated: "/scripting/gamedata/left4dhooks.l4d2.txt" GameData file.
    - Updated: "/scripting/include/left4dhooks.inc" Include file.
    - Updated: "/scripting/include/left4dhooks_stocks.inc" Include file.
    - Updated: "/scripting/l4dd/l4dd_forwards.sp" project file.
    - Updated: "/scripting/l4dd/l4dd_gamedata.sp" project file.
    - Updated: "/scripting/l4dd/l4dd_natives.sp" project file.
    - Updated: "/scripting/l4dd/l4dd_setup.sp" project file.

[SpannerV2]

Is using this and L4DToolz compatible with each other or will errors occur?

[Hawkins]

Originally Posted by SpannerV2 Is using this and L4DToolz compatible with each other or will errors occur?

They are compatible.