[luxor]

Hi allied, i tried to compile one of my plugins and compiler throwed me this weird warning :

for this function :

PHP Code:

getNum(Time)
{
    switch (Time)
    {
        case 16..20:
        {
            return 0;
        }
        case 8..15:
        {
            return 1;
        }
        case 1..7:
        {
            return 2;
        }
        default : // just in case
        {
            return -1; 
        }
    }
} 


Hope it will be fixed

[Black Rose]

getNum(Time) 
{ 
    switch (Time) 
    { 
        case 16..20: 
        { 
            return 0; 
        } 
        case 8..15: 
        { 
            return 1; 
        } 
        case 1..7: 
        { 
            return 2; 
        } 
    }
    return -1;
}

[luxor]

i don't want to avoid the bug, i went here to report it and maybe wait for a fix

[Black Rose]

It's not a bug. This is how programming works in some cases.
If the compiler would be able to find out if there was a possibility to reach the end it would be too complicated.
This way it will warn you, but you make the ultimate choice if you care or not.
If it doesn't reach the end it doesn't even matter.

Here's another example using Android Studio. This will not warn you, it will throw an error making it unable to build.

    public int Whatever() {
        int test = 0;
        if ( test == 1 )
            return 0;
    }

15:33:24 Executing tasks: [:app:assembleDebug]
15:33:25 Gradle build finished with 2 error(s) in 693ms
15:33:25 Build APK: Errors while building APK. You can find the errors in the 'Messages' view.

C:\Nerladdat\AndroidStudioProjects\*snip*.java
Error:(31, 5) error: missing return statement
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Error:Execution failed for task ':app:compileDebugJavaWithJavac'.
> Compilation failed; see the compiler error output for details.
Information:BUILD FAILED
Information:Total time: 0.638 secs
Information:2 errors
Information:0 warnings
Information:See complete output in console

[luxor]

but returning in each case including default will result return and any code below that switch should be ignored because there is not any chance to get out of that switch

[Black Rose]

But... but... but...
So what?

In this case it's easy but the switch could be nested inside an if statement or another switch. And that is too complicated to build into a compiler. It will probably cause more errors. The golden rule in coding is keeping it simple.

[WildCard65]

I have to agree, the compiler returning the warning despite a default statement in the switch existing has to be a bug as the default statement SHOULD count as the "if all fails, return this value" for the function effectively neutralizing the warning.

Edit: Ya, definitely a bug, just tried it on https://spider.limetech.org/ with the following:

PHP Code:

Test(num)
{
    switch (num)
    {
        case 1:
            return 5;
        default:
            return 4;
    }
} 


Got a warning with above test method when in reality, it's the same as:

PHP Code:

Test(num)
{
    return (num == 1 ? 5 : 4);
} 


[siriusmd99]

Originally Posted by Black Rose getNum(Time) {     switch (Time)     {         case 16..20:         {             return 0;         }         case 8..15:         {             return 1;         }         case 1..7:         {             return 2;         }     }     return -1; }

Man , this code is correct.
If number is in interval 16..20 then it will execute "return 0" and it will return 0 , return -1 won't be executed.

"return -1" will be executed only when number will be out of all cases.

P.S. I am speaking to the thread's author , just used your code as quote.

[HamletEagle]

Originally Posted by siriusmd99 Man , this code is correct. If number is in interval 16..20 then it will execute "return 0" and it will return 0 , return -1 won't be executed. "return -1" will be executed only when number will be out of all cases. P.S. I am speaking to the thread's author , just used your code as quote.

He knows the code is correct. What you don't know is that "return -1" won't be reached, since he has a "default" case. I remember Arkshine fixing something similar for if statements:

PHP Code:

if()
{
    return 1
}
else
{
    return 0
}

return -1 // this should not be needed. 


[siriusmd99]

solution is to remove default case and add return -1 at the end or just ignore that warning.