Raised This Month: $89 Target: $400
 22% 

MapChooser Extended 1.10.2 (Updated 2014-02-05)


Post New Thread Reply   
 
Thread Tools Display Modes
John.Smith
Junior Member
Join Date: Jul 2010
Old 05-17-2011 , 15:13   Re: MapChooser Extended 1.5.1 (Updated 2011-05-15)
Reply With Quote #21

Many Thanx for your work on it.

Now the script shows no more error lines in the console. ;-)

lg
Smith
John.Smith is offline
Powerlord
AlliedModders Donor
Join Date: Jun 2008
Location: Seduce Me!
Old 05-17-2011 , 15:46   Re: MapChooser Extended 1.5.1 (Updated 2011-05-15)
Reply With Quote #22

I didn't mention it here, but I updated Mapchooser Extended Sounds yesterday to make it considerably easier to add new sound sets.

Having said that, after having 4 different versions of Sounds in 3 days, I'm going to lay off making changes to both plugins unless people are finding new bugs.

Also updated the zip file in the main post again to fix extra color strings (which aren't supported in 1.5) from the Russian and Polish translations.

If people request that color support be re-added, I can add it back in for the next version and re-assign all the colors in the translation files.
__________________
Am I back? Well, we'll see.
Powerlord is offline
StrikerMan780
AlliedModders Donor
Join Date: Jul 2009
Location: Canada
Old 05-17-2011 , 23:36   Re: MapChooser Extended 1.5.1 (Updated 2011-05-15)
Reply With Quote #23

Playing in TF2, this isn't working.

Console Spam with this:
Code:
L 05/17/2011 - 22:32:20: [SM] Native "ReadPackCell" reported: DataPack operation is out of bounds.
L 05/17/2011 - 22:32:20: [SM] Displaying call stack trace for plugin "mapchooser_extended.smx":
L 05/17/2011 - 22:32:20: [SM]   [0]  Line 420, D:\tf2server\mapchooser_extended\mapchooser_extended_1.5\addons\sourcemod\scripting\mapchooser_extended.sp::Timer_StartMapVote()
__________________
StrikerMan780 is offline
Send a message via Skype™ to StrikerMan780
Powerlord
AlliedModders Donor
Join Date: Jun 2008
Location: Seduce Me!
Old 05-17-2011 , 23:54   Re: MapChooser Extended 1.5.1 (Updated 2011-05-15)
Reply With Quote #24

Quote:
Originally Posted by StrikerMan780 View Post
Playing in TF2, this isn't working.

Console Spam with this:
Code:
L 05/17/2011 - 22:32:20: [SM] Native "ReadPackCell" reported: DataPack operation is out of bounds.
L 05/17/2011 - 22:32:20: [SM] Displaying call stack trace for plugin "mapchooser_extended.smx":
L 05/17/2011 - 22:32:20: [SM]   [0]  Line 420, D:\tf2server\mapchooser_extended\mapchooser_extended_1.5\addons\sourcemod\scripting\mapchooser_extended.sp::Timer_StartMapVote()
Interesting, I'll take a look at it tomorrow to see if I can figure out what's going on (I'm going to bed in a few minutes).

Needless to say, I didn't see this behavior on my own servers.
__________________
Am I back? Well, we'll see.

Last edited by Powerlord; 05-17-2011 at 23:56.
Powerlord is offline
Powerlord
AlliedModders Donor
Join Date: Jun 2008
Location: Seduce Me!
Old 05-18-2011 , 01:37   Re: MapChooser Extended 1.5.1 (Updated 2011-05-15)
Reply With Quote #25

Quote:
Originally Posted by StrikerMan780 View Post
Playing in TF2, this isn't working.

Console Spam with this:
Code:
L 05/17/2011 - 22:32:20: [SM] Native "ReadPackCell" reported: DataPack operation is out of bounds.
L 05/17/2011 - 22:32:20: [SM] Displaying call stack trace for plugin "mapchooser_extended.smx":
L 05/17/2011 - 22:32:20: [SM]   [0]  Line 420, D:\tf2server\mapchooser_extended\mapchooser_extended_1.5\addons\sourcemod\scripting\mapchooser_extended.sp::Timer_StartMapVote()
Actually, I took a quick look at the code.

Version 1.5.2 was released. The SMX file is attached to the first post.

I'm not sure if it fixes the problem or not, because I'm not experiencing this issue. However, it now resets the internal pointer directly before reading from the DataPack, which is what I should have been doing in the first place (instead, I was resetting it in no less than 4 other places).

Strangely, despite the code now being shorter, the smx file has grown larger. I really need to ask the SourceMod team why that is...

Edit: Removed files for a moment. The previous "smx file has grown larger" was because another attempted fix was still present in the file, but it's totally unnecessary and wastes memory. Rolling back to older version and reapplying the fix, then doing a quick test of it.

Edit 2: OK, new version is tested and posted.
__________________
Am I back? Well, we'll see.

Last edited by Powerlord; 05-18-2011 at 13:39.
Powerlord is offline
MindeLT
Senior Member
Join Date: Dec 2010
Location: Lithuania
Old 05-18-2011 , 16:58   Re: MapChooser Extended 1.5.2 (Updated 2011-05-17)
Reply With Quote #26

Good job mate, very useful and well made plugin Keep going.

Btw, i'd like to ask you, why you made this plugin with no sound, and then added plugin to support sounds? Wouldn't it be good, to make a one plugin, with some Cvars, to enable/disable sounds? Thx for answer

Last edited by MindeLT; 05-18-2011 at 17:03.
MindeLT is offline
Send a message via Skype™ to MindeLT
Powerlord
AlliedModders Donor
Join Date: Jun 2008
Location: Seduce Me!
Old 05-18-2011 , 17:33   Re: MapChooser Extended 1.5.2 (Updated 2011-05-17)
Reply With Quote #27

Quote:
Originally Posted by MindeLT View Post
Btw, i'd like to ask you, why you made this plugin with no sound, and then added plugin to support sounds? Wouldn't it be good, to make a one plugin, with some Cvars, to enable/disable sounds? Thx for answer
That was how 1.4.2 and earlier worked.

Many of the servers I've visited that use Mapchooser Extended use it without sounds. By moving the sound code to a separate plugin, I've now reduced the size of the plugin for those servers. It also removes a lot of the cvars used for those sounds, making configuration files simpler.

That, and Mapchooser Extended Sounds is not the only plugin that can hook the new forwards now exposed by this plugin. Any plugin listening for those events can respond... which reminds me, I need to double-check the code for Mapchooser Extended Sounds and make sure I have it set up with the proper return codes for that...
__________________
Am I back? Well, we'll see.
Powerlord is offline
StrikerMan780
AlliedModders Donor
Join Date: Jul 2009
Location: Canada
Old 05-18-2011 , 18:39   Re: MapChooser Extended 1.5.2 (Updated 2011-05-17)
Reply With Quote #28

Any reason this is defaulting to Russian for language?
__________________
StrikerMan780 is offline
Send a message via Skype™ to StrikerMan780
Powerlord
AlliedModders Donor
Join Date: Jun 2008
Location: Seduce Me!
Old 05-18-2011 , 18:52   Re: MapChooser Extended 1.5.2 (Updated 2011-05-17)
Reply With Quote #29

Quote:
Originally Posted by StrikerMan780 View Post
Any reason this is defaulting to Russian for language?
It should be defaulting to English, unless the server is using a different language.

I'm still not completely clear on how SourceMod chooses which language to display to clients.
__________________
Am I back? Well, we'll see.
Powerlord is offline
Steell
SourceMod Donor
Join Date: Mar 2009
Old 05-18-2011 , 18:59   Re: MapChooser Extended 1.5.2 (Updated 2011-05-17)
Reply With Quote #30

Quote:
Originally Posted by Powerlord View Post
I'm still not completely clear on how SourceMod chooses which language to display to clients.
I always assumed it got that information from the server/client and then used the appropriate translations. It makes sense, since clients connecting to a server don't have to install SM yet can have phrases translated into their own language.
__________________
Steell is offline
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 11:33.


Powered by vBulletin®
Copyright ©2000 - 2019, vBulletin Solutions, Inc.
Theme made by Freecode